From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C8ADA04B1; Wed, 23 Sep 2020 18:47:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CDA011DAB1; Wed, 23 Sep 2020 18:47:24 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 6B5461D8E9 for ; Wed, 23 Sep 2020 18:47:14 +0200 (CEST) IronPort-SDR: qhiGB7nKoCu2lis3vHRBC80na0ITYQAUIBt3qwCncpwFphYQ4TfnxDiAnzS2ydZeiJqZ6nhRhh nqfc4i+6QiJw== X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="148689682" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="148689682" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 09:44:46 -0700 IronPort-SDR: 4qkDxqiWvMSDWUFZJQ+KqNepOx5bXjA1v5bPJ7CFXj75bANgMFjdmsmpUj13/PY+bWYkLLIpTB pUnoJTHDXKbg== X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="305448060" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.147]) ([10.213.218.147]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 09:44:45 -0700 To: Thomas Monjalon , dev@dpdk.org Cc: arybchenko@solarflare.com, Anatoly Burakov References: <20200913220711.3768597-1-thomas@monjalon.net> <20200913220711.3768597-13-thomas@monjalon.net> From: Ferruh Yigit Message-ID: <721acbe3-9f67-c98c-e964-6be2e1ec3f2c@intel.com> Date: Wed, 23 Sep 2020 17:44:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200913220711.3768597-13-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 12/20] net/pcap: release port upon close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/13/2020 11:07 PM, Thomas Monjalon wrote: > The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources > can be freed by rte_eth_dev_close(). > > Freeing of private port resources is moved > from the ".remove(device)" to the ".dev_close(port)" operation. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/pcap/rte_eth_pcap.c | 29 ++++++++++++++--------------- > 1 file changed, 14 insertions(+), 15 deletions(-) > > diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c > index 76e704a65a..a946fa9a1a 100644 > --- a/drivers/net/pcap/rte_eth_pcap.c > +++ b/drivers/net/pcap/rte_eth_pcap.c > @@ -734,6 +734,12 @@ eth_dev_close(struct rte_eth_dev *dev) > unsigned int i; > struct pmd_internals *internals = dev->data->dev_private; > > + if (internals == NULL) > + return 0; Not sure if this check needed, can 'internals' be null at this stage? But perhaps need to add 'RTE_PROC_PRIMARY' check. > + > + PMD_LOG(INFO, "Closing pcap ethdev on NUMA socket %d", > + rte_socket_id()); > + > /* Device wide flag, but cleanup must be performed per queue. */ > if (internals->infinite_rx) { > for (i = 0; i < dev->data->nb_rx_queues; i++) { > @@ -748,6 +754,12 @@ eth_dev_close(struct rte_eth_dev *dev) > } > } > > + rte_free(dev->process_private); > + Can we move freeing 'process_private' to 'rte_eth_dev_release_port()'