From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: Coding Style for local variables
Date: Mon, 10 Jun 2024 16:31:55 +0000 [thread overview]
Message-ID: <722d00ff8ec9497a92b831cfd13475d5@huawei.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F512@smartserver.smartshare.dk>
> The coding style guide says:
>
> "Variables should be declared at the start of a block of code rather than in the middle. The exception to this is when the variable is
> const in which case the declaration must be at the point of first use/assignment. Declaring variable inside a for loop is OK."
>
> Since DPDK switched to C11, variables can be declared where they are used, which reduces the risk of using effectively uninitialized
> variables. "Effectively uninitialized" means initialized to 0 or NULL where declared, to silence any compiler warnings about the use of
> uninitialized variables.
>
> Can we please agree to remove the recommendation/requirement to declare variables at the start of a block of code?
I know that modern C standards allow to define variable in the middle.
But I am strongly opposed to allow that in DPDK coding style.
Such practice makes code much harder to read and understand (at least for me).
Konstantin
next prev parent reply other threads:[~2024-06-10 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 15:10 Morten Brørup
2024-06-10 16:11 ` Tyler Retzlaff
2024-06-10 16:31 ` Konstantin Ananyev [this message]
2024-06-20 0:38 ` Thomas Monjalon
2024-06-20 7:53 ` Morten Brørup
2024-06-20 8:09 ` Konstantin Ananyev
2024-06-20 9:02 ` Morten Brørup
2024-06-20 14:45 ` Stephen Hemminger
2024-06-11 15:10 ` Ferruh Yigit
2024-06-11 15:50 ` Stephen Hemminger
2024-06-17 14:38 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=722d00ff8ec9497a92b831cfd13475d5@huawei.com \
--to=konstantin.ananyev@huawei.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).