From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com,
david.marchand@redhat.com, ferruh.yigit@intel.com,
michaelba@nvidia.com, viacheslavo@nvidia.com,
xiaoyun.li@intel.com
Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com, yvugenfi@redhat.com,
ybendito@redhat.com
Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support
Date: Wed, 22 Sep 2021 14:20:30 +0300 [thread overview]
Message-ID: <7238dea1-f48f-26e1-60ce-025853b4dae4@oktetlabs.ru> (raw)
In-Reply-To: <20210922095742.229262-2-maxime.coquelin@redhat.com>
On 9/22/21 12:57 PM, Maxime Coquelin wrote:
> Provide the capability to update the hash key, hash types
> and RETA table on the fly (without needing to stop/start
> the device). However, the key length and the number of RETA
> entries are fixed to 40B and 128 entries respectively. This
> is done in order to simplify the design, but may be
> revisited later as the Virtio spec provides this
> flexibility.
>
> Note that only VIRTIO_NET_F_RSS support is implemented,
> VIRTIO_NET_F_HASH_REPORT, which would enable reporting the
> packet RSS hash calculated by the device into mbuf.rss, is
> not yet supported.
>
> Regarding the default RSS configuration, it has been
> chosen to use the default Intel ixgbe key as default key,
> and default RETA is a simple modulo between the hash and
> the number of Rx queues.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
RSS may be configured on rte_eth_dev_configure() stage
using eth_conf->rx_adv_conf.rss_conf. It looks like the
patch does not handle it.
next prev parent reply other threads:[~2021-09-22 11:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 9:57 [dpdk-dev] [PATCH v2 0/5] Virtio PMD RSS support & RSS fixes Maxime Coquelin
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 1/5] net/virtio: add initial RSS support Maxime Coquelin
2021-09-22 11:20 ` Andrew Rybchenko [this message]
2021-09-22 12:28 ` Maxime Coquelin
2021-09-23 7:35 ` Xia, Chenbo
2021-09-29 9:02 ` Maxime Coquelin
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: fix RSS key length Maxime Coquelin
2021-09-22 11:25 ` Li, Xiaoyun
2021-09-23 7:52 ` Xia, Chenbo
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: fix RSS type display Maxime Coquelin
2021-09-22 12:01 ` Li, Xiaoyun
2021-09-23 7:59 ` Xia, Chenbo
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 4/5] net/mlx5: fix RSS RETA update Maxime Coquelin
2021-09-22 9:57 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: add missing flow types in port info Maxime Coquelin
2021-09-22 11:31 ` Li, Xiaoyun
2021-09-29 7:27 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7238dea1-f48f-26e1-60ce-025853b4dae4@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=amorenoz@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=michaelba@nvidia.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
--cc=ybendito@redhat.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).