From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6424DA058A; Fri, 17 Apr 2020 14:10:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BB1F41E4C7; Fri, 17 Apr 2020 14:10:37 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 57FE81DC58 for ; Fri, 17 Apr 2020 14:10:36 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id E4AEE5C00F1; Fri, 17 Apr 2020 08:10:35 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 17 Apr 2020 08:10:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=FynJesucuX2rxiszhbJ1TQvBbcF0vI7a6o7k13P7IfI=; b=mVhZu4DAP3yZ 3P61ACsVu8o0QRYOloelJKMuQ25FeU8/ots1F6vSMB7nqrJ+FWjaR4QjbAgWdl/G 07JTlgJHab/NmKYsRTdKlFtbKdpP7/0IsjDWfHLUI8XPtm0KmcydmJtYFMMdE9Fq IA2xd9IgnsIMbes4uWP+8oxFSj93F6g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=FynJesucuX2rxiszhbJ1TQvBbcF0vI7a6o7k13P7I fI=; b=YCgAssnwFTfUDLWG3vV4/Ts8IYSWeg+iR9ioXZYJp7OgwGUU6FsyTb62r GAuLaDC2qsrmKquP+2uoA5B4VcuFcHJKJnJpzvkSwTvXj/vmCc5Ie68wp77EXfKD svxuNXnKmfGsJUqAo4mBO0NrlopTKizlqAMUkbqW/1hptIkpGQgHPIdcEBoyW0W0 xzffwfccNRo3cyAXF5OfOUs9/ZvIW997GK7IAvrFsO8kEJTpCkbdr/PNA87bWT+V vGFdlKMBzmPbjwM7IR9eEw7QgjWWyczxt66bpP3EkTp5qErTBnIT4ZOwuXOhDpCb 2Zvwovdy8+L/kFpnSh0eQdcCiRmvA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrfeejgdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B3AC33280066; Fri, 17 Apr 2020 08:10:33 -0400 (EDT) From: Thomas Monjalon To: Neil Horman , Ray Kinsella Cc: dev@dpdk.org, david.marchand@redhat.com Date: Fri, 17 Apr 2020 14:10:32 +0200 Message-ID: <7246510.17fYzF0512@thomas> In-Reply-To: References: <20200416145414.262296-1-nhorman@tuxdriver.com> <10824099.L8ug28u51p@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCHv3] Remove validate-abi.sh from tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/04/2020 13:47, Ray Kinsella: > On 17/04/2020 11:20, Thomas Monjalon wrote: > > 17/04/2020 12:11, Ray Kinsella: > >> check-abi.sh appears to be backward step in terms of usability. > > > > No, check-abi.sh benefits from a nice integration in build scripts. > > See below. > > > >> With validate-abi.sh I do can do a "validate-abi.sh HEAD~1 HEAD". > >> And it will do the build, install, dump and comparison for me. > >> And it picked up my 20.0.2 - > 21.0 changes no problem. > >> > >> With check-abi on the other hand, I need to the build and install myself. > >> check-abi requires dump files, but I see no reference in the documentation to how these are created. > >> It silently fails when it doesn't find any ... > >> > >> Do I run abi-dumper on the so's myself, or how does it work? > > > > check-abi.sh is integrated in test-build.sh and test-meson-builds.sh. > > Probably we should document usage in these scripts. > > Looks like I need to set DPDK_ABI_REF_VERSION=master, not obvious. > Any tips or tricks would be welcome. export DPDK_ABI_REF_VERSION=v20.02 or export DPDK_ABI_REF_VERSION=v19.11 Depends on which compatibility you want to test...