From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8448A0546; Thu, 16 Jul 2020 17:55:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 919564F9A; Thu, 16 Jul 2020 17:55:08 +0200 (CEST) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 6CE9A2C58 for ; Thu, 16 Jul 2020 17:55:06 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id EC7B08E8; Thu, 16 Jul 2020 11:55:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 16 Jul 2020 11:55:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= UdWgEKOswq6YhpWTwpnQk692Igy6Cu7JAqrZ2VaZXSA=; b=YuM9cfRqp/v+ZRqS wxoDkFO7BJe0SSrlUTc/xWab2mg+fhGMGLAgUSA6pq9V/VHyD8lHthtMHHHvYgGz ZWStOEscuyLlYsIV8acvIQ9ayqd6a3p0FZJcXpBAoeUuLl4DbmrQniicnPCD6pxZ E4FQpTZaWfH4h84Ld7K3ZRmPkwTFmJkunA6BDlZpKl0PcE35PAEtXlmcd34pqniC VIpj/hMJhZTy3ARRtEustiwtqSGd+fKsavUC/N0vB3d9G+CUNjTVuR7UqTOafBpx EyKIZBlL1qtfiDi42LRtkvQBpEMEvIH0hpudXnW8eNNxuCOv+8jTLkX6MWRt9v0f K4CAFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=UdWgEKOswq6YhpWTwpnQk692Igy6Cu7JAqrZ2VaZX SA=; b=KD7S8IUAa7F+6SbHiPB76bo+yxmIzDbu6/O+LxL8jEC9Irx0pginD5JzD 1ryurJ1KcXdCYThmnaGknK5a/eMrYP0sPdDTVkf3BMk3cNsuah2t+l4glwZo+lQD Y/vQ6eh3/a7QF/q25aTxwJsoYkouTezLMR0djaAQDgKlH9ebYA0q6NWhbIsUn3L7 G1KH43HSF4xEVa3SVs4mFIOBs5aEY8ynSz9WXv3hIa/5NSwxahXyU/+vQvyrjvTB ucCmjnk0AUNJhF7RO5jiPHnCndl2RV/edothlNGTnHFOwLaVlVt1oa4m4SYMGiAT tFlFnHZqikYWGmVgX2Qxnz3Ma1A+g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeggdeliecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeefgeffiefhfeettdfhvdfgteekffffudekvedtvedtvdfgveeuudev gedvgeegtdenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4BB2E3060067; Thu, 16 Jul 2020 11:55:03 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Manish Chopra , Ferruh Yigit , Igor Russkikh , dpdk-dev Date: Thu, 16 Jul 2020 17:55:01 +0200 Message-ID: <72498440.BHRkrRebfW@thomas> In-Reply-To: References: <20200713151319.17547-2-manishc@marvell.com> <1914663.Rf5fFZbPsG@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/07/2020 15:02, Jerin Jacob: > On Thu, Jul 16, 2020 at 6:20 PM Thomas Monjalon wro= te: > > > > 16/07/2020 13:55, Jerin Jacob: > > > On Thu, Jul 16, 2020 at 4:57 PM Thomas Monjalon = wrote: > > > > > > > > 16/07/2020 12:27, Jerin Jacob: > > > > > On Thu, Jul 16, 2020 at 3:48 PM Ga=EBtan Rivet w= rote: > > > > > > > > > > > > On 16/07/20 12:08 +0200, Ga=EBtan Rivet wrote: > > > > > > > Re-CCing dev@dpdk.org as it was removed from the reply. > > > > > > > > > > > > > > On 13/07/20 08:13 -0700, Manish Chopra wrote: > > > > > > > > This is merely copy of latest linux/pci_regs.h in > > > > > > > > order to avoid dependency of dpdk on user headers. > > > > > > > > > > > > > > > > > > > > > > I guess this dependency is an issue on non-linux systems, whe= n you must > > > > > > > use those defines in a generic implementation. Can you confir= m this is > > > > > > > the motivation here? > > > > > > > > > > > > > > If so, I think it would be clearer to state "in order to avoid > > > > > > > dependency of DPDK on linux headers". > > > > > > > > > > > > > > > > > > > To add to it, if this is actually the motivation to add this he= ader, I > > > > > > don't think it is sufficient. > > > > > > > > > > > > You can restrict the function definition to the linux part of t= he > > > > > > PCI bus driver instead, using stubs for other systems. > > > > > > > > > > > > > > Signed-off-by: Manish Chopra > > > > > > > > Signed-off-by: Igor Russkikh > > > > > > > > --- > > > > > > > > drivers/bus/pci/linux/pci_uio.c | 2 +- > > > > > > > > drivers/bus/pci/linux/pci_vfio.c | 2 +- > > > > > > > > drivers/net/bnx2x/bnx2x.h | 2 +- > > > > > > > > drivers/net/hns3/hns3_ethdev_vf.c | 2 +- > > > > > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h | 2 +- > > > > > > > > lib/librte_pci/Makefile | 1 + > > > > > > > > lib/librte_pci/meson.build | 2 +- > > > > > > > > lib/librte_pci/rte_pci_regs.h | 1075 +++++++++++++++= ++++++++++++ > > > > > > > > 8 files changed, 1082 insertions(+), 6 deletions(-) > > > > > > > > create mode 100644 lib/librte_pci/rte_pci_regs.h > > > > > > > > > > > > > > > > > > > > > > [...] > > > > > > > > > > > > > > > diff --git a/lib/librte_pci/rte_pci_regs.h b/lib/librte_pci= /rte_pci_regs.h > > > > > > > > new file mode 100644 > > > > > > > > index 000000000..1d11f4de5 > > > > > > > > --- /dev/null > > > > > > > > +++ b/lib/librte_pci/rte_pci_regs.h > > > > > > > > @@ -0,0 +1,1075 @@ > > > > > > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-not= e */ > > > > > > > > +/* > > > > > > > > > > > > > > This file is delivered alongside the PCI lib, targeting users= pace. > > > > > > > This seems to be an exception to the license policy described= in > > > > > > > license/README. Code shared between kernel and userspace is e= xpected > > > > > > > to be dual-licensed BSD-3 and GPL-2.0. > > > > > > > > > > > > > > As it is a copy of Linux user includes, re-licensing it as BS= D-3 as well > > > > > > > is not possible. > > > > > > > > > > > > > > So I think it might require a techboard + governing board exc= eption > > > > > > > approval. Ferruh or Thomas, what do you think? > > > > > > > > > > I think, instead of importing GPL-2.0 file, We can add the consta= nts > > > > > as need by the DPDK > > > > > as symbols start from RTE_PCI_*(It will fix up the namespace as w= ell). > > > > > > > > If symbols can be found in /usr/include/, don't add anything. > > > > > > Not by default on all the distros. It is part of pciutils library. > > > Moreover, we need these symbols for Windows OS as well. > > > IMO, We should add absolute minimum constants that needed for DPDK as= RTE_PCI_* > > > > I am for mandating the dependency instead of copying it. >=20 > You mean _pciutils_ package as a mandatory dependency to DPDK. There is already this dependency: #include I'm missing the real justification for this patch. Is there some missing definitions? Is there some environments where this file is missing? > > pciutils cannot be installed on Windows? > > Why do you care about Windows? > > I don't see any contribution for qede on Windows. >=20 > You closely review the patch, it not about qede. The proposed file > comes at lib/librte_pci/rte_pci_regs.h which is common to Windows. The series is for qede. I'm trying to understand the motivation.