From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C84CA04AF; Tue, 22 Sep 2020 16:51:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EF6901DABD; Tue, 22 Sep 2020 16:51:26 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 25CCF1DABC for ; Tue, 22 Sep 2020 16:51:25 +0200 (CEST) IronPort-SDR: I8DkPexgVOdIS6CNAlEwIdHKZlwNFGEgP5ZyUjUeCvqKczOyqYkru3MuBZrE/oxwIPVdqxNDcW 5GXp63GAJWPQ== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="160688651" X-IronPort-AV: E=Sophos;i="5.77,291,1596524400"; d="scan'208";a="160688651" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 07:51:22 -0700 IronPort-SDR: a6tJVtwt0gtmyzP3CgkMm4sjCFHcagg2x8YMPOwcqm8faYINvh0RVgvM64B7XZ8pD2c5LFfJTA Kdz2Z4GYJTAw== X-IronPort-AV: E=Sophos;i="5.77,291,1596524400"; d="scan'208";a="454515056" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.227.201]) ([10.213.227.201]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 07:51:21 -0700 To: "Wei Hu (Xavier)" , dev@dpdk.org Cc: xavier.huwei@huawei.com References: <20200818120254.72792-1-huwei013@chinasoftinc.com> <20200919104708.58451-1-xavier_huwei@163.com> <20200919104708.58451-4-xavier_huwei@163.com> From: Ferruh Yigit Message-ID: <72499939-f3c1-1caa-cded-b46b489c1863@intel.com> Date: Tue, 22 Sep 2020 15:51:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.2.2 MIME-Version: 1.0 In-Reply-To: <20200919104708.58451-4-xavier_huwei@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/6] app/testpmd: remove restriction on txpkts set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/19/2020 11:47 AM, Wei Hu (Xavier) wrote: > From: Chengchang Tang > > Currently, if nb_txd is not set, the txpkts is not allowed to be set > because the nb_txd is used to avoid the numer of segments exceed the Tx > ring size and the default value of nb_txd is 0. And there is a bug that > nb_txd is the global configuration for Tx ring size and the ring size > could be changed by some command per queue. So these valid check is > unreliable and introduced unnecessary constraints. > > This patch adds a valid check function to use the real Tx ring size to > check the validity of txpkts. > > Fixes: af75078fece3 ("first public release") > Cc: stable@dpdk.org > > Signed-off-by: Chengchang Tang > Signed-off-by: Wei Hu (Xavier) > --- > app/test-pmd/config.c | 42 ++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 38 insertions(+), 4 deletions(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 4e33208..882de2d 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -2984,17 +2984,51 @@ show_tx_pkt_segments(void) > printf("Split packet: %s\n", split); > } > > +static bool > +nb_segs_is_invalid(unsigned int nb_segs) > +{ > + uint16_t port_id; > + > + RTE_ETH_FOREACH_DEV(port_id) { > + struct rte_port *port = &ports[port_id]; > + uint16_t ring_size; > + uint16_t queue_id; > + > + /* > + * When configure the txq by rte_eth_tx_queue_setup with > + * nb_tx_desc being 0, it will use a default value provided by > + * PMDs to setup this txq. If the default value is 0, it will > + * use the RTE_ETH_DEV_FALLBACK_TX_RINGSIZE to setup this txq. > + */ > + for (queue_id = 0; queue_id < nb_txq; queue_id++) { > + if (port->nb_tx_desc[queue_id]) > + ring_size = port->nb_tx_desc[queue_id]; > + else if (port->dev_info.default_txportconf.ring_size) > + ring_size = > + port->dev_info.default_txportconf.ring_size; > + else > + ring_size = RTE_ETH_DEV_FALLBACK_TX_RINGSIZE; > + > + if (ring_size < nb_segs) { > + printf("nb segments per TX packets=%u >= TX " > + "queue(%u) ring_size=%u - ignored\n", > + nb_segs, queue_id, ring_size); > + return true; > + } > + } What do you think calling 'rte_eth_rx_queue_info_get()' & 'rte_eth_tx_queue_info_get()' to get the 'nb_desc'?