From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 5A9542C54 for ; Sat, 10 Mar 2018 19:23:55 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 746F2401CC41; Sat, 10 Mar 2018 18:23:54 +0000 (UTC) Received: from [10.36.112.11] (unknown [10.36.112.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 971382026E04; Sat, 10 Mar 2018 18:23:51 +0000 (UTC) To: Xiao Wang , dev@dpdk.org Cc: zhihong.wang@intel.com, yliu@fridaylinux.org, cunming.liang@intel.com, rosen.xu@intel.com, junjie.j.chen@intel.com, dan.daly@intel.com References: <20180309230809.63361-1-xiao.w.wang@intel.com> From: Maxime Coquelin Message-ID: <7256d674-9ce6-ce8e-d6be-bcd368df25b3@redhat.com> Date: Sat, 10 Mar 2018 19:23:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180309230809.63361-1-xiao.w.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Sat, 10 Mar 2018 18:23:54 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Sat, 10 Mar 2018 18:23:54 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH 0/3] add ifcvf driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Mar 2018 18:23:55 -0000 Hi Xiao, On 03/10/2018 12:08 AM, Xiao Wang wrote: > This patch set has dependency on http://dpdk.org/dev/patchwork/patch/35635/ > (vhost: support selective datapath); > > ifc VF is compatible with virtio vring operations, this driver implements > vDPA driver ops which configures ifc VF to be a vhost data path accelerator. > > ifcvf driver uses vdev as a control domain to manage ifc VFs that belong > to it. It registers vDPA device ops to vhost lib to enable these VFs to be > used as vhost data path accelerator. > > Live migration feature is supported by ifc VF and this driver enables > it based on vhost lib. > > vDPA needs to create different containers for different devices, thus this > patch set adds APIs in eal/vfio to support multiple container. Thanks for this! That will avoind having to duplicate these functions for every new offload driver. > > Junjie Chen (1): > eal/vfio: add support for multiple container > > Xiao Wang (2): > bus/pci: expose sysfs parsing API Still, I'm not convinced the offload device should be a virtual device. It is a real PCI device, why not having a new device type for offload devices, and let the device to be probed automatically by the existing device model? Thanks, Maxime > net/ifcvf: add ifcvf driver > > config/common_base | 6 + > config/common_linuxapp | 1 + > drivers/bus/pci/linux/pci.c | 9 +- > drivers/bus/pci/linux/pci_init.h | 8 + > drivers/bus/pci/rte_bus_pci_version.map | 8 + > drivers/net/Makefile | 1 + > drivers/net/ifcvf/Makefile | 40 + > drivers/net/ifcvf/base/ifcvf.c | 329 ++++++++ > drivers/net/ifcvf/base/ifcvf.h | 156 ++++ > drivers/net/ifcvf/base/ifcvf_osdep.h | 52 ++ > drivers/net/ifcvf/ifcvf_ethdev.c | 1241 ++++++++++++++++++++++++++++++ > drivers/net/ifcvf/rte_ifcvf_version.map | 4 + > lib/librte_eal/bsdapp/eal/eal.c | 51 +- > lib/librte_eal/common/include/rte_vfio.h | 117 ++- > lib/librte_eal/linuxapp/eal/eal_vfio.c | 553 ++++++++++--- > lib/librte_eal/linuxapp/eal/eal_vfio.h | 2 + > lib/librte_eal/rte_eal_version.map | 7 + > mk/rte.app.mk | 1 + > 18 files changed, 2480 insertions(+), 106 deletions(-) > create mode 100644 drivers/net/ifcvf/Makefile > create mode 100644 drivers/net/ifcvf/base/ifcvf.c > create mode 100644 drivers/net/ifcvf/base/ifcvf.h > create mode 100644 drivers/net/ifcvf/base/ifcvf_osdep.h > create mode 100644 drivers/net/ifcvf/ifcvf_ethdev.c > create mode 100644 drivers/net/ifcvf/rte_ifcvf_version.map >