From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 4753649E0 for ; Thu, 8 Nov 2018 13:26:29 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B3107221FC; Thu, 8 Nov 2018 07:26:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 08 Nov 2018 07:26:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=cGYbH3b3fFJHTgKAaH4lZLnjiPdDfzHkjG7onrdAdNI=; b=IEZNXNm/lpsO k7uv/0leeHp15dGzUtakHw+Pdv70jKTfk7o+AyVtjobHtL8KCksaOJrSQLRDnyVH 6xj+M1g38gzc3JT813r7sIgRTf1QOzSAR/5NQ8KxbtPlh6bHI4Yu3HA7NI9W+UPR 9Hd3bNj1IGHxvin7VO8e716SKV2Znsg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=cGYbH3b3fFJHTgKAaH4lZLnjiPdDfzHkjG7onrdAd NI=; b=EOkIr0Zu14qSEY1Mfb1JMO9zEaGvob625f1GpjnGwAB/YRyL8nwGocNYl jEfxjaN1xqiHIVKgyDyU+mA5J+Y7xZMlEC2r7EGDBYHPITpurnHekLofXCTrAM60 zB/pqL8K5+d58auEp0CnJyxO13EJDp6EZLGPbQRPtolI95hItykjyOK93zd7gzT3 wVDVKBlQpJGSMm/M79q6P1PY2+ljG919hljdqUcHvtLIq1YHyibOUn8iVo1h05EO sgUPwbDUWoO2h8OB1HQ5SOAqmBWgs6nrQNE2BUW5inu8diO3BJVZVliZslJjWzkW ylCBGrjWWuZZMAf8O+iYYVWfDEzpA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DABE5E4675; Thu, 8 Nov 2018 07:26:18 -0500 (EST) From: Thomas Monjalon To: "Stojaczyk, Dariusz" Cc: dev@dpdk.org, "gaetan.rivet@6wind.com" , "Zhang, Qi Z" , "Guo, Jia" Date: Thu, 08 Nov 2018 13:26:17 +0100 Message-ID: <7262839.kmssWOtaOX@xps> In-Reply-To: References: <20181107232105.19187-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devargs: do not replace already inserted devargs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2018 12:26:29 -0000 08/11/2018 12:25, Stojaczyk, Dariusz: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > > The devargs of a device can be replaced by a newly allocated one > > when trying to probe again the same device (multi-process or > > multi-ports scenarios). This is breaking some pointer references. > > > > It can be avoided by copying the new content, freeing the new devargs, > > and returning the already inserted pointer. > > > > Signed-off-by: Thomas Monjalon > > Tested-by: Darek Stojaczyk Is it fixing any use case?