From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7F06A052A; Fri, 10 Jul 2020 16:20:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9DD7D1DAD2; Fri, 10 Jul 2020 16:20:51 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 21DDD1DA98 for ; Fri, 10 Jul 2020 16:20:50 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 9B9CE5C0191; Fri, 10 Jul 2020 10:20:47 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Fri, 10 Jul 2020 10:20:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= jrvLV6eTq495MN/CSu7cm4/FZS+ajBmHJKZYgcdGZds=; b=x1CXdL9+Au6scAZu LlDV2efS62ta93Lzm/h/wjwPHDTCqTTkKK6goPkK0vkfa7W4ZPQHHxQPu14yc004 ebBj/2PD85jM2a2hbD5mfrBr9f2rM+11mlo9lyW5GUrMhiGJB43HORbFP5vNmQi9 d2fTiJZb3l/SiIbOk2MN2GUXmp7VeA4r9jAsohxIphuM3xnVZNtID5Kf2a30YRtt maBSLA3BP2xnY08Hx1A7G8hmFu9tpCTrNFBK7l7SM9lhUjftt/MRDKi4kWG9Cz9b pmGanFf+cCaxR53jqzZ/PniUqxCIVyS/chDILRflmZqhBE4EmSvwXlSzK+1k4RGM Mzemog== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=jrvLV6eTq495MN/CSu7cm4/FZS+ajBmHJKZYgcdGZ ds=; b=GufyIewKmHJnsGm8FFmcFKGuKCNPrYi6WEBeJ9/bLtTkTrGkEKOz6JoD4 7rH25oY3yCafBlTs4r1adyOQiknWr4cl6lNv5rGpPKFW8a19a5rj0ZYStY1rNrv8 pbMkLp4qzFSXrxh+e7M19ByGWIlCYbGmn03P2FyamtmKdiRZi+qTzp+z8b8HpahB MXz8gkRvP9WU/ySV2SvPJUtnv+pFDOBO8q/YFoS2ptPGpw+PHl+xnq1exgl9anKW aJ3sw/STrSCpFhTOfJm5Q4kelPFxG4pgjcTvnMfdSveoThQ4RqoN5R4em5o208R8 d1ZBXkFX6xbWpM3kEWPwKzuq0GX2Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrvddugdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeffvdffjeeuteelfeeileduudeugfetjeelveefkeejfeeigeehteff vdekfeegudenucffohhmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvd dtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhr ohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 2D9E13280063; Fri, 10 Jul 2020 10:20:45 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: Neil Horman , John McNamara , Marko Kovacevic , dev@dpdk.org, David Marchand , Andrew Rybchenko , "Kinsella, Ray" Date: Fri, 10 Jul 2020 16:20:43 +0200 Message-ID: <7282632.B7jfezQ52p@thomas> In-Reply-To: References: <20200623134952.1273562-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: mark internal symbols in ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/06/2020 10:49, Kinsella, Ray: > On 23/06/2020 14:49, Ferruh Yigit wrote: > > The APIs are marked in the doxygen comment but better to mark the > > symbols too. This is planned for v20.11 release. > > > > Signed-off-by: Ferruh Yigit > > --- > > +* ethdev: Some internal APIs for driver usage are exported in the .map file. > > + Now DPDK has ``__rte_internal`` marker so we can mark internal APIs and move > > + them to the INTERNAL block in .map. Although these APIs are internal it will > > + break the ABI checks, that is why change is planned for 20.11. > > + The list of internal APIs are mainly ones listed in ``rte_ethdev_driver.h``. > > + > > Acked-by: Ray Kinsella > > A bunch of other folks have already annotated "internal" APIs, and added entries to > libabigail.abignore to suppress warnings. If you are 100% certain these are never used > by end applications, you could do likewise. > > That said, depreciation notice and completing in 20.11 is definitely the better approach. > See https://git.dpdk.org/dpdk/tree/devtools/libabigail.abignore#n53 I agree we can wait 20.11. Acked-by: Thomas Monjalon