From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7216643BA8; Wed, 28 Feb 2024 18:33:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5F2F141148; Wed, 28 Feb 2024 18:33:07 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2065.outbound.protection.outlook.com [40.107.243.65]) by mails.dpdk.org (Postfix) with ESMTP id 542B74003C for ; Wed, 28 Feb 2024 18:33:06 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kPADaNqLSOk25CMhkqJEtTL4oANBd5WY6TD0yRxRzZLkRHzn7Wx29F0hgpQFf9R9koEuaUd43EFyTslf66oArmhdTb9UuXcamvZky7QXGB2Fi4Yjoluee9jgAC53isspwf4gHjo5URL4wbf2xTWuot6DsZAUbpCm87a8+E8Pny3b0T1i4DHSboHDSo42rDRjL6V12rq5R/vn7Qdv7RN6uMbRpk6brLobdtElA5uOJVL0KjNaOTviwfE5RCuIMoKaIORQW+8h/oFBu4BaUdxV9CjNvNmwwZhwuuQltMDwm1leBfyhez3cR1Ybwacxu7FDjnEZ1rKTNI3lMMsBzElCQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NL+fHaBmMKVw/lG9Rq3lY0n6mKjL99fkH6DGjv032mA=; b=QppECQ3Hywcy13FceREEEDXLOeOf2sVyKGVfr456wg3S0odPYPzsmuc40gUenmS4mpXlH2oIbmgLEIAIjMyledOjPNLSjRzzgy3T3iG8YWcaJdwNHXlCqGpq4Ilo8TvpeR0EMdj31LC+GYXtJH/FH46LZRYALw8U2aXTpuxxqZQsuPSy6+NtWL2gWADs85ZMBja6/v8Dw5Ovx4WMgMsaqbW/7r6YW3ppVF98nEmhXkCoYurKG1LxF86wMuAjB7vJdh8U4eSFuKJ62ja6b0hk9RMKlTU8BtNsowmIBQa3Ile1I+kZTIudoSSRfyRchNeF+VE+VsSJLmHeEwmmQef7IA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NL+fHaBmMKVw/lG9Rq3lY0n6mKjL99fkH6DGjv032mA=; b=3EExBlMFABUnWbCvusacXfjOjmtdfu+3lDvDOvn9NQDRZnh/hZfnp9DEYxKXwjZ5rUBU8e2Q9/l7cGYOft7P8x9sfM88fPgikR5CtWTubY9BSfDtBWviLyoNXlVgyq7ydjgNkY8l86i2/8M8w9gI+rmF80jIi609FtM9sFBM89s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB8442.namprd12.prod.outlook.com (2603:10b6:8:125::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Wed, 28 Feb 2024 17:33:04 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.039; Wed, 28 Feb 2024 17:33:04 +0000 Message-ID: <728edc78-4fa1-4bb2-8e9f-f2feba6d0dc0@amd.com> Date: Wed, 28 Feb 2024 17:33:02 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] app/testpmd: support updating flow rule actions Content-Language: en-US To: Oleksandr Kolomeiets , thomas@monjalon.net, aman.deep.singh@intel.com, yuying.zhang@intel.com, orika@nvidia.com, mko-plv@napatech.com, ckm@napatech.com Cc: dev@dpdk.org References: <20240222090420.130180-1-okl-plv@napatech.com> <20240223041919.131526-1-okl-plv@napatech.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240223041919.131526-1-okl-plv@napatech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0634.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB8442:EE_ X-MS-Office365-Filtering-Correlation-Id: 8a301111-f790-4d84-c0f2-08dc388351d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mhkm6Bs1Ry401p0roCpzUAnqPETqX45zVn8LNQdm8y24b1/BYpA+BSqPNM2aa2kAd/5NBLyVCKEkPPyG8PwQC7qeuokN32Nanb+CKefbNDfIW6aESl2u2fPslmm33UFLtpw7nraOi9L6EaQy5lnJZsZA8clvOp3PvDhlo+r3zqfFWCKknUELrUmW9gk8YozSVcvgX+J+jzbL/YZbeJVw3wZLR1KeZhg/FxUPijnlROa2AjO/01cLupos3c/r0EciLHJCeShoVwIEAxGXXVcxxVtsTAVK64JfYocyyM3BTG7AHGKKFJJAO3a4TFgz9QP/dWfLR8LDwUUKguLV8RMRt/lRpYp4nRrpUTCGifp5XVGG4KJJHCh8Q9wOddyhjAACF2wBdYHVorL7WYkfTofVeayrQ1QZWfvjDN04IVXpdtUbBhyG53e4BXbSKamJqBXEiHPbAO3YznsMYT5OQ/BaIL5Yhptjj/Ain8RFs0bQ98mZ0eAKs9zFADszjnk878bJ6723Ko6i3kp7ef6hJlaKnwIAwZKm1wrtyN2Y+1mSevxIu7abZdsHHoIEtugjKmu4wbHZb9t2gzc4+1tW4ZZKDo1QA3qNOCX3aBbz0E2kNhS6JBnyoLFY+Gs8VYONvO7d X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUcrenZrS3cyQXI1VlVUMFMxRWJRTE50UWxWTkppUUlXYldyRHBzU01nZ2pI?= =?utf-8?B?ektjL0xvRUtPeVZ0bS9mZElIN2Z0UHZydlp2RGhnZFFWeHpjc3h6bVM1UUlm?= =?utf-8?B?YjlzNEl0dUlYQ2IybXhLc2VseVEweFpBakh2cWpsd2JzSGh4S2RNVVJqbXlP?= =?utf-8?B?elV1Ulk3T01QT1psMUJwWVVaWExDczAzOXE1KzJ0YW1sVkthNVdpV2s2TmJV?= =?utf-8?B?Wi9tMmJjZzdjY3pnMzJYaklYK1dTYnp2eklYTzJ6b3c2eEw2T2pSeGxIQ2l2?= =?utf-8?B?M0lPNGxqVE53MlBYNDEwN0xPdENjc0o3aHRBVEFPTkthNW9yeTlPcVMxaDJR?= =?utf-8?B?R1hITDhTTjNCem4rYnVuMDAyUUh3Y0hLcWR5c1k4V0FCbFJ5NzJINXZjaFVQ?= =?utf-8?B?TjI0N3ArTmR1ZnJSWjVIc1paS0FvblZvdzdqbVc4eUllUHZ3azlGd1dPSHpi?= =?utf-8?B?RGpFM0EwMmRndEgwMytYc0pPT3BpVVljMjNibmpTVGxGSnRlOHhOQkJ4VW12?= =?utf-8?B?QWJIci93U1k1NlRqMjMzalU2QkVaQWhhRVJmUlg3b3BlYkUvRmlTT21JT2xO?= =?utf-8?B?WTdmbVV2Tkh4Y05YWlllZHNYa3VJTFA1SXIvbnVKbGVEUUpmMVE2VGIranF3?= =?utf-8?B?SXEzRS90anlmT1BSNmQ1azFiY1BBM1VEVEc2M2J0bVZSamF1cW9iRUhGNkRO?= =?utf-8?B?a2N6RURXb1BkN1dpSzFrNHoxR29aQXY0cGwrM2lDQjhWdGlOS2JMTzVuY3Rw?= =?utf-8?B?OVFwMGdpZlRKV202VkZEaFErVHRncnRQazUvdmEvRmw3d2ljckpmUWlPbVc0?= =?utf-8?B?ZGN4R09qUTZNa0tqcHBsK3hoUEtnTUNwdm9ZSkhYd2lsZnhxenpHQmI5S0Jr?= =?utf-8?B?eW42Y3dqc1VUWFB2Nk9ncHZqSXpWenYyVmxNZlMwN3h4Z2ZIamhyVlpZSm8x?= =?utf-8?B?c0lMeUEycDRHKzJ3cGxFZHQ2TVFwdmduK3ZybjgvNndqTXVlSW5NTVdGSWIw?= =?utf-8?B?cHlXSVozZHAvNVdPWnZJSGpVWHd3WmdMcUoyRmZQQlFUN0JUckE2aHp6RjU0?= =?utf-8?B?b1NWYWUySjNCWUVYVnkxdkNXVG1HdEFOOHBIWlJEcWNIcEdEdUw4VDF6M0pU?= =?utf-8?B?RUdMbUtueWZ0UEIxSlM0a2wxSzQ2Vk40VlA3czZSOGRjMDZleUttTzVPbjlN?= =?utf-8?B?OGh5d0NWU3R2dWwwVE55NUswY3o5bW15RnpMa1BpS2V0Y0cvYlU5YmdRL09X?= =?utf-8?B?R3JjTmRuS0NwNHlTbEppa3ZYQkk4bzFvNEJpRURrWWZJOVd6WEcrNU1ZemlH?= =?utf-8?B?bHIrKzg2eW9UQjlSQUJLb3M0VVFESnEvK2xpNEtwVmlQdE00d0lkNEYrRzRj?= =?utf-8?B?NEdOdDR0bERiaGdudFpKbDZKbHIxcUJqUzBUWm9MT0lOVW4zdFpPcU9VUVk4?= =?utf-8?B?b2ExdGNQRU1YY2F1dnBOajIzeUw0RWp2TTgraGFBUFNVajFLYUZUdzhRZUdV?= =?utf-8?B?NThPdWRacVk3TzN2OUNBQmN6a3RqNmwyUVQzV3hndERQQ1RBR3JuczhRbWNk?= =?utf-8?B?OWZCcE1VOVJtQ0lmcDFBbXVpL3Z1THc4MjlQZU9LUzVySHVvS3hXcW16ajg3?= =?utf-8?B?WlUzWXgvRVJISlpXMnVUdjN3eDl4bW5UT0w1SFU1OVBIQ2JnaVVYT3dYdUta?= =?utf-8?B?OVFMcDdhZFltRWxBaDBXUzJHSnAzZ1lBczBsRlRXbGZlaTZPUFBRSkVzbEl4?= =?utf-8?B?SWEraWJZTlI1WldPNkV2enVLalljbDh2KzBJR1hDeGFVbnB6OUs2Y1U4OVh0?= =?utf-8?B?djRjYzlNd1dxbFBJSXpGVmwzYW00U1BkMmU1S2ExV21XY2tMZHlCSktBRlA5?= =?utf-8?B?UmRId05VQURGRFpFTU56SExjSzZ3OFczcFdOTmNFKzZPUjgwSTlVRFhFWlEv?= =?utf-8?B?bFhWdFdqb0VJSGpCN3QvRFZwNEpnWVh3czg5endBYThTLzZMRFU4NlZYRnZS?= =?utf-8?B?R0Ywb3QxU3R1TTJMYjJMNlVnbjErS01uUTlBYWFyWklvaXdNaFV5WXVwVnhE?= =?utf-8?B?MjBVeXFNYy9IVWdUOGZlRnEyUm9uaDAwOWQrUHhJVHlzVVlsQTRrN2dxMHRK?= =?utf-8?Q?hP+Hbx7F5HED/fiNm50czZ6BM?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a301111-f790-4d84-c0f2-08dc388351d3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 17:33:04.6355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5Pi/m9dPcGAfJk6tShYMfoFYOFLZqcKNwefcNcoEHH8RQTq02cMy0NBvL3ZKLRlp X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8442 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/23/2024 4:19 AM, Oleksandr Kolomeiets wrote: > "flow update" updates a flow rule specified by a rule ID with a > new action list by making a call to "rte_flow_actions_update()": > > flow update {port_id} {rule_id} > actions {action} [/ {action} [...]] / end [user_id] > > Creating, updating and destroying a flow rule: > > testpmd> flow create 0 group 1 pattern eth / end actions drop / end > Flow rule #0 created > testpmd> flow update 0 0 actions queue index 1 / end > Flow rule #0 updated with new actions > testpmd> flow destroy 0 rule 0 > Flow rule #0 destroyed > > Signed-off-by: Oleksandr Kolomeiets > Reviewed-by: Mykola Kostenok > Reviewed-by: Christian Koue Muf > Patch looks good to me. @Ori, @Thomas, do you have any comment, if not I will proceed with the patch?