From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90415A00BE; Thu, 28 May 2020 10:34:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 541441DA4C; Thu, 28 May 2020 10:34:16 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 595971DA37 for ; Thu, 28 May 2020 10:34:15 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 1535E5C010E; Thu, 28 May 2020 04:34:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 28 May 2020 04:34:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= TZ4xGs9MPgLROF3+CoDgDDJAmi2uCkpdGXFCotlgryI=; b=j4gYaYjMETje6c4v ty0DYHZz2NjAiY1Iei7l8cryszJWnygF0I0uLDhe3Bil/QbHKEdglSF78Mb6InBJ 4+wfpFMiOYYPozUu8/MzWWw1C41pgZ9i+y3R7qWh2bDhHtg4Ww1vhoqzAnN4XkKo 1zzAyA2Hmy3NcWv75e50EkbSZ12PTQbsrIUvgVKHKmBeGfW6BVU34H9KIgdcKme0 ig9P6SwBbCrzcY6SH7S2OC8/mcCDdJ5QMLaMyXOvyW1tOv+24g6jTs943kgo8cqT a8cTx5FfGD6UVP4sfqm0pDk9PW/Xp+tRdZUxb+dDnvrNPXPKXpS7uGUvNioWTPqp 7fTiIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=TZ4xGs9MPgLROF3+CoDgDDJAmi2uCkpdGXFCotlgr yI=; b=XjihCaAoCFtfFQWKW+SKs30DBlibv4NNKXUe2qaVwyf8Nsoabx1tAMLT1 WuYSXrbV7ZZpAEbjx2wn2LJByjVUigWL3S+PeXYwy3zYrkqNNUsZXUUmMFIZvFqZ 0JjcdwWtmla4S1I3Ghs4sKB+Hegl+ZWKWSG80xE2JD/xXomsk+1sBcmhbPYmpKPf B/K+cO7lt2577POcwSn5EEAb+AvcLorpocjHuOudSjQqHrvXnMChtEtRSoVs37SS pEwlbDz1cpw4Xk6d3rPBt+2m+xgeo2ttuvwIVNlQlPF7oUKuZwWiFLVdQinCYCc6 HATVC48xnLIFsU/M7VlMwZ4QhnyYg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddviedgtdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B9CA73280065; Thu, 28 May 2020 04:34:11 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk Cc: dev@dpdk.org, Dmitry Malloy , Narcisa Ana Maria Vasile , Fady Bader , Tal Shnaiderman , Anatoly Burakov Date: Thu, 28 May 2020 10:34:10 +0200 Message-ID: <7297782.lDsbsqoCLS@thomas> In-Reply-To: <20200525003720.6410-6-dmitry.kozliuk@gmail.com> References: <20200428235015.2820677-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-1-dmitry.kozliuk@gmail.com> <20200525003720.6410-6-dmitry.kozliuk@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 05/11] eal/mem: extract common code for dynamic memory allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/05/2020 02:37, Dmitry Kozlyuk: > Code in Linux EAL that supports dynamic memory allocation (as opposed to > static allocation used by FreeBSD) is not OS-dependent and can be reused > by Windows EAL. Move such code to a file compiled only for the OS that > require it. > > Signed-off-by: Dmitry Kozlyuk > --- > @@ -1943,7 +1633,7 @@ rte_eal_hugepage_init(void) > { > return internal_config.legacy_mem ? > eal_legacy_hugepage_init() : > - eal_hugepage_init(); > + eal_dynmem_hugepage_init(); There is a compilation issue, building clang+shared: undefined reference to `eal_dynmem_hugepage_init'