From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A73042575; Tue, 12 Sep 2023 03:49:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 976CD40272; Tue, 12 Sep 2023 03:49:23 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 22C3C40269 for ; Tue, 12 Sep 2023 03:49:22 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Rl5zD6blKzVkVr; Tue, 12 Sep 2023 09:46:32 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 12 Sep 2023 09:49:17 +0800 Message-ID: <72b86604-df2f-6704-d5fe-40a8e48d80cc@huawei.com> Date: Tue, 12 Sep 2023 09:49:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm To: Stephen Hemminger CC: , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , References: <20230315110033.30143-1-liudongdong3@huawei.com> <20230826074607.16771-1-haijie1@huawei.com> <20230826074607.16771-2-haijie1@huawei.com> <20230906081017.5d490c53@hermes.local> <90d47caa-5e45-67c2-a2b8-05ac57bdb618@huawei.com> <20230908135810.71588a74@hermes.local> From: Jie Hai In-Reply-To: <20230908135810.71588a74@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/9/9 4:58, Stephen Hemminger wrote: > On Fri, 8 Sep 2023 17:28:08 +0800 > Jie Hai wrote: > >> Hi, Stephen Hemminger >> >> On 2023/9/6 23:10, Stephen Hemminger wrote: >>> On Sat, 26 Aug 2023 15:46:03 +0800 >>> Jie Hai wrote: >>> >>>> Currently, rte_eth_rss_conf supports configuring and querying >>>> rss hash functions, rss key and it's length, but not rss hash >>>> algorithm. >>>> >>>> The structure ``rte_eth_rss_conf`` is extended by adding a new >>>> field "func". This represents the RSS algorithms to apply. The >>>> following API is affected: >>>> - rte_eth_dev_configure >>>> - rte_eth_dev_rss_hash_update >>>> - rte_eth_dev_rss_hash_conf_get >>>> >>>> If the value of "func" used for configuration is a gibberish >>>> value, report the error and return. Do the same for >>>> rte_eth_dev_rss_hash_update and rte_eth_dev_configure. >>>> >>>> To check whether the drivers report the "func" field, it is set >>>> to default value before querying. >>>> >>>> Signed-off-by: Jie Hai >>>> Signed-off-by: Dongdong Liu >>> >>> This is unannounced API/ABI change. >> Thanks for pointing that. I'm sorry I didn't pay attention to this before. >> What should I do with this set of patches? >> Is it feasible to send annouce now? > > Since this API/ABI breaking release, I am ok taking it. But will need a release > note. Also you should treat 0 as "no change" case to allow for code that does hash_update > without setting the value. > The release note 'doc/guides/rel_notes/release_23_11.rst' has been updated in this patch. Please check it. Whether or not to treat 0 as no change depends on the implemetation of the driver. According to the drivers that support algorithm modification through the flow API, the 0 is regarded as no change. It is believed that these drivers have the same behavior when updating the hash_update with setting algorithm. For the current drivers that do hash_update without setting the 'func' value, the implemetation does not involve the modification of the algorithm. In either case, 0 is regarded as "no change". > > .