From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47714A00C4; Fri, 29 Jul 2022 19:33:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9AF44069C; Fri, 29 Jul 2022 19:33:36 +0200 (CEST) Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244]) by mails.dpdk.org (Postfix) with ESMTP id A7B2940151 for ; Fri, 29 Jul 2022 19:33:35 +0200 (CEST) Received: from [IPV6:2a01:c846:1282:6700:b822:3860:b95f:29c6] (unknown [IPv6:2a01:c846:1282:6700:b822:3860:b95f:29c6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by office2.cesnet.cz (Postfix) with ESMTPSA id 1566B40006C; Fri, 29 Jul 2022 19:33:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz; s=office2-2020; t=1659116015; bh=VQcogSEoqrMrdDCsHjhTR1dWPpNd4Hyqi20Dt+rVOzY=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=IH7xP97T/f8iivbuhmCd7nKzludP5n76edmAVkT67fxZUR/RgySJjVK6ovj9gwZzQ VKjO3zntMNq6s97amJtk8hlG+cboTLAuRuN8oC+6e8KG9tsN1YkVHfepT8juQR0ZYk k5WkF3ZkIuTXGt9zeUxMWwVEvGJiL/P9QWeqCc+0iso4eQ85ah4ZN9VHi1H9KZbKgh fMSZT3Du5+wGZ6G+2t9O61Y06/iHRv+X+DC6SUo9EvafQb8I9OlsdwKrRYOeQ3eN1A AEY7ZAmjSvVikNWtoqtvErQ4URHy1bhY+H5gy/AsoGy/8KvRWV7V6ITtwLVA83U7BP OHN7+RremRbOQ== Message-ID: <72d44e49-e899-1689-6ca1-b477eca35fc4@cesnet.cz> Date: Fri, 29 Jul 2022 19:33:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 0/2] pcapng: fix some issues with writing packets. Content-Language: sk-SK To: Stephen Hemminger Cc: dev@dpdk.org, mdr@ashroe.eu, reshma.pattan@intel.com References: <20220725152811.409447-1-kuka@cesnet.cz> <20220729071841.18198-1-kuka@cesnet.cz> <20220729085850.170d1e03@hermes.local> From: =?UTF-8?Q?M=c3=a1rio_Kuka?= In-Reply-To: <20220729085850.170d1e03@hermes.local> Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms050509090406050900020101" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This is a cryptographically signed message in MIME format. --------------ms050509090406050900020101 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit > You ignored my feedback from earlier patch. > It seems you are adding a lot more here that is necessary. I split the changes into two separate patches, where [PATCH v2 1/2] addresses the IOV_MAX limit issue and where I've incorporated your feedback + added a unit test that tests this situation. if I did something wrong, let me know. The problem of partial writig is addressed in the second patch [PATCH v2 2/2] On 29/07/2022 17:58, Stephen Hemminger wrote: > On Fri, 29 Jul 2022 09:18:39 +0200 > Mário Kuka wrote: > >> This patchset contains fixes for some issues that occur when writing a >> large burst of packets at once, such as writing more packets than the >> IOV_MAX limit and the problem of partial writing of a packet to a file >> if the writev() system call performs a partial write. >> >> The typical use of pcapng in our cases is to copy the packets into a >> separate buffer and the process of writing to the file is done in some >> slow path, for example by writing in a separate thread or at the end of >> the application, where we don't mind the limitation of the typically >> slow speed of the storage medium. >> >> Mário Kuka (2): >> pcapng: fix write more packets than IOV_MAX limit >> pcapng: check if writev() returns a partial write >> >> app/test/test_pcapng.c | 42 +++++++++++++++++- >> lib/pcapng/rte_pcapng.c | 96 +++++++++++++++++++++++++++++++++-------- >> 2 files changed, 120 insertions(+), 18 deletions(-) >> > You ignored my feedback from earlier patch. > It seems you are adding a lot more here that is necessary. --------------ms050509090406050900020101 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC DU4wggZgMIIESKADAgECAhEAnTCbnaNwi54ahsTjQqFVbTANBgkqhkiG9w0BAQwFADBGMQsw CQYDVQQGEwJOTDEZMBcGA1UEChMQR0VBTlQgVmVyZW5pZ2luZzEcMBoGA1UEAxMTR0VBTlQg UGVyc29uYWwgQ0EgNDAeFw0yMTA0MjUwMDAwMDBaFw0yNDA0MjQyMzU5NTlaMIHbMQ8wDQYD VQQREwYxNjAgMDAxODA2BgNVBAoML0NFU05FVCwgesOham1vdsOpIHNkcnXFvmVuw60gcHLD oXZuaWNrw71jaCBvc29iMRYwFAYDVQQJEw0xOTAzLzQgWmlrb3ZhMR4wHAYDVQQIDBVQcmFo YSwgSGxhdm7DrSBtxJtzdG8xDjAMBgNVBAcTBVByYWhhMQswCQYDVQQGEwJDWjEUMBIGA1UE AwwLTcOhcmlvIEt1a2ExIzAhBgkqhkiG9w0BCQEWFG1hcmlvLmt1a2FAY2VzbmV0LmN6MIIB IjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAsf8rfNlSMXsoruJ2DkRtAGXBvekIfYKu HfaRR7BzICsgHgjwxDZl1bIqTMuwiadre+QI2EN4h7DqAI8+ws7s+RUtSD9/v4yWMsSobX+7 AfbDbmJaK7phomafkH4oEzZ9nGvlI6M55bZx18xMvBa5s/gxmqTjvpcU1aFBPOcPHf+w50wX prt5TyFFgEONgBZuh8ksJBI5Ys+X1UAECLpODB12NrGoe41kSRPa/mYQoDnYRzMAO7s4yOsZ Lja5vB5D1rMhVCl7A8oxOwoYD6uB4dFgs+DiYMaVmWq203z1HYXJYEXVY/8si7oduuNNgpcn sbXcL02KoGeofxGvMhmtmQIDAQABo4IBsTCCAa0wHwYDVR0jBBgwFoAUaQChxyFY+ODFGyCw Ct2nUb8T2eQwHQYDVR0OBBYEFGT7KhoInChuIvFudYBTuvn7CYGHMA4GA1UdDwEB/wQEAwIF oDAMBgNVHRMBAf8EAjAAMB0GA1UdJQQWMBQGCCsGAQUFBwMEBggrBgEFBQcDAjA/BgNVHSAE ODA2MDQGCysGAQQBsjEBAgJPMCUwIwYIKwYBBQUHAgEWF2h0dHBzOi8vc2VjdGlnby5jb20v Q1BTMEIGA1UdHwQ7MDkwN6A1oDOGMWh0dHA6Ly9HRUFOVC5jcmwuc2VjdGlnby5jb20vR0VB TlRQZXJzb25hbENBNC5jcmwweAYIKwYBBQUHAQEEbDBqMD0GCCsGAQUFBzAChjFodHRwOi8v R0VBTlQuY3J0LnNlY3RpZ28uY29tL0dFQU5UUGVyc29uYWxDQTQuY3J0MCkGCCsGAQUFBzAB hh1odHRwOi8vR0VBTlQub2NzcC5zZWN0aWdvLmNvbTAvBgNVHREEKDAmgQ5rdWthQGNlc25l dC5jeoEUbWFyaW8ua3VrYUBjZXNuZXQuY3owDQYJKoZIhvcNAQEMBQADggIBAKo5G/n3+Jrh XgEyDb1wwr2l3FaT5kGMkrDL6ulfknNH/64+rl+ntotYQ5a/czugYk2FalK9L9onrk15+elW jRQ/9CNJ69rpF9DY/+LHoTod33zXniI0Sm51/31raA4Jc+JSbGaNwfimM8d5Yp9+w3HmVFNO 7MLvx6ZD2ypo4gvMb5tKwxr+gXKpeY9dSVvhBjVCk2CCYGDXHbmTup6cOrtWHVxBz/brFaK/ kBWPHqQwOIC9RYacOa3VTo5w+vnEDT1b3GMNHtxoKc0nmG4oemL37lbAHDbNko0LQMUnSpJ2 qo6ABJfEMEK1mLBtX0FONqMHqq4M7iUQs3m3fasx3iom7jFybpe6uWkU8Kq8RimTVv2qngnL xIhhshjg4UtBe7ojHQWWE+08nojeXqUHK8O1JjKb3FibWHJEPwNuW7pntgyeOqnx3kw1Dxk0 WFDb52iCKzSBp8cj/NurHR5YlLtR3QiV3DAIvjTTBfsHaQ/N1xkSe7A+eLjU203JsuFvB8tR +sBDAifp9bIqY0RqPVIAl3/WmFk3Pk4IoJDDchezNLPwVPg3w1TWA0ZskiwVnXnhbnx9CnCQ FtlpA3S32tsyNinDnDeCLjIFmYWnLykJs/310NlYWrjZYYPlnfPcXEse/219rehe7yueG4oL SvprVV6BqPG8Whgx9bAMH83kMIIG5jCCBM6gAwIBAgIQMQJw1DW+mySa+FbQ4eKFSTANBgkq hkiG9w0BAQwFADCBiDELMAkGA1UEBhMCVVMxEzARBgNVBAgTCk5ldyBKZXJzZXkxFDASBgNV BAcTC0plcnNleSBDaXR5MR4wHAYDVQQKExVUaGUgVVNFUlRSVVNUIE5ldHdvcmsxLjAsBgNV BAMTJVVTRVJUcnVzdCBSU0EgQ2VydGlmaWNhdGlvbiBBdXRob3JpdHkwHhcNMjAwMjE4MDAw MDAwWhcNMzMwNTAxMjM1OTU5WjBGMQswCQYDVQQGEwJOTDEZMBcGA1UEChMQR0VBTlQgVmVy ZW5pZ2luZzEcMBoGA1UEAxMTR0VBTlQgUGVyc29uYWwgQ0EgNDCCAiIwDQYJKoZIhvcNAQEB BQADggIPADCCAgoCggIBALNK4iJeJ1vpBFsUBDUyIBSutNIxQMbNUMAeoUTKr55KYX8tkN5i mzNqLaRCypYBPP9wED2AaO6e8njkbjzJwLgPqDBkW9sG3kmi3GW6cF4Hwr5ysZqve/5EJDhV +9OhfTu/4dMnoR4Q41HcjMk9MzLOADAQ0awBZ/29r0d49AUmIKELNeqEqmnTN6fndL7x/2K0 TLToZLxqS7sy/Jvi0wEFr0CfdjcAsioh7KaD+Jizyb1aRKQzJ6Q20VEHX7UqWc1SkzTkbz6x j0S5ydBBFQh0fNiy+qM/deVpK4HgmPSJrrpQZ+LlbHfWabmwoDPxF71QZVYiqrrAoUrGRJ+4 7iLBiIg8miIYS7Hd2ppvAUt24CugMXUjETjQ+oYh09fNi5n/AvoER8UBvTHLxt+blL0bvL+2 z2YiUWk+2Qtn+dD+JU5Z2y71qV7+cr+4YXjvGzF5bYsi8HiwflTb4Php3y+k1twKtchdcq2Q Gc0eDG6Y01nRHUiyr8/PtMAsLHEPNZ2wzsA7fb8mftHiV20ZFmYqknJ8AIOfwdTVA+E62Jay OJ+sxadqcmFDorsz/mrPwGZ8+txr4xSuvVjg0dlv0yuA+1YpBDIYNfL4bkX+IcZ1mTstL4Xw 0f4N2iW3bBmnPnYmoYxMM8gflCiTgss73nBvG2f7v1PD7BDGYNO4iD4vAgMBAAGjggGLMIIB hzAfBgNVHSMEGDAWgBRTeb9aqitKz1SA4dibwJ3ysgNmyzAdBgNVHQ4EFgQUaQChxyFY+ODF GyCwCt2nUb8T2eQwDgYDVR0PAQH/BAQDAgGGMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMDgGA1UdIAQxMC8wLQYEVR0gADAlMCMGCCsGAQUF BwIBFhdodHRwczovL3NlY3RpZ28uY29tL0NQUzBQBgNVHR8ESTBHMEWgQ6BBhj9odHRwOi8v Y3JsLnVzZXJ0cnVzdC5jb20vVVNFUlRydXN0UlNBQ2VydGlmaWNhdGlvbkF1dGhvcml0eS5j cmwwdgYIKwYBBQUHAQEEajBoMD8GCCsGAQUFBzAChjNodHRwOi8vY3J0LnVzZXJ0cnVzdC5j b20vVVNFUlRydXN0UlNBQWRkVHJ1c3RDQS5jcnQwJQYIKwYBBQUHMAGGGWh0dHA6Ly9vY3Nw LnVzZXJ0cnVzdC5jb20wDQYJKoZIhvcNAQEMBQADggIBAAoFTnsNjx8TOQD9b+xixsPt7Req 4wHMeNw/R5dddEPgQAQAYJZKz5BEv1cjGbH7nbPH3AxrxhN6OVH40p6OLIo9MXSrrfMzGs7/ P+FTCjwgNxFEtLQ1KC9NboA3asJcl7mIs3l8h9iAgEH1zLUvq2s+5n++NQmbzudDsTFDMapY 3kX1TwyUCTRzmItqcbsYIyg2MeIXWfRtqPqC5R4bufmpzA5BPINLX340Sp/CNQ9QZqw3Vkfy HWwTo+vO9Gm2L6srNamJT6Lb+TeXZvl8UPL5a72O/pH0GgGHjt6z9QzPARnaRKshVWviNK6S T4WmZHllu3CJg0BXqx1vWyswawgvNeWt1qxITacYe9mSWTbNR2CftvTUwerruDSY2jMaZPoN qbjUpuG/blYwWzzvVerBUhviAahPXJF/9V48ybWPBq6qKOEokW+s3B4ad5sY96KlovEijaIQ Dip1HO0SD+rLNYaiBcr9MV2aK+DfbZ8w9BaNCQyFEYwzxIKOVk3bYvzHRk5ihUDascmbk/bk iNl74c/KfuKQmJImaqWoWZR6jBcXcPV0WUIKz/nILTpFhGojZEQW77by3aezAi9jrEIUBHRG 1LwzPbJc2V3SOzYyaJFQatzuKZbN1Q9s9y/2x1QXtKwREY8jNgvx0iIfOK35gKgYJJcyDql4 XfuEc2nVMYIDOzCCAzcCAQEwWzBGMQswCQYDVQQGEwJOTDEZMBcGA1UEChMQR0VBTlQgVmVy ZW5pZ2luZzEcMBoGA1UEAxMTR0VBTlQgUGVyc29uYWwgQ0EgNAIRAJ0wm52jcIueGobE40Kh VW0wDQYJYIZIAWUDBAIBBQCgggGxMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZI hvcNAQkFMQ8XDTIyMDcyOTE3MzMzNVowLwYJKoZIhvcNAQkEMSIEIHOpzptHiqD72AeL0AKE C4tuOECVNru57d2Z6teRJFreMGoGCSsGAQQBgjcQBDFdMFswRjELMAkGA1UEBhMCTkwxGTAX BgNVBAoTEEdFQU5UIFZlcmVuaWdpbmcxHDAaBgNVBAMTE0dFQU5UIFBlcnNvbmFsIENBIDQC EQCdMJudo3CLnhqGxONCoVVtMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCG SAFlAwQBAjAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYF Kw4DAgcwDQYIKoZIhvcNAwICASgwbAYLKoZIhvcNAQkQAgsxXaBbMEYxCzAJBgNVBAYTAk5M MRkwFwYDVQQKExBHRUFOVCBWZXJlbmlnaW5nMRwwGgYDVQQDExNHRUFOVCBQZXJzb25hbCBD QSA0AhEAnTCbnaNwi54ahsTjQqFVbTANBgkqhkiG9w0BAQEFAASCAQAF37/7G4v1BWJMk0ft rguhGWnybc7AKfi1FuI9Xt7gCHzLubv1e4PgOlY5okoSaw4mJhXtQetpYer9awAOQk5A/Zx2 nroactZ9yy4PeuNmfOjoOpyMGAduLQXMIxS9vy7PGTzUw9iqGz9xp2jaPFqFBOUF/iP8ybQQ br+IASgU1qjGO5YoYc5Wq9p6GtyKboc0JQHwgvKSqjvJfc0RmiaE1HFMv+f70ID9oLFwXUXc PgaovADhfNw8zZeKx3CG+JSHj3uzxOTRVesVWk24H02nAJYzQEzoGb9BdPyUgWjsX1GR76W/ UQTHmDNK1m4m5UHcvg5eZuhLnI+4dozNxqK2AAAAAAAA --------------ms050509090406050900020101--