From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60F1641C5F; Fri, 10 Feb 2023 10:40:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 471FD40EE6; Fri, 10 Feb 2023 10:40:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A25F2410EA for ; Fri, 10 Feb 2023 10:40:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676022008; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N4RuIlvWlkobZmDXqBs6xCQwNgtKfsSCQrLS7z7jFmM=; b=NFxYTHROzyU8y2Z1OXakHwmybku/Jh+AE3vMCqVg2vrWt8FRwpOvu1F0FOxAgH0zmtl2fS +T7tSU6zWcy0hw4XhstqNrKXC5Ui6Zp1p1XJzWikfzt72ZdDszmGuVrZvHEJymERDhNwti ZRjPbxQhMBn5mZJn52kWznXgb48q0Hc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-547-ss9XVKJjPLGiU78fWHgl8Q-1; Fri, 10 Feb 2023 04:40:04 -0500 X-MC-Unique: ss9XVKJjPLGiU78fWHgl8Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5B2931C07831; Fri, 10 Feb 2023 09:40:04 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67B8A2026D4B; Fri, 10 Feb 2023 09:40:03 +0000 (UTC) Message-ID: <72db48a8-569c-dcdc-14e5-296b665a1f14@redhat.com> Date: Fri, 10 Feb 2023 10:40:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v1 6/9] baseband/acc: fix iteration counter in TB mode To: Nicolas Chautru , dev@dpdk.org Cc: hernan.vargas@intel.com, stable@dpdk.org References: <20230209221929.265059-1-nicolas.chautru@intel.com> <20230209221929.265059-7-nicolas.chautru@intel.com> From: Maxime Coquelin In-Reply-To: <20230209221929.265059-7-nicolas.chautru@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/9/23 23:19, Nicolas Chautru wrote: > The iteration count was not using correct structure (4G vs 5G) > in TB mode. > > Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") > Cc: stable@dpdk.org > > Signed-off-by: Nicolas Chautru > --- > drivers/baseband/acc/rte_vrb_pmd.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c > index b251ad25c6..0bd5c65177 100644 > --- a/drivers/baseband/acc/rte_vrb_pmd.c > +++ b/drivers/baseband/acc/rte_vrb_pmd.c > @@ -2876,7 +2876,7 @@ vrb_dequeue_ldpc_dec_one_op_cb(struct rte_bbdev_queue_data *q_data, > return 1; > } > > -/* Dequeue one decode operations from device in TB mode. */ > +/* Dequeue one decode operations from device in TB mode for 4G or 5G. */ > static inline int > vrb_dequeue_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op **ref_op, > uint16_t dequeued_cbs, uint32_t *aq_dequeued) > @@ -2930,8 +2930,12 @@ vrb_dequeue_dec_one_op_tb(struct acc_queue *q, struct rte_bbdev_dec_op **ref_op, > /* CRC invalid if error exists. */ > if (!op->status) > op->status |= rsp.crc_status << RTE_BBDEV_CRC_ERROR; > - op->turbo_dec.iter_count = RTE_MAX((uint8_t) rsp.iter_cnt, > - op->turbo_dec.iter_count); > + if (q->op_type == RTE_BBDEV_OP_LDPC_DEC) > + op->ldpc_dec.iter_count = RTE_MAX((uint8_t) rsp.iter_cnt, > + op->ldpc_dec.iter_count); > + else > + op->turbo_dec.iter_count = RTE_MAX((uint8_t) rsp.iter_cnt, > + op->turbo_dec.iter_count); > > /* Check if this is the last desc in batch (Atomic Queue). */ > if (desc->req.last_desc_in_batch) { Reviewed-by: Maxime Coquelin Thanks, Maxime