From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 81C7C1B0FF; Tue, 11 Dec 2018 19:30:25 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A391EA7ED; Tue, 11 Dec 2018 18:30:24 +0000 (UTC) Received: from [10.36.112.28] (ovpn-112-28.ams2.redhat.com [10.36.112.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4784B1059580; Tue, 11 Dec 2018 18:30:20 +0000 (UTC) To: Jens Freimann Cc: dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com, stable@dpdk.org References: <20181127095451.18217-1-maxime.coquelin@redhat.com> <20181127103028.tsbjraer4oz3wiss@jenstp.localdomain> From: Maxime Coquelin Message-ID: <72dc38b9-f49f-ad3b-b99e-4e11fcf1894f@redhat.com> Date: Tue, 11 Dec 2018 19:30:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181127103028.tsbjraer4oz3wiss@jenstp.localdomain> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 11 Dec 2018 18:30:24 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] vhost: fix possible null pointer dereferencing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Dec 2018 18:30:25 -0000 On 11/27/18 11:30 AM, Jens Freimann wrote: > On Tue, Nov 27, 2018 at 10:54:51AM +0100, Maxime Coquelin wrote: >> If mmap() call fails in vhost_user_set_mem_table, dev->mem >> is set to NULL. If later, qva_to_vva() is called, a segfault >> occurs. >> >> Fixes: 8f972312b8f4 ("vhost: support vhost-user") >> Cc: stable@dpdk.org >> >> Reviewed-by: Tiwei Bie >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost_user.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> > > Jumping to an out label would have worked as well, but it doesn't > really matter. > > Reviewed-by: Jens Freimann > Thanks, applied with label change you suggested. Maxime