DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@oss.nxp.com>
To: David Marchand <david.marchand@redhat.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: thomas@monjalon.net, dev@dpdk.org, stephen@networkplumber.org,
	stable@dpdk.org
Subject: Re: [PATCH 1/2] bus/dpaa: fix lock condition during error handling
Date: Thu, 14 Nov 2024 13:15:52 +0530	[thread overview]
Message-ID: <72de698d-d689-7448-ac16-76ca3762256f@oss.nxp.com> (raw)
In-Reply-To: <CAJFAV8yzFz0aTW02ddNed52-+TRQmxEaSJ5PcL6nq6K2B5ZSNA@mail.gmail.com>


On 13-11-2024 22:18, David Marchand wrote:
> Hello Hemant,
>
> On Wed, Nov 13, 2024 at 5:15 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>> The error handling is missing FQ unlock code.
>> Detected by pvr-studio
>> Bug 89-93: very suspicious synchronization
>> The analyzer issued a pack of V1020 warnings that a resource
>> might remain blocked.
>>
>> Fixes: c47ff048b99a ("bus/dpaa: add QMAN driver core routines")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> The fix looks good to me.
>
> To avoid regressions on this topic, could you look into enabling clang
> thread safety check?
>
> I suppose that FQLOCK and FQUNLOCK always come in pairs (seems a safe
> assumption), so enabling should be something like:

Thanks for the suggestion and code snippet. It looks good.



  reply	other threads:[~2024-11-14  7:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 16:14 Hemant Agrawal
2024-11-13 16:14 ` [PATCH 2/2] examples/l2fwd-event: fix spinlock handling Hemant Agrawal
2024-11-13 16:48 ` [PATCH 1/2] bus/dpaa: fix lock condition during error handling David Marchand
2024-11-14  7:45   ` Hemant Agrawal [this message]
2024-11-14  7:44 ` [PATCH v2 1/3] " Hemant Agrawal
2024-11-14  7:44   ` [PATCH v2 2/3] examples/l2fwd-event: fix spinlock handling Hemant Agrawal
2024-11-14  7:44   ` [PATCH v2 3/3] bus/dpaa: enabling clang thread safety for locks Hemant Agrawal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72de698d-d689-7448-ac16-76ca3762256f@oss.nxp.com \
    --to=hemant.agrawal@oss.nxp.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).