DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 01/13] port: added structures for port stats
Date: Mon, 18 May 2015 12:47:44 +0200	[thread overview]
Message-ID: <7306400.tIjx29JTOm@xps13> (raw)
In-Reply-To: <1430395652-6852-2-git-send-email-michalx.k.jastrzebski@intel.com>

2015-04-30 14:07, Michal Jastrzebski:
> From: Maciej Gajdzica <maciejx.t.gajdzica@intel.com>
[...]
>  struct rte_port_out_ops {
> -	rte_port_out_op_create f_create;   /**< Create */
> -	rte_port_out_op_free f_free;       /**< Free */
> -	rte_port_out_op_tx f_tx;           /**< Packet TX (single packet) */
> -	rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */
> -	rte_port_out_op_flush f_flush;     /**< Flush */
> +	rte_port_out_op_create f_create;		/**< Create */
> +	rte_port_out_op_free f_free;			/**< Free */
> +	rte_port_out_op_tx f_tx;				/**< Packet TX (single packet) */
> +	rte_port_out_op_tx_bulk f_tx_bulk;		/**< Packet TX (packet burst) */
> +	rte_port_out_op_flush f_flush;			/**< Flush */
> +	rte_port_out_op_stats_read f_stats;     /**< Stats */
>  };

Please avoid changing alignment if not really necessary.
Here it seems you want to have some space between "f_stats;" and its comment.
So you should use spaces for alignment of the comments and not hard-tabs,
even less hard-tabs used as 4-char like here.

  reply	other threads:[~2015-05-18 12:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 12:07 [dpdk-dev] [PATCH v2 00/13] port: added port statistics Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 01/13] port: added structures for port stats Michal Jastrzebski
2015-05-18 10:47   ` Thomas Monjalon [this message]
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 02/13] port: added port_ethdev_reader stats Michal Jastrzebski
2015-05-18 10:53   ` Thomas Monjalon
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 03/13] port: added port_ethdev_writer stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 04/13] port: added port_ethdev_writer_nodrop stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 05/13] port: added port_frag stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 06/13] port: added port_ras stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 07/13] port: added port_ring_reader stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 08/13] port: added port_ring_writer stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 09/13] port: added port_ring_writer_nodrop stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 10/13] port: added port_sched_reader stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 11/13] port: added port_sched_writer stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 12/13] port: added port_source stats Michal Jastrzebski
2015-04-30 12:07 ` [dpdk-dev] [PATCH v2 13/13] port: added port_sink stats Michal Jastrzebski
2015-05-05 15:08 ` [dpdk-dev] [PATCH v2 00/13] port: added port statistics Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7306400.tIjx29JTOm@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=maciejx.t.gajdzica@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).