From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 0101BC382 for ; Mon, 18 May 2015 14:29:44 +0200 (CEST) Received: by wizk4 with SMTP id k4so77128598wiz.1 for ; Mon, 18 May 2015 05:29:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=4mr98vvOe0vRRVUEM06/opt5dQdMeuAB3wabyPJWbHw=; b=Jygw5hJKyxz+8TQJp8e4tf/HR3POL4sDZfDkjrT8AA90AWkwbaHLAahANQ+BNS4afR Zum2DXopKgqdk2ZS+4e+L/5FAAR/V4zl0qgXwf0h8n7KOWQVJ3zc6RDSZ0gSOLaV3ZcM GlzPYQO710PzHalR4tz+cjDgqS34nP480jx2wM0JDhNB3ege+tGHo/RiKLq/5IGB0VYu QIpvQmdy6hInm6+/kXmBz7zXXLSVhex5GcjzGHC4k0lLa4kzRYK8vhyQzcPH5W2TbX8m Xn34gFltn1I1ujz+Fqh4TARlNT7RLJmhkDNfhLeee7dn0zE5j9z0RpJ5mdsQ4hmPPRE9 YCaQ== X-Gm-Message-State: ALoCoQkoXpCf09X8ORSzYa6K9T5aQa9uSjpylYK9Vb0F+p8qYaUW7CGeKgUZFIcTPOywVKgsA0qw X-Received: by 10.180.102.74 with SMTP id fm10mr2408521wib.25.1431952183889; Mon, 18 May 2015 05:29:43 -0700 (PDT) Received: from xps13.localnet (60.26.90.92.rev.sfr.net. [92.90.26.60]) by mx.google.com with ESMTPSA id n1sm12271794wix.0.2015.05.18.05.29.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 May 2015 05:29:43 -0700 (PDT) From: Thomas Monjalon To: Maciej Gajdzica Date: Mon, 18 May 2015 12:47:44 +0200 Message-ID: <7306400.tIjx29JTOm@xps13> Organization: 6WIND User-Agent: KMail/4.14.7 (Linux/4.0.1-1-ARCH; KDE/4.14.7; x86_64; ; ) In-Reply-To: <1430395652-6852-2-git-send-email-michalx.k.jastrzebski@intel.com> References: <1430395652-6852-1-git-send-email-michalx.k.jastrzebski@intel.com> <1430395652-6852-2-git-send-email-michalx.k.jastrzebski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 01/13] port: added structures for port stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 May 2015 12:29:44 -0000 2015-04-30 14:07, Michal Jastrzebski: > From: Maciej Gajdzica [...] > struct rte_port_out_ops { > - rte_port_out_op_create f_create; /**< Create */ > - rte_port_out_op_free f_free; /**< Free */ > - rte_port_out_op_tx f_tx; /**< Packet TX (single packet) */ > - rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */ > - rte_port_out_op_flush f_flush; /**< Flush */ > + rte_port_out_op_create f_create; /**< Create */ > + rte_port_out_op_free f_free; /**< Free */ > + rte_port_out_op_tx f_tx; /**< Packet TX (single packet) */ > + rte_port_out_op_tx_bulk f_tx_bulk; /**< Packet TX (packet burst) */ > + rte_port_out_op_flush f_flush; /**< Flush */ > + rte_port_out_op_stats_read f_stats; /**< Stats */ > }; Please avoid changing alignment if not really necessary. Here it seems you want to have some space between "f_stats;" and its comment. So you should use spaces for alignment of the comments and not hard-tabs, even less hard-tabs used as 4-char like here.