From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m15-34.126.com (m15-34.126.com [220.181.15.34]) by dpdk.org (Postfix) with ESMTP id 171C837B4 for ; Mon, 19 Sep 2016 20:36:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Date:From:Subject:MIME-Version:Message-ID; bh=3lE8Y pbFe8ZiJf7FcBVOqFC49psFWrh8FUI1bDcpHOY=; b=UPxrvUQ5nuAwHORLqJEO3 M/IyzIqLj4rcVpeTpUaG5MWMZf8ULwxXVcvd8ncN5PLmL274l/+P2/sZEHVoCUZY CYTu6tbnWlM+E+NCpj8NZ8rSvHZ3ugcNijZ13SMTsQwA11FdYsz3la+uVBqs1zZm 6MbbgJFzyxPO8iJYWQqtiY= Received: from zhangwqh$126.com ( [161.253.121.223, 54.215.2.217, 10.144.1.72] ) by ajax-webmail-wmsvr34 (Coremail) ; Tue, 20 Sep 2016 02:36:36 +0800 (CST) X-Originating-IP: [161.253.121.223, 54.215.2.217, 10.144.1.72] Date: Tue, 20 Sep 2016 02:36:36 +0800 (CST) From: =?GBK?B?1cXOsA==?= To: dev@dpdk.org Cc: "Zhu, Heqing" , Dmitrii.Kuvaiskii@tu-dresden.de, oleksii.oleksenko@tu-dresden.de, enkovich.gnu@gmail.com X-Priority: 3 X-Mailer: Coremail Webmail Server Version SP_ntes V3.5 build 20160420(83524.8626) Copyright (c) 2002-2016 www.mailtech.cn 126com X-CM-CTRLDATA: kz3GvGZvb3Rlcl9odG09MTczOTo1Ng== MIME-Version: 1.0 Message-ID: <7316bd44.1db.15743bc4bf3.Coremail.zhangwqh@126.com> X-Coremail-Locale: zh_CN X-CM-TRANSID: IsqowEBJX0I1MOBXzTcxAA--.31171W X-CM-SenderInfo: x2kd0wxztkqiyswou0bp/1tbiVxzp6VPh+WdrHgABsT X-Coremail-Antispam: 1U5529EdanIXcx71UUUUU7vcSsGvfC2KfnxnUU== Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: base64 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] rte_eth_rx_burst reports bug by safecode (one memory protection tool) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 18:36:45 -0000 SGkgYWxsLCAKCgpJIGFtIHVzaW5nIGEgbWVtb3J5IHNhZmUgdG9vbCBzYWZlY29kZSAgIGh0dHA6 Ly9zYWZlY29kZS5jcy5pbGxpbm9pcy5lZHUvICAgIGNvbXBpbGluZyBkcGRrIGFwcGxpY2F0aW9u LiBJZiBJIGRvIG5vdCBkbyB0aGUgbWVtb3J5IHNhZmV0eSBjaGVja2luZywgaXQgd29ya3MgY29y cmVjdGx5LiAgQnV0IG15IG1haW4gYWltIGlzIHRvIGV2YWx1YXRlIGlmIHVzaW5nIHNhZmVjb2Rl IHByb3RlY3RzIHRoZSBtZW1vcnksIHdoYXQncyB0aGUgb3ZlcmhlYWQ/IAoKVGhlIHJlbGF0ZWQg Y29tcGlsaW5nIG9wdGlvbiBpcyAKCkNGTEFHUyArPSAtTzMgLWZtZW1zYWZldHkKCkNDPWNsYW5n CgpJZiBJIGVuYWJsZWQgLU8zICAtZm1lbXNhZmV0eSwgZHBkayBsaWIgaW50ZXJmYWNlIHJ0ZV9l dGhfcnhfYnVyc3QgdHJpZ2dlciB0aGUgZm9sbG93aW5nIGJ1ZzogIAoKaHR0cHM6Ly9naXN0Lmdp dGh1Yi5jb20vemhhbmd3ZWkxOTg0L2VlOGRkZjY4NjhkNmJlOWI2YmM2ZjM1YzNjZGViODUwCgpE b2VzIGl0IHJlYWxseSBoYXZlIGJ1Zz8gIEkgZG8gbm90IGhhdmUgZW5vdWdoIGFiaWxpdHkgdG8g ZGV0ZWN0IHdoZXJlIGl0IG1pZ2h0IGJyaW5nIHRoaXMgcHJvYmxlbS4gQ2FuIGFueW9uZSBoZWxw IHRvIHNlZSB0aGlzIHByb2JsZW0gd2hvIGZvY3VzZXMgb24gdGhpcyBhcmVhIGRldmVsb3BtZW50 PyBJIHdpbGwgYmUgdmVyeSBhcHByZWNpYXRlZC4gCgpUaGFua3MsIAoKd2VpCgoKCgoK >From pablo.de.lara.guarch@intel.com Mon Sep 19 20:36:51 2016 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 734E837B4 for ; Mon, 19 Sep 2016 20:36:51 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 19 Sep 2016 11:36:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,363,1470726000"; d="scan'208";a="1033270454" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga001.jf.intel.com with ESMTP; 19 Sep 2016 11:36:51 -0700 Received: from irsmsx108.ger.corp.intel.com ([169.254.11.164]) by IRSMSX109.ger.corp.intel.com ([169.254.13.6]) with mapi id 14.03.0248.002; Mon, 19 Sep 2016 19:36:48 +0100 From: "De Lara Guarch, Pablo" To: Masoud Hasanifard , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] hash: Correctly set the compare function. Thread-Index: AQHSEMgCQVp2syKntkWsTWZdEj2bF6CBJh1A Date: Mon, 19 Sep 2016 18:36:48 +0000 Message-ID: References: <1474105404-27654-1-git-send-email-masoudhasanifard@gmail.com> In-Reply-To: <1474105404-27654-1-git-send-email-masoudhasanifard@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTg5MzI4NjEtMmU2YS00YTQzLTgxNmEtZjUwMDMyMDg0NDllIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZUM1wvdXRwUW1CQmZRWHpPUnBKbVFiM3VneWFwOStJUng2TStPcFgzcllrPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] hash: Correctly set the compare function. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 18:36:51 -0000 Hi, > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Masoud > Hasanifard > Sent: Saturday, September 17, 2016 2:43 AM > To: dev@dpdk.org > Cc: Masoud Hasanifard > Subject: [dpdk-dev] [PATCH] hash: Correctly set the compare function. Commit titles start with lowercase ("correctly") and without a dot at the e= nd. >=20 > Set cmp_jump_table_idx to KEY_CUSTOM in rte_hash_cmp_eq so that the > custom > function we are setting in rte_hash_set_cmp_func properly works. The > custom > function is only called by rte_hash_cmp_eq if cmp_jump_table_idx is set t= o > KEY_CUSTOM. I think this is a fix, so probably it should contain the following "Fixes" = line in the commit message: Fixes: 95da2f8e9c61 ("hash: customize compare function") > --- > lib/librte_hash/rte_cuckoo_hash.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/lib/librte_hash/rte_cuckoo_hash.c > b/lib/librte_hash/rte_cuckoo_hash.c > index 26e54f6..2e6429f 100644 > --- a/lib/librte_hash/rte_cuckoo_hash.c > +++ b/lib/librte_hash/rte_cuckoo_hash.c > @@ -98,6 +98,7 @@ rte_hash_find_existing(const char *name) >=20 > void rte_hash_set_cmp_func(struct rte_hash *h, rte_hash_cmp_eq_t > func) > { > + h->cmp_jump_table_idx =3D KEY_CUSTOM; > h->rte_hash_custom_cmp_eq =3D func; > } >=20 > -- > 2.7.4 Good catch! Two comments inline. Could you send a v2 with those two things added? Thanks for the patch, Pablo