From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D582A00C2; Sat, 25 Apr 2020 22:12:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E2D11C0B9; Sat, 25 Apr 2020 22:12:32 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id BE49F1DBF for ; Sat, 25 Apr 2020 22:12:30 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 502895C01C7; Sat, 25 Apr 2020 16:12:30 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 25 Apr 2020 16:12:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= P/g3fmh45F+e5aG5/Rnx4eGffKlyQgR4qPEzc6Mc8a0=; b=ni5tQ2wJLJK5649s 2xHO9tXRS1DUQCon4l7K6M1D90Byhd71tw1lfktpE5pmZnCGTnpQZIwVD8Fc9Its xr0iioInlypFvl7hInqA54/RGEu0a7aDqwgGATBPzKl6/RwqCb2pe+4O8IHUwqs/ lWc+u6mdKTVxljE2qPemxDZS9grUHwr+Op7MGcJZljRi1NgQUElAec+06IZWytuu ddsyzUJxSyzPrisCrXXmA8dDMdHiJfWPSN4vH9S7A/xbB0FBTqTlYyF05GQKwjxt XJnwl8ezZQUxXXiYZVOMqrS5mRKJKjjR5JH6SlHvcT6laxSMZVm19Xdob68GCGpP IkxPVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=P/g3fmh45F+e5aG5/Rnx4eGffKlyQgR4qPEzc6Mc8 a0=; b=iOwy/xhui95034ucxzqV4AcxoQtfK3fE+qG6tL61Ca/7Zw4bv6+oWmpuJ usivzrlBjNK3YUY8KEqfa/0lgbQhbMCIOx6RI7yZPz+J7ObOmqa4xDswb/+qMUxG vvezBaCnWHWkpw1yub3rvQJOsoRIxIaP9siCQwEkQC2nLjUmm9d135eYcwawbAqQ 6o76kGJM2ff8W3m44XmJurVVcXPafMYD34YKZRert7o4h4Q8Hvquhq7MDZ3dVUrE dkw67mHkVbZULOnVSoA6KLWQO4sH1x5z+JmM2mQVG1qzyi5JfX7ev4WOd+ec9zKW GYTcs2EG4QANVNlvWhe64zpzeWOJA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrheeggdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6C1313065E05; Sat, 25 Apr 2020 16:12:29 -0400 (EDT) From: Thomas Monjalon To: Jerin Jacob Cc: dev@dpdk.org, dpdk-dev , Olivier Matz , Jerin Jacob Date: Sat, 25 Apr 2020 22:12:28 +0200 Message-ID: <7318372.iedYuu7f5S@thomas> In-Reply-To: References: <20200121080021.2835490-1-jerinj@marvell.com> <5378505.1B3tZ46Xf9@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] bus/pci: set boot-up log prints to absolute minimum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 06/02/2020 15:36, Jerin Jacob: > On Thu, Feb 6, 2020 at 7:44 PM Thomas Monjalon wrote: > > 21/01/2020 09:00, jerinj@marvell.com: > > > From: Jerin Jacob > > > > > > Some machines may have a lot of PCI devices, logs from PCI probe > > > creates a lot of clutter on boot-up, typically one needs > > > to scroll the screen to find other issues in boot-up. > > > > > > This patch changes the loglevel of PCI probes to `debug` > > > to reduce the clutter on default boot-up logs > > > > I think the PCI probe informations are... informational. > > Maybe you are just not interested in info logs. > > If this is the case, I suggest to change the log level at runtime. > > I am wondering, what would be the right balance, Following is DPDK > startup output from octeontx2[1] > It creates a lot of clutter in the "default" boot up. Why not enable > below prints using log level at runtime? > I believe it comes as a debug category, i.e information required to > debug if something is not working, > dpdk bind script already lists what is bound to DPDK. > > Suggestion to remove clutter? I suggest using dynamic log level in the PCI driver. Unfortunately a lot of old DPDK code is still using the old log macros. Some cleanup work is needed here.