From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20045.outbound.protection.outlook.com [40.107.2.45]) by dpdk.org (Postfix) with ESMTP id 94E8A7CE2 for ; Mon, 17 Sep 2018 14:33:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snbHxKyGVyv6hi9MABEv0YCJ1rm+OcevjziFwqM03/8=; b=IT+YZEzHzi5BFyJDl2r61xW8hNByhmU2ksDJBXE2U2pagAlmnXzstcoBrhz5wspPrhIiEqBw+BSgWCN0tv1lZ8j+MpRynp4EiiUlnQxbWvo1AloS44llIMvxLHBxqFYmjFssKXbF1leFO1yRZELz94iKdDcJnKko/8PK9sV2j6I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.143.30.134) by DB7PR04MB4891.eurprd04.prod.outlook.com (2603:10a6:10:18::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1143.18; Mon, 17 Sep 2018 12:32:58 +0000 To: Thomas Monjalon , Anoob Joseph Cc: Pablo de Lara , Anoob Joseph , Jerin Jacob , Narayana Prasad , dev@dpdk.org, Ankur Dwivedi , Murthy NSSR , Nithin Dabilpuram , Ragothaman Jayaraman , Srisivasubramanian S , Tejasree Kondoj , ferruh.yigit@intel.com, john.mcnamara@intel.com References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1536033560-21541-6-git-send-email-ajoseph@caviumnetworks.com> <1686325.VlSG2WtMdx@xps> From: Akhil Goyal Message-ID: <7325a516-0f5b-1993-efd9-1a203346b137@nxp.com> Date: Mon, 17 Sep 2018 18:02:45 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1686325.VlSG2WtMdx@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [14.143.30.134] X-ClientProxiedBy: BM1PR01CA0075.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1::15) To DB7PR04MB4891.eurprd04.prod.outlook.com (2603:10a6:10:18::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1bf6171f-3502-4bfb-253f-08d61c99b52b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989137)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB7PR04MB4891; X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4891; 3:1aIv+0FTTFKOMWEKUg+uZfClHVewP/KEQtMuBx8KEAhcY40fi13TRPqnKN6PwQbuRt8VFicnv74lQ+cnQ7hm8SgSJxSN+06VHpmaS4lDimwRtios2BMa1APl5COiCM0BDaxBCiQwjqfNf1OsVZosx8LgZ5KEJs0Ivgs9A34hlfQk7YMdVt0gH/1kfUIURL1kITDrbZlALXhXtUVJxHN+yUuXawX//It+1BTwhPR0oxykeszSt5ARP427Z5lEaLHd; 25:6eNG4ajqSKshiN8Cyok4X8B5ut8r/Pvvq2T28sUuibAQ7zv5cDaYXGhabZOvfI6rsBvW8t8l6D9mFhKUI/cJvyhzr9jRkztSSU9lZazjS1/h1q8NA/i9fTuyArftVstMu0QuQs2xyy2gMaCNWnDie6bFVSHj4AM9AySFYU7sE0lgHx9tJ9ohtV4gyxFK/KFEB8K0ElqRmA+2Ggs8YTihb5rpm6V85fmuUlyXTpG9Zl0be36vY9i5Bssf8Jxg8jJD6qhEYO1wh7thqfoTglpQA7mpluaCKb2s6gDui2ZymLqB2Y8hdyMHVPBMEQ6hAiCN0T2VJ2QcoAM1eagEY7tsfA==; 31:xDlxTM0H7MV3HbyICKqksOq6tJgnJVOWm18jQo7SBaMspE2qE005HtVAGibu7s8uimWwjMPmJmj+pMEG+bp6KHroFpIQDblFL0lrYZfxpM537Vy81YvUoIfD3HsDj4E+FZ417ncx4DD9ckr2Ch0ZMmWTW07LnTTCL+akIAslfJsmVhCYkuVPizBD3bi9oMLodDw0LMDTPayDvHXy6EwWcyDgOh7StlP9/jxEE1ZjhVI= X-MS-TrafficTypeDiagnostic: DB7PR04MB4891: X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4891; 20:FqKX8N1DzXCP7XVxyVGmL5wXM2UjxsvFs2dy9v1wa2otw0zGg6DPI3RwiDbhnWYuM93pi4z4accpot/3K0HxUM9Ky6p47IRZEDDTZog4zuuvHRZ3cZ4Zx0RDdFcVpiXMRAxvx0JOpolbV1rh68IqnPTi9rdBtYcCpdvwWAzN3aiedTkLDWNgwMfGpH+uJht2XXpFJrxYAWDBU+hkl+8+aCfhMER0X96P+VtU1G98FsTOb0x5SfO12sojUXUCyGGxTztadNq2mmU2IgT8JrtRfzPpYgOSPLLj/tzQP3Nt286gT76lQMnbPHaKAsMgAqO2sjWLvYQLVBk/WwKSg0c/+ExIKIynR0klhl97lrtG9Ked4ttCDyJXKOfDxGn7EhocAyTNqo8k799vFQWGvovVmj7nUPvnYrk/jhL+ZQDNJzBx/mtAuDbGcNxrMgEUKoF/+FP2fYj4AdC5YU7TNoJAqO6X9CkBrV8MGQA81oRk998z+Tzzd9s0krprnfX6/8h4; 4:m69DeCwNE0NHE+cg62Q1RYVQbCEri/H7BYF7G1YflJ+EWS7jEWC/tp+1BvBXYVk0lIO9egKyJDRgnl9BSkH6i+8OTKd6DEH7h1Vc/eOGiOLkvCh9uo2Z1EbGvtFt8z8a5RR0taJ6z7cKj490rTfasMgCUX6bkgL+supKWHqQtZZEzzFnBYKu907F0l9E6qUfDv+O8j+F0oUELnG+ZeVgSJ9nIu/3JuyNk3vEAAGF64QHy/riVotbH+tHlo0kdZVAonBlCDEet9sFwHqJRnuINg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(3231355)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123558120)(20161123564045)(201708071742011)(7699050); SRVR:DB7PR04MB4891; BCL:0; PCL:0; RULEID:; SRVR:DB7PR04MB4891; X-Forefront-PRVS: 0798146F16 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(136003)(366004)(376002)(39860400002)(346002)(199004)(189003)(54906003)(97736004)(229853002)(305945005)(16576012)(52146003)(23676004)(58126008)(2486003)(52116002)(230700001)(68736007)(47776003)(65806001)(65956001)(66066001)(105586002)(31686004)(50466002)(53936002)(110136005)(6116002)(3846002)(36756003)(6246003)(6486002)(5009440100003)(106356001)(7736002)(7416002)(316002)(386003)(76176011)(53546011)(67846002)(64126003)(956004)(2616005)(476003)(446003)(11346002)(478600001)(486006)(55236004)(3260700006)(25786009)(31696002)(8936002)(26005)(6666003)(2906002)(14444005)(93886005)(5660300001)(8676002)(186003)(77096007)(16526019)(81166006)(86362001)(81156014)(44832011)(4326008)(65826007)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR04MB4891; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjdQUjA0TUI0ODkxOzIzOkZkbnV0Qnl6ZXh2WWNsSzVTd3VYZys0d00y?= =?utf-8?B?ekNCTnFnM1BPSUFFL1VnWVVTMzhYR2wyT3pLSThncUdraWpQMTVLZ2FsYXYx?= =?utf-8?B?dTNSNU9tdmxHWUdjdTREWUJBZWhLZ1FpZ09HWkg3b2xGVjlweVNzN1ZsOGtq?= =?utf-8?B?bUdRZ0FuWXdES1Q1d2QxSE5kbW0zc3pnV1VaRG9ERGY1YVBweTRVaitVNkQ5?= =?utf-8?B?VFAvbmROMEEzQ1NDMWhvQkpBVXh0RFcvTFNneUxPdjlTb1FCNUlodzJGSVIw?= =?utf-8?B?WW5nMWxoOWl2YngvcjZjM0hTZTVIUG1rWkw5Y1FnaFV6ZDZQeXlJUjFyVFNp?= =?utf-8?B?eDNZTkpWd2Ixclppdk5xMWJ2WXlTb3d1ZnZ2cy82TUtxb0ljY3MySkVieDBI?= =?utf-8?B?RTFtMTd2dVNFY1c4YTA3eXdMMEJJOEg3aVFrREI0ZzcvYUtWUklCdy8yL29z?= =?utf-8?B?NTFzdXhkUXVjNUdLYWh0KzZRZ3J0a3NHRDIvM0Yyb2pRblNIZFlqTGN5WWVG?= =?utf-8?B?S1RNQjdHM043ckdJYW5IOWtWTkhVNk9KTEl2c21sdjFIUXAxWXp6YnlOREwv?= =?utf-8?B?V0JiR2Z4Nmx3ZlhjWGYrZmtFRlFCcHduTFM0dXZFdC81V1ZPSk9JMWk0SnRi?= =?utf-8?B?b2F4OTBjSWs3VElmZzhlSkJ1SU5raER5MUJqSFVncGpjc2NYci9vZlQ4V0tw?= =?utf-8?B?R0NSZzAyUFQ2d3RaUTVqQWdqR3RuVzBldHZCWktqYjdtcy9KZjBzdWdXUEZR?= =?utf-8?B?UmtoNnU1dDk3Q04yQTdVRyt6MVZwYTh1T3ZnNnhma0d1U2pVN1loRzZpcTNY?= =?utf-8?B?RzF4OWVoR3VoRGJSSXVKM3lqWTUydkpRY1hKR3BTRUs5SHlYelNEc1I4M2I0?= =?utf-8?B?UUFzNUNzQzV1aXdjS2x4bzJSVlprUHhhN2hRSU5NMjN1M1NEY202SHRrdWtN?= =?utf-8?B?SzI3anNMajZYWWk3Y2JPVVVINi9JdjlwbU15Wkw4Qm1XMHpIVFpPZTd4THBI?= =?utf-8?B?bSsvNHBIa0UyVURXVWZGQk56ZEh2aDU3bzREaFA3SUh0dXVLZ0V4VVVabGRF?= =?utf-8?B?K2hVVFhwQ3Rpczloc1N1NGM3ZHpDTUdGMFJUc1VqZ1p4TzhkNXVYZjFrd1Ru?= =?utf-8?B?VjJNNGVFRTJEWEk2ZkVtYUFMRFk3aDB2bEpMUnNPY3RSdXJxdnVOY0IwTzk1?= =?utf-8?B?cVptZElHMXRVTENpWVFnajdGcC9HRjF2Ykx6YkxjOXp6VWZRMncvbmpUMkow?= =?utf-8?B?UlNwM2Y2ank3WlN6NU1Na0x0bGIvYWthN2JBTi80aGkrOEpTMWpGVDA2Vzh0?= =?utf-8?B?MGFkdDNhU3dXNkhpcG9Zd3pTcmRGaWxDa0RPZEVEZndXYkk5UFg4bjZKdUlC?= =?utf-8?B?K2xpc1pHRlk5ZjNrT281RWNQV2tXWDhiUTJVcFo3cWZCZGt0ZzBZa2kyeHNS?= =?utf-8?B?bFNhL2xJcW9JZ2pRVmNOYk5LY2M0ZktpSXljeEJ1QTJPTTVERllEU0JYNmdT?= =?utf-8?B?T0p6QS9xc0xzWkJnNkVyLy9peG1hcFpvRGZWL3E0cTg5TE4xZmNMVjZzRjBr?= =?utf-8?B?eEo3M1E0MXpZdEE3NFA0dGh3U2VLTy9yb1Y1c21uMXIya2NzTS9wRkxtTk1t?= =?utf-8?B?aWpEN0p5OUNMaU9yTmxmUm45aEw4RXJ2TnozdlYra0tDdHVXOXg1K1hYVlBp?= =?utf-8?B?RzVKalc4K3V5b0NhSFdxOWl0MmN1OUVXL0E1Q3FYNEY3cU5TWDNtTEk3aUVk?= =?utf-8?B?NkQwNGJSOWR5QmliR1BtdUR4UW9lN253RjArcVQvdG5YcnIrdWZGNVZkZC93?= =?utf-8?B?MGgyMUJKQlc2T3QrSGRPSzlFSG8zUkM0QnVBbHVUc2E3bG50OStVVUhzL2xq?= =?utf-8?B?bXdEZm1yNGt5ZmlCU1lDNzN0bUROUXJNUGk5d2ZScXRXMEliTGlHWHZWTjJt?= =?utf-8?B?VnZZZ29DNlRRV3ZFRzlmM01Bc0dWUDlHdHVlTEFCay9JZ0F5SmJpbVJJcnJS?= =?utf-8?B?a1c3eVNUTHNERCtSWWpScUpiVDBsZk5QUFgveUVsanZVZ0JORTUxRXNyM1hP?= =?utf-8?B?c2RRK2RKY21EUEFLSENlZnVzNTk1RHIzMTAxNm5GVVRqMkIwWjNqNFE1Lzh1?= =?utf-8?B?RWZjdWJnNnhseHA3YjBRT1hUakRKMTZUclNwZUdUaHp3bGUyek91MFZjNDJM?= =?utf-8?Q?E1lUXvkAlUo9E7hZHTVb657xHC4VCVJVlEDTGkWFDU=3D?= X-Microsoft-Antispam-Message-Info: LyCVqdUQqZ3tC6kMfYD/TKuHZkdVkXTaxjUV11MXY3/gkr9Ut577b98Uf9H6uZ/6AXH4z5tu+IfYeaEXmJlg5/Z4KY3x+trOrP9Nrcgn2xBvoy4shOb2k2VjL+sfl80qfeoLWFQGkaPofOMjjnekNsYYLdpCjwV7DAO2MaRLjCP9DoF6syyPVj6DC0CsWmOLEUPDvenLPYRYssY527FNYFZtWm8mCRpH6EzS6p+sM+UTDjjEHqx+7ujThfZN4hmKhqptVL95nj3BWtNSUOKcby1oDnpduN2hSV/lxSxe7ExTjPAG9kWZ5896MqZvDgLzJB1NCsfcWWVoSQpLFTl4cxhYsSwD9PFV21Au0tF5+yI= X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4891; 6:F/zk0z62kENwSZNKTh+KB+AoqVLtStaY1pdbiGGK3ePU3LnEheM917lp2KgciODFKma+QDYHELPT/KnLXTebdXCgR7nIEAEcXEDXqJvJGwsqES1w6X2RED4qiXZY/VnxjHYnsxYCHFXF1GzjBtRoKsFEDMGZdtIi1BVZfmZC40toZxYbq64RGQmlYfgUnitAllqmlYQD6HRjU5rjZQqRZS1ZJ/aTnXonLOpYxopWzq94s+NqSzJZleUQJFqqTHK07wxSxxBp37dT7D2wXoetN2oPh+OcqVwxftBbtV3r5qe7vzXZLh94IeQXmMSSw7Xw915NQ/iQPG/IMklXh+M/tPXJlngG82AGa/snntu2nUD6ikxasuTRJi7AqPr44rG7S4QNv05XsCiGQ/l4VBl3d72+hTRMQBFgFznQfQy7YPkm1AXRpykQxyUsKUMbc7x8g9v0ncxCZKhtIWZhJjyDbQ==; 5:P0BFfE8zEu+JKyZIsWShCcnsOhFWLn4DWAc8zYprTN9vnsirhb41jFO2ZIOmvnmlAMHkzcvTQfsYLXT4M+SCWCH4HmD7GDtDkpQdohY8kLK32vIeD9KGljaFf6MeGkHF93Gh/Livw4jQ81ORTnpD+jBSDrhdKJbywbQMnsxun84=; 7:3Lmpz6xqKtq950D0BpuRj0mPwowTEkWH3JgyZj6SyXQJGQoFBJgjcQCqcEEpwoq0ShrGVwEVLQfD/JSNpKyzfT0BIHIZCREy6QAW//HhFkd58nPUpz9g3TF9XP7uTGgBK+AMKAc8D8ARj1JSYjB93oMeNsCSP1qpm+f4qCgJPXaLKFlCdypxuWsrODbXLwKFwnLPZtqisgAYANHMQnem4ylXnWfTZ2vy2KvkJdD2w8PUiyMHou0c/PU3KfmnagE6 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2018 12:32:58.8643 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1bf6171f-3502-4bfb-253f-08d61c99b52b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4891 Subject: Re: [dpdk-dev] [PATCH v2 05/33] common/cpt: add common code for init routine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2018 12:33:02 -0000 Hi Thomas, On 9/17/2018 5:16 PM, Thomas Monjalon wrote: > 17/09/2018 12:45, Akhil Goyal: >> On 9/4/2018 9:28 AM, Anoob Joseph wrote: >>> +struct pending_queue { >>> + uint16_t enq_tail; >>> + uint16_t deq_head; >>> + uint16_t soft_qlen; >>> + /**< Software expected queue length */ >>> + uint16_t p_doorbell; >>> + struct rid *rid_queue; >>> + /**< Array of pending requests */ >>> + uint64_t pending_count; >>> + /**< Pending requests count */ >>> +}; >> better to add comment for each element of structure. >> Also remove extra tab for comments(here and any other place if any.) > I don't understand this trend in the community about doing comments > _after_ the item _and_ not on the same line. > The default style should be commenting _before_. > And if you feel it is better to have the comment on the same line, > then you can comment _after_, but on the same line. > I think this should not matter, whether the comment should be before or after, it should be consistent across the code. I can see that both are being used equally. Shall we change the complete code beyond this driver as well? I think whatever we choose, it should be atleast consistent within the file. -Akhil >