From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Dan Gora <dg@adax.com>
Subject: Re: [dpdk-dev] [PATCH] kni: return failure for all ioctls
Date: Tue, 02 Oct 2018 17:55:21 +0200 [thread overview]
Message-ID: <73277529.Xa667ZQCeR@xps> (raw)
In-Reply-To: <ae736e9c-7778-2ea6-8ee2-a000e3f8afd9@intel.com>
18/09/2018 18:19, Ferruh Yigit:
> On 9/13/2018 10:46 PM, Dan Gora wrote:
> > Modify kni_net_ioctl() to return -EOPNOTSUPP for all ioctls instead
> > of 0.
> >
> > This is necessary because the Wicked (and possibly other) network
> > interface managers will perform the SIOCGIWNAME ioctl to check if
> > the interface is a wireless interface. If the KNI module returns
> > success, Wicked will incorrectly interpret the interface as a wireless
> > interface.
> >
> > Signed-off-by: Dan Gora <dg@adax.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-10-02 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 21:46 Dan Gora
2018-09-18 16:19 ` Ferruh Yigit
2018-10-02 15:55 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73277529.Xa667ZQCeR@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dg@adax.com \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).