From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 5CCD57F9C for <dev@dpdk.org>; Mon, 27 Oct 2014 16:14:13 +0100 (CET) Received: by mail-wi0-f179.google.com with SMTP id h11so4749159wiw.12 for <dev@dpdk.org>; Mon, 27 Oct 2014 08:22:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=2TNfGrdwA4N/6SBOCq1le/ch14Vy3wodqWZlihBLV6o=; b=kwCWLe/6hut5m8iSQuY9J6GlmFdze1fIa8KFi5yVkdpp6nCm1BOubpf5NU2w6Zl1WA Z2oBPUclV72WDUV5ULlW/dYgr650gEjM+m64xMFNxj6dzncwrsl4dR7YMNRpiBTkF0Ri ntdCoWXew2wLqpDM+7OFUrAG9IdWMgPRQVlyoPAgS+SkFgY/GGJ96lZZnp6OB9pR/qo7 F0cQ7zaHEeWkEYwjMsi3cCoUljn4NMrA60kqusjahm87IgmIVEe9nOBCFaJR9Mpff8aA JT3rWbnKLAzwUzJ6zIZ6y+iPWY4lxxjywWA4NVosLZUMCekUp28lcEMovIrk/PlZO/zr FcUg== X-Gm-Message-State: ALoCoQkaohukRPyyUCiPMBLi6Gmw7AOZFi2RhTuQBJpSXqmdxQbxk0TS0NduI+gR79oi5T6670ao X-Received: by 10.180.218.136 with SMTP id pg8mr20969495wic.37.1414423376495; Mon, 27 Oct 2014 08:22:56 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id pn4sm15931988wjc.38.2014.10.27.08.22.55 for <multiple recipients> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Oct 2014 08:22:55 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Jingjing Wu <jingjing.wu@intel.com> Date: Mon, 27 Oct 2014 16:22:38 +0100 Message-ID: <7329264.iY5QxnAQDU@xps13> Organization: 6WIND User-Agent: KMail/4.14.2 (Linux/3.17.1-1-ARCH; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1413939687-11177-1-git-send-email-jingjing.wu@intel.com> References: <1411711418-12881-1-git-send-email-jingjing.wu@intel.com> <1413939687-11177-1-git-send-email-jingjing.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v4 00/21] Support flow director programming on Fortville X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 27 Oct 2014 15:14:13 -0000 2014-10-22 09:01, Jingjing Wu: > The patch set supports flow director on fortville. > It includes: > - set up/tear down fortville resources to support flow director, such as queue and vsi. > - support operation to add or delete 8 flow types of the flow director filters, they are ipv4, tcpv4, udpv4, sctpv4, ipv6, tcpv6, udpv6, sctpv6. > - support flushing flow director table (all filters). > - support operation to get flow director information. > - match status statistics, FD_ID report. > - support operation to configure flexible payload and its mask > - support flexible payload involved in comparison and flex bytes report. > > v2 changes: > - create real fdir vsi and assign queue 0 pair to it. > - check filter status report on the rx queue 0 > > v3 changes: > - redefine filter APIs to support multi-kind filters > - support sctpv4 and sctpv6 type flows > - support flexible payload involved in comparison > > v4 changes: > - strip the filter APIs definitions from this patch set > - extend mbuf field to support flex bytes report > - fix typos Previous version was acked by Chen Jing D(Mark) and Helin Zhang. Have they reviewed the v4? I won't review neither i40e nor testpmd parts in detail. I prefer focusing on API (mbuf and ethdev) for my review. -- Thomas