From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id B7C855A5C
 for <dev@dpdk.org>; Wed,  5 Aug 2015 11:29:56 +0200 (CEST)
Received: by wicgj17 with SMTP id gj17so184209655wic.1
 for <dev@dpdk.org>; Wed, 05 Aug 2015 02:29:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=+F//MSPowSW0+1wjNlLYgz3o+0fK66z+rx5aKCbqJ04=;
 b=Ow5of2xr7+mll99/R+KK+10ZAxi917sAz4wGoSsxb1vs2LCXd25gliN449P11UTDp+
 E5TFUK3kKyXrH8wVA8azccewZ88ZkgAlZSiTPzgLQ2mfSxqbVmI4Y00/HZjx97AIaYGK
 r9/dotilt8WBsa/ZlX7DoB8x3xxJL3V0nl4VkLIp63vGgHq0HyRvhv7x6T+q0AXU8s0A
 5QQQrZXYTKSqqOJkzbEJHaVPG+xavYXqrPMZ5zzGMgaYa2uEFLcB2Y6MyCsGQKyZmvSV
 wLEn95AKtL4y2mwOaZ6y6TC1JqdCNiJFxmQ+0XgyTsMx9IcgaDYyGUOi+b16guaDi8OO
 vRLg==
X-Gm-Message-State: ALoCoQljfghUmxEX7MTkVfHlmWbaOOPlWCMBPPI6fhjrJwQ5iJmESwXJpWnnVhqVe2hgrFaqeiLA
X-Received: by 10.180.211.196 with SMTP id ne4mr8412691wic.23.1438766996434;
 Wed, 05 Aug 2015 02:29:56 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id v9sm3138410wjq.41.2015.08.05.02.29.55
 (version=TLSv1/SSLv3 cipher=OTHER);
 Wed, 05 Aug 2015 02:29:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>
Date: Wed, 05 Aug 2015 11:28:40 +0200
Message-ID: <7330921.0l7ts1gtOu@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1438765813-10932-1-git-send-email-michalx.k.jastrzebski@intel.com>
References: <1438765813-10932-1-git-send-email-michalx.k.jastrzebski@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test: fix test_tlb_tx_burst
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2015 09:29:57 -0000

2015-08-05 11:10, Michal Jastrzebski:
> This patch fixes error in tlb_tx_burst function:
> Distribution is not even.

What was the error exactly?

> A condition in TEST_ASSERT macro was changed,
> as the previous one was random.

I think "random" can be better described.

> Also the time of generating packets can now be decreased.

>  	/* Generate 400000 test bursts in 2s of packets to transmit  */
> -	for (i = 0; i < 400000; i++) {
> +	for (i = 0; i < 10000; i++) {

It is a good example of an useless comment which becomes easily out-of-date.