From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 9AAA399B0
 for <dev@dpdk.org>; Mon, 31 Jul 2017 13:19:39 +0200 (CEST)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by fmsmga105.fm.intel.com with ESMTP; 31 Jul 2017 04:19:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,442,1496127600"; d="scan'208";a="131484236"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48])
 ([10.237.220.48])
 by orsmga005.jf.intel.com with ESMTP; 31 Jul 2017 04:19:37 -0700
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
References: <20170725033224.90613-1-ajit.khaparde@broadcom.com>
 <20170725033224.90613-3-ajit.khaparde@broadcom.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <734423cc-14d4-db38-b818-a021aeccb82c@intel.com>
Date: Mon, 31 Jul 2017 12:19:37 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170725033224.90613-3-ajit.khaparde@broadcom.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix arguments to
 _rte_eth_dev_callback_process
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2017 11:19:40 -0000

On 7/25/2017 4:32 AM, Ajit Khaparde wrote:
> The callback arguments to _rte_eth_dev_callback_process() are swapped.
> Fix them.
> 
> Fixes: d6af1a13d7a1 ("ethdev: add return values to callback process API")
> 
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  drivers/net/bnxt/rte_pmd_bnxt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/bnxt/rte_pmd_bnxt.c b/drivers/net/bnxt/rte_pmd_bnxt.c
> index dd7e5b8..0463373 100644
> --- a/drivers/net/bnxt/rte_pmd_bnxt.c
> +++ b/drivers/net/bnxt/rte_pmd_bnxt.c
> @@ -57,7 +57,7 @@ int bnxt_rcv_msg_from_vf(struct bnxt *bp, uint16_t vf_id, void *msg)
>  	cb_param.msg = msg;
>  
>  	_rte_eth_dev_callback_process(bp->eth_dev, RTE_ETH_EVENT_VF_MBOX,
> -			&cb_param, NULL);
> +				      NULL, &cb_param);

Hi Ajit,


Since you are using "cb_param.retval", change looks good.

But it is easy to confuse between cb_param and ret_param. To clarify
your intention, I suggest renaming "cb_param" to "ret_param", does it
make sense?

Thanks,
ferruh

>  
>  	/* Default to approve */
>  	if (cb_param.retval == RTE_PMD_BNXT_MB_EVENT_PROCEED)
>