From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 3D5AC1F5 for ; Thu, 18 Dec 2014 00:47:48 +0100 (CET) Received: by mail-wg0-f52.google.com with SMTP id x12so125294wgg.39 for ; Wed, 17 Dec 2014 15:47:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=A4n66WBMzBcJ3CpDU+wJN+mBxbhAgjMyCblOoRE92W0=; b=BaOwHpfjYgYxxAu9PrE94z0LM2/N0hGQu00JgS/uroEKV7Pif+EFpBOMiFIzcbP5Bm f7a1zp773P8GMmlFbzQIYWIxlWlDHqmjiJIDs4KiDdgfAbgTBKR/Qq6C8lNj3Rg+aanh ICgVRRdH6uGO6BBvoiCGdYlHcWHih5r9gHbkUBHKRuAxExnSOUXD46pdOKP/pBb0u6p1 g2ykPJLSpH/d1wcrr+VvsG1wuvwudvl7X3lxfTH8h6R2ZNtSBkH/nYwdUGkbr7m7g+ME UOKoC2NTuy5sh9QV2Ay6aKqwwAvjsLeZrVlQJ56wvJqr+9lm+ugsaX51Fr8BC1tdPz9E wQ/Q== X-Gm-Message-State: ALoCoQmYKxYxq97CCHkgJa467GsfX4Xq7a8kToik040qIHWN4BfuRJa8/2BBOXbBvcIVPX1KWTeB X-Received: by 10.180.97.7 with SMTP id dw7mr15776438wib.6.1418860063116; Wed, 17 Dec 2014 15:47:43 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id p1sm6885007wjy.22.2014.12.17.15.47.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Dec 2014 15:47:42 -0800 (PST) From: Thomas Monjalon To: "Ouyang, Changchun" Date: Thu, 18 Dec 2014 00:47:16 +0100 Message-ID: <7354113.GC7lWJkY43@xps13> Organization: 6WIND User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1589451.jCIKiaz4qv@xps13> References: <1418357726-25141-1-git-send-email-changchun.ouyang@intel.com> <1589451.jCIKiaz4qv@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] examples/vhost: Fix vlan offload issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Dec 2014 23:47:48 -0000 2014-12-17 11:04, Thomas Monjalon: > 2014-12-17 00:51, Ouyang, Changchun: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-12-12 12:15, Ouyang Changchun: > > > > The following commit break vm2vm hard mode test cases: > > > > commit db4014f2b65cb31bf209cadd5bcec778ca137fe2 > > > > Author: Huawei Xie > > > > Date: Thu Nov 13 06:34:07 2014 +0800 > > > > examples/vhost: use factorized default Rx/Tx configuration > > > > > > > > Investigation show that it needs enabling vlan offload since it is > > > > turn off by default, and Tx need it, especially when vm2vm is in hard mode. > > > > > > I missed something here. Where VLAN offload is disabled by default? > > > Could you point the code, please? > > > > Inside the function ixgbe_dev_info_get() > > The txq_flags is assigned value of "ETH_TXQ_FLAGS_MULTISEGS|ETH_TXQ_FLAGS_NOOFFLOADS", > > The ETH_TXQ_FLAGS_NOOFFLOADS contain ETH_TXQ_FLAGS_NOVLANOFFL. > > so VLAN offload is disabled. > > > > Do you think any incorrect in my original description? > > Yes. You say VLAN offload is turned off by default. > But it's the case only for ixgbe, i40e and vmxnet3. Applied with this log change "turn off by default in some drivers" Thanks -- Thomas