From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F25CFA04B1;
	Wed, 23 Sep 2020 18:47:35 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 7FDEC1DA6F;
	Wed, 23 Sep 2020 18:47:23 +0200 (CEST)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id 480A81D8F5
 for <dev@dpdk.org>; Wed, 23 Sep 2020 18:47:14 +0200 (CEST)
IronPort-SDR: AB+S5D6I9+1guYDtEAEWgOZZk7K9QUB9bttr2bW7+nI1Gi1XS3SvxaiyesxcR0k7jVrQUBiYGX
 nAVTg2tokR0Q==
X-IronPort-AV: E=McAfee;i="6000,8403,9753"; a="148689477"
X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="148689477"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 23 Sep 2020 09:44:26 -0700
IronPort-SDR: Ggl2Ychfy7+38uG8VGzXczXmMZYap6n1kyfuzJ3rtvJtlc5xqZYJfv6nYG67F7ib0DnoD/waLJ
 jJhJZdz7elmQ==
X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="305448026"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.147])
 ([10.213.218.147])
 by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 23 Sep 2020 09:44:25 -0700
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: arybchenko@solarflare.com, Tetsuya Mukawa <mtetsuyah@gmail.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>
References: <20200913220711.3768597-1-thomas@monjalon.net>
 <20200913220711.3768597-11-thomas@monjalon.net>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <736c2ece-136d-19d0-e7bf-a23f5382a36f@intel.com>
Date: Wed, 23 Sep 2020 17:44:23 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.2
MIME-Version: 1.0
In-Reply-To: <20200913220711.3768597-11-thomas@monjalon.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 10/20] net/null: release port upon close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/13/2020 11:07 PM, Thomas Monjalon wrote:
> The flag RTE_ETH_DEV_CLOSE_REMOVE is set so all port resources
> can be freed by rte_eth_dev_close().
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>   drivers/net/null/rte_eth_null.c | 24 ++++++++++++++++--------
>   1 file changed, 16 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index 0ce073fa4b..33997013e4 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -458,7 +458,20 @@ eth_mac_address_set(__rte_unused struct rte_eth_dev *dev,
>   	return 0;
>   }
>   
> +static int
> +eth_dev_close(struct rte_eth_dev *dev)
> +{
> +	PMD_LOG(INFO, "Closing null ethdev on NUMA socket %u",
> +			rte_socket_id());
> +
> +	/* mac_addrs must not be freed alone because part of dev_private */
> +	dev->data->mac_addrs = NULL;
> +
> +	return 0;
> +}

should check 'RTE_PROC_PRIMARY' in 'eth_dev_close()'?