From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61119A0A03; Tue, 19 Jan 2021 09:39:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FFDF140D4E; Tue, 19 Jan 2021 09:39:43 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id F1EB8140D46 for ; Tue, 19 Jan 2021 09:39:40 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 6CE3A5C01BC; Tue, 19 Jan 2021 03:39:40 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 19 Jan 2021 03:39:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= 2tf7DQcHG3NVcTI65eP8wWdk/15K1TUjG+b/IZGihWE=; b=d3F6ELDGoHqS+bKR 3mtq0TUEpufybab4mBdX1gJ6Ldw9VcDWPfTB5Y3mssImZaFEbG+QOJz/jj1AQv9t yUnJt++arRxdb/3SwAUyk1vD9a0v0CTUHnerF4VbPH2zvhJRfomFp8G1mBAPe35a HF3iOHDfAYTt/wPwZp9dIJpCMM0QM9dGy7DVgf4jZB7FqWrwdPcWz7Zsyi4t+mGh 9WSsRNMo8MEfY8JMqVjKFDZpDGRdVjyYmnUBVX77ktLktRPW02sHKTtPDyaOr59x u4/RqcOeBLTHrEj9iWO/KxPIFvwaJzmhaaaqnuuHhOuxuoDx38qhlkeArh2cfeYu 7uSuhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=2tf7DQcHG3NVcTI65eP8wWdk/15K1TUjG+b/IZGih WE=; b=ZRJ28QyO0l6Z3Umwss+XTpEgLiO3qRVEjqk287NCuZodCM6EUeLqnpDVN 79mKCRwPpmCoCE4i7MSAbKLJPjZol781kEjE//S7N8KeTdLR3k3pd3WjruJPZuzi s77PxRtuU5BRVAago26/c4MIEB1VugBOpmXP2Qm3pOMN62FOgFrA2ltCO0vc6wP8 L8cMCchLRNNLjCl6ffqSVYGMebOUKceFxj35nJqQhWeTNh8B+dtrk0f0JG8gnzP5 Jz7tesO8D/aGlcLJ0SglQyK8AMbIQXeivGELvDOrOc2d3WFEHpXssdVXo3OMlZWp v2s4jF57BK31tzJgFjbYD6VoTOMLg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrtdelgdduvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EECC61080063; Tue, 19 Jan 2021 03:39:38 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko , Ferruh Yigit , Olivier Matz , "Xueming(Steven) Li" Cc: "dev@dpdk.org" , Slava Ovsiienko , Asaf Penso Date: Tue, 19 Jan 2021 09:39:37 +0100 Message-ID: <7385570.TH8XZCtoEQ@thomas> In-Reply-To: References: <1610968623-31345-1-git-send-email-xuemingl@nvidia.com> <1df19d3b-8bef-55a5-a403-7f5096a2706f@oktetlabs.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/01/2021 08:56, Xueming(Steven) Li: > From: Andrew Rybchenko > >On 1/19/21 10:37 AM, Xueming(Steven) Li wrote: > >> From: Andrew Rybchenko > >>> On 1/18/21 2:16 PM, Xueming Li wrote: > >>>> +/** Ethernet device representor type */ enum > >>>> +rte_eth_representor_type { > >>>> + RTE_ETH_REPRESENTOR_NONE, /**< not a representor. */ > >>>> + RTE_ETH_REPRESENTOR_VF, /**< representor of VF. */ > >>>> + RTE_ETH_REPRESENTOR_SF, /**< representor of SF. */ > >>>> + RTE_ETH_REPRESENTOR_PF, /**< representor of host PF. */ > >>> > >>> RTE_ETH_REPRESENTOR_SF and PF looks dead in the patch. > >>> IMHO, addition of these members here make future patches which add > >>> support inconsistent. > >> > >> Yes, later patch in this patchset will support it. > > > >I know. The question is why it is not added in the later patches when these > >types are actually supported. > > Good suggestion, will update +1 (I was sure it was already the case)