From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 635BFA0C47; Thu, 7 Oct 2021 13:58:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28E86411D0; Thu, 7 Oct 2021 13:58:25 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id C8B16411AD for ; Thu, 7 Oct 2021 13:58:23 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 79E745C00FB; Thu, 7 Oct 2021 07:58:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 07 Oct 2021 07:58:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= b1G5zbq7W91qj9rMigSF7yyNf4DRTCv+qQrKf38ad0E=; b=DBQzOI9kblluWr2d g9+Y0hT/rPesZK0p4+LesX3wCwsdgs4SRExBDJzfQndXqB0F+sK8Tqf8lf0SwLjJ w77szeJY9LXGZUOCXvX6nxbHnF8HAxk6hakO7jt5fF1eH+FXQCjL3xRGlsS0bErT COReMIgRZ4ZTzxNv8cKC6mhzB4jJw8o1uF78nDtW6hSIy/8gqNbSplqP0WJQTr76 ntJmUhP5d6UkZYYxHCfuqlynjlmI1RPPnVvS99LLw/UnmNUNtDnWHG2r7u1YghT9 HACHX24SFOmUoE00G6+3Mg2kvyNbu+xkUfhB7VXrwroZYcCxa8/teCRnaEpQodQC gdQQkw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=b1G5zbq7W91qj9rMigSF7yyNf4DRTCv+qQrKf38ad 0E=; b=JDFYpsJD3dnbCkkwuihN7NNwPbwUUKoDldkyVIPPbDdmHkSBKkbCxqoHo vG3s4ewpTPTXM581Xe/LeTWWfe82EjAkFqR/0nkyswRVj9m3w+5vNDT0Vt3brM86 hMjYq23hllxPlv9ahgb2R5cLRHK1avSkldulKI1BEv3CpZuQ2GIP/XAYsOT77Y1K MVv3SkgKc9h70LDS8BqDPU9CciBCe/ACIA8Mxb11zRS4yw6GB0bve75bEEJPZs3I MmLyQtnIK/G8G4gKu+KLpiOYQwbblyAMbwMAkGMAYjzKF7oQMwn9iMMsWhWoaler Na2MVinjQNLKzuHzPzKY5P7WQPujw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudelkedggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepkeejueekueevvefgfffggfehjeffvdefleejtdffudfgteejkeeg vddtvdffgfevnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpughpughkrdhorhhgne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Oct 2021 07:58:21 -0400 (EDT) From: Thomas Monjalon To: Dmitry Kozlyuk , William Tu Cc: dev@dpdk.org, "Richardson, Bruce" Date: Thu, 07 Oct 2021 13:58:18 +0200 Message-ID: <7394122.RNkyZvFM6L@thomas> In-Reply-To: References: <20210924180816.150-1-u9012063@gmail.com> <20210925192205.2419fdce@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, What is the conclusion for this patch? 26/09/2021 05:22, William Tu: > On Sat, Sep 25, 2021 at 9:22 AM Dmitry Kozlyuk wrote: > > > > 2021-09-24 18:08 (UTC+0000), William Tu: > > > Windows does not support linker option '/-no-whole-archive' > > > or '/whole-archive'. The patch removes them under Windows build. > > > > > > Signed-off-by: William Tu > > > --- > > > buildtools/pkg-config/meson.build | 10 +++++++--- > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > Hi William, > > > > We need to tell the linker to use whole archive somehow; > > you write [1] that /WHOLEARCHIVE was required in the end. > > There's no "Windows linker", there are clang and GCC linkers, > > the latter supports --whole-archive, but the former needs it translated. > > Argument translation between compilers is handled by meson. > > I've filed a bug: https://github.com/mesonbuild/meson/issues/9296 > > > > [1]: > > http://inbox.dpdk.org/dev/CALDO+SZ-FLPYNQbUJ-Ctwtph+M4_X_=zYAOKgkp5_un4QFq_eg@mail.gmail.com/ > > Hi Dmitry, > > Thank you! > One more thing, when I added /WHOLEARCHIVE, I hit some errors due to > macro definitions. > ex: > ws2_32.lib(WS2_32.dll) : error LNK2005: WS2_32_NULL_THUNK_DATA already > defined in mincore.lib(WS2_32.dll) > Shlwapi.lib(SHLWAPI.dll) : error LNK2005: __NULL_IMPORT_DESCRIPTOR > already defined in mincore.lib(api-ms-win-core > -com-l1-1-0.dll) > Iphlpapi.lib(IPHLPAPI.DLL) : error LNK2005: > __IMPORT_DESCRIPTOR_IPHLPAPI already defined in mincore.lib(IPHLPAPI. > see: > https://github.com/smadaminov/ovs-dpdk-meson-issues/issues/65 > > In the end, I have to add also: > -Wl,/FORCE:MULTIPLE > > Thanks > William