From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D88B7A09E4; Fri, 29 Jan 2021 11:30:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C33C8240188; Fri, 29 Jan 2021 11:30:42 +0100 (CET) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mails.dpdk.org (Postfix) with ESMTP id B815D40694; Fri, 29 Jan 2021 11:30:41 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id E0F955C0067; Fri, 29 Jan 2021 05:30:40 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 29 Jan 2021 05:30:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= fVwChWy3ZqTZgOlVkm0OSG+8JDh6aU0d6rchmrUl30k=; b=Fxh2qihEShMRIcsK KHQ1QzzIcleQaNGUeMOMR9kPFILMfAWj+iqtBqQLH/9u3u3xyG58LnfEGlTKCnUx pWx80eEOBazWMveOI0c5nImhmmSHuiWBKFVgCEosYeSLCs1s7kGkXQSQnjARw8en wMw0aVhUC4Y/iuTMvm6jtLQTlSmd+rBVV9s6qnQW1pr+KquNfkDikGHnWpHeZZdZ K1VGtfsjPCCktSETnkNPiFz+obHB4bWCEtEOi/+rZLxmLGrfBzzhEkhv3Y3OMcaz 0czSGm79xTcyPGDrHf4ge+uvtObiKMDo4dBzaWpbOCRx9At9fUj2wJfSocAcpBXJ yz4zvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=fVwChWy3ZqTZgOlVkm0OSG+8JDh6aU0d6rchmrUl3 0k=; b=c5Cs13W7la/cWX9RfULBvSNvdVP8MBWL+tlT8i7Lm+5ZMOSuwAx8oaDyU T4vy4iXM+cmoqtYR3StkdzLOhXNLnfeNn3Jm382GeRr/woHlIq9gfxfnwYlcLgDS ZUHCn2/W0K9Ild/FKGaScG7k1ELPWwwhmFg6n8/XaOaxVEN65xJAefwk9o13VKTO y8Whv19g7woNJK3sw09Z73Rp+ysufcakppOppEGB6pHFtaf6AY1Cby3+dWAvPwor xUXIMepddBkbAQi0ccsU/I/os243N44i0PQ0rLVQHtQ7PSM4xvCwmpA2VWzdYsGL +PImrW6Iy9x6Xmef1xWybYAvQr/Eg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvgdduiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id F099324005E; Fri, 29 Jan 2021 05:30:39 -0500 (EST) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, stable@dpdk.org Date: Fri, 29 Jan 2021 11:30:38 +0100 Message-ID: <7395258.KU9yk4qBcT@thomas> In-Reply-To: <20210129102149.24463-1-david.hunt@intel.com> References: <20210121172201.22582-2-david.hunt@intel.com> <20210129102149.24463-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 0/6] power: fix make build for power apps X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/01/2021 11:21, David Hunt: > The guest channel message definitions and functions in guest_channel.h > are needed by applications and need to be made public. > > This worked pre-20.11, but now with all the meson/ninja changes, making > these apps externally no longer works. To fix, we need to move the > header file with the API definitions for the channel commands public, > and rename the functions accordingly. > > The main change is to rename channel_commands.h to > rte_power_guest_channel.h so that it gets picked up by the installer > and copied to /usr/local/include. Other changes include renaming #defines > to have RTE_ at the beginning instead of CPU_. Finally we refactor the > code to work with those changes. > > --- > v2 changes > - re-worked from monolithic patch to a 6 patch patchset for easier review > v3 changes > - Ensure both functions added to the API are tagged as experimental > v4 changes > - add @internal tag on 2 functions for Doxygen > - add @warning EXPERIMENTAL tag on 2 functions for Doxygen > - improve description of lcore param in API docs > - Improve maintainability sizeof's > - add the 2 added functions to the version.map file > v5 changes > - moved version.map additions from patch 3 to patch 2 I already applied a modified v4 with the changes requested by Anatoly that you missed in this v5.