From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id E39A31B508 for ; Mon, 2 Jul 2018 18:54:01 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 60E0E8315E; Mon, 2 Jul 2018 16:54:01 +0000 (UTC) Received: from [10.36.112.41] (ovpn-112-41.ams2.redhat.com [10.36.112.41]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DF072166B5D; Mon, 2 Jul 2018 16:53:59 +0000 (UTC) To: Ferruh Yigit , Marvin Liu , tiwei.bie@intel.com Cc: zhihong.wang@intel.com, dev@dpdk.org References: <20180702135642.52577-1-yong.liu@intel.com> <20180702135642.52577-8-yong.liu@intel.com> <7ab59556-5719-e05b-ea1f-f94867d90b24@intel.com> From: Maxime Coquelin Message-ID: <739c4cea-23c8-f1ec-f186-39b74960cb7b@redhat.com> Date: Mon, 2 Jul 2018 18:53:58 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 02 Jul 2018 16:54:01 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Mon, 02 Jul 2018 16:54:01 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jul 2018 16:54:02 -0000 On 07/02/2018 06:52 PM, Ferruh Yigit wrote: > On 7/2/2018 5:41 PM, Ferruh Yigit wrote: >> On 7/2/2018 2:56 PM, Marvin Liu wrote: >>> IN_ORDER Rx function depends on merge-able feature. Descriptors >>> allocation and free will be done in bulk. >>> >>> Virtio dequeue logic: >>> dequeue_burst_rx(burst mbufs) >>> for (each mbuf b) { >>> if (b need merge) { >>> merge remained mbufs >>> add merged mbuf to return mbufs list >>> } else { >>> add mbuf to return mbufs list >>> } >>> } >>> if (last mbuf c need merge) { >>> dequeue_burst_rx(required mbufs) >>> merge last mbuf c >>> } >>> refill_avail_ring_bulk() >>> update_avail_ring() >>> return mbufs list >>> >>> IN_ORDER Tx function can support offloading features. Packets which >>> matched "can_push" option will be handled by simple xmit function. Those >>> packets can't match "can_push" will be handled by original xmit function >>> with in-order flag. >>> >>> Virtio enqueue logic: >>> xmit_cleanup(used descs) >>> for (each xmit mbuf b) { >>> if (b can inorder xmit) { >>> add mbuf b to inorder burst list >>> continue >>> } else { >>> xmit inorder burst list >>> xmit mbuf b by original function >>> } >>> } >>> if (inorder burst list not empty) { >>> xmit inorder burst list >>> } >>> update_avail_ring() >>> >>> Signed-off-by: Marvin Liu >>> Reviewed-by: Maxime Coquelin >> >> <...> >> >>> @@ -150,6 +188,83 @@ virtio_xmit_cleanup(struct virtqueue *vq, uint16_t num) >>> } >>> } >>> >>> +/* Cleanup from completed inorder transmits. */ >>> +static void >>> +virtio_xmit_cleanup_inorder(struct virtqueue *vq, uint16_t num) >>> +{ >>> + uint16_t i, used_idx, desc_idx, last_idx; >> >> >> Getting following build error [1], from code it looks like false positive, but >> to get rid of the build error would it be OK to set initial value to "desc_idx"? > > I applied this while merging, if this is wrong please let me know, we can fix in > next-net, Thanks. Looks good to me. I didn't catch it with the GCC version I use. Thanks, Maxime >> >> >> [1] >> .../dpdk/drivers/net/virtio/virtio_rxtx.c:195:24: error: ‘desc_idx’ may be used >> uninitialized in this function [-Werror=maybe-uninitialized] >> >> >> uint16_t i, used_idx, desc_idx, last_idx; >> >> >> >> ^~~~~~~~ >> >