From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8734E2C4F for ; Mon, 13 Mar 2017 11:29:03 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2017 03:28:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,158,1486454400"; d="scan'208";a="74745305" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69]) ([10.237.221.69]) by orsmga005.jf.intel.com with ESMTP; 13 Mar 2017 03:28:51 -0700 To: Bruce Richardson References: <1488354455-142764-2-git-send-email-david.hunt@intel.com> <1488791433-186137-1-git-send-email-david.hunt@intel.com> <1488791433-186137-10-git-send-email-david.hunt@intel.com> <20170310162228.GB339712@bricha3-MOBL3.ger.corp.intel.com> Cc: dev@dpdk.org From: "Hunt, David" Message-ID: <73b1521e-6517-d74c-8113-86a634f1a0ce@intel.com> Date: Mon, 13 Mar 2017 10:28:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170310162228.GB339712@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Mar 2017 10:29:03 -0000 On 10/3/2017 4:22 PM, Bruce Richardson wrote: > On Mon, Mar 06, 2017 at 09:10:24AM +0000, David Hunt wrote: >> Also bumped up the ABI version number in the Makefile >> >> Signed-off-by: David Hunt >> --- >> lib/librte_distributor/Makefile | 2 +- >> lib/librte_distributor/rte_distributor.c | 57 +++++++++++--- >> lib/librte_distributor/rte_distributor_v1705.h | 89 ++++++++++++++++++++++ > A file named rte_distributor_v1705.h was added in patch 4, then deleted > in patch 7, and now added again here. Seems a lot of churn. > > /Bruce > The first introduction of this file is what will become the public header. For successful compilation, this cannot be called rte_distributor.h until the symbol versioning patch, at which stage I will rename the file, and introduce the symbol versioned header at the same time. In the next patch I'll rename this version of the files as rte_distributor_public.h to make this clearer. Regards, Dave.