Re: [PATCH v7 02/17] net/r8169: add logging structure

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 11/12/2024 9:57 AM, Howard Wang wrote:
> Implement logging macros for debug purposes.
> 
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
> 

<...>

> +
> +#ifdef RTE_ETHDEV_DEBUG_RX
> +#define PMD_RX_LOG(level, fmt, ...) \
> +	RTE_LOG_DP_LINE(level, R8169_RX, "%s(): " fmt, __func__, ##__VA_ARGS__)
> +#else
> +#define PMD_RX_LOG(level, fmt, args...) do { } while (0)
>

There is a checkpatch warning [1], that is to remove compiler extensions.
For this case it is basically replacing 'args...' with '...', in all
occurrences in the file. As else part of the macro just ignores the
arguments, this does not make any difference practically.

btw, you can run checkpatch on each patch by following command:
`./devtools/checkpatches.sh -n1`

The checkpatch results can be seen in the patchwork, like [2],
unfortunately in some patches 'Avoid CamelCase' causing too much noise,
locally you can disable them [3] to focus on the other warnings.


[1]
Warning in drivers/net/r8169/r8169_logs.h:
Do not use variadic argument pack in macros

[2]
https://mails.dpdk.org/archives/test-report/2024-November/823933.html

[3]
DPDK_CHECKPATCH_OPTIONS="--ignore=CAMELCASE" ./devtools/checkpatches.sh -n1