From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04AA245C9B; Wed, 13 Nov 2024 00:07:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C86B4402BC; Wed, 13 Nov 2024 00:07:37 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2071.outbound.protection.outlook.com [40.107.93.71]) by mails.dpdk.org (Postfix) with ESMTP id 899DA40265 for ; Wed, 13 Nov 2024 00:07:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=H8K1T3a7iKD6d/uwdDrFO2HF5zwPpvarbX87NWBJj9b2MCZVvpfWdLJQgEQmpkOYfZW3h/9IhqiWy/TpJquakFC07Xo6SDrjO+W1xT2JspJUjBFbpAHPbk58UbIkg90gdpUGuDCw+EcFZcXlvhmeicenGqblV+8ePSjVt28mkk+LyqY/pVG8YCR1hOgFmwqcPaYroyyelwxkF6BLpMNvnX4GEAR3j+KiYXCn4HgJeTdAz3zvyBGkWbUbmW9qaTRSP/BtWgEh42te5DI46xmpLxAehHA5nqYuX6z3hefPUks6jxMcbUQbnKyzC0kfWgnLAxCILpQbVY79rq5LrWLEoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=crx93Y3CrbZCpNrNnV6C8w7VhFHbUFsvkR1GeGOR22o=; b=qyUfptFvKiyYMMDtAl19EfGmnNKa4dTcHcKpDV3Z0iDN5a8o+bqK2HPkgnwion+1ToQjST4/cFLYhupJVhDKQCraaFvp+DAowuFaP+sUdx6PItyGSHIPatEC8J2pW9V9LhJV5GXZwtQbpw6G5H/F9ywAVGtK7dNYEgkvVDLdUzh04C6isOFRfOiB4/w3Fctv2ADmZ+FGtG9TOXAe3Qb/gx3WwHH3gzKerEqgg0vtp/l/MKIxtRErWJEr7knuK+wVszwFwf3+9Polumph4Vg12AXvCyKkiVnVvl4kfZnLyCZWmozDsCSDFGCIBKPm+R+OyL1IsTDO+iV8NkuxgenZxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=crx93Y3CrbZCpNrNnV6C8w7VhFHbUFsvkR1GeGOR22o=; b=GXF10CQ2MV+EZDAx77mqeF29ZF6gRxMfrXj+GlyCxlV/DjE5Y81GMjECGq/em0U8Q298+eAiw3Wid0IunAZPaONC0WRDb6pef1Xiya+VhMT60fItQPW5/c6LNgVsvXG7vxyZwUYfFf3+qk2icCFcv9mTsS2WxSBsnOSTwEI6rjc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by IA0PR12MB8975.namprd12.prod.outlook.com (2603:10b6:208:48f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.17; Tue, 12 Nov 2024 23:07:33 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8158.013; Tue, 12 Nov 2024 23:07:32 +0000 Message-ID: <73d26622-e9f1-4b4c-b6e8-590514678d0f@amd.com> Date: Tue, 12 Nov 2024 23:07:28 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 02/17] net/r8169: add logging structure To: Howard Wang , dev@dpdk.org Cc: pro_nic_dpdk@realtek.com References: <20241112095804.42091-1-howard_wang@realsil.com.cn> <20241112095804.42091-3-howard_wang@realsil.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241112095804.42091-3-howard_wang@realsil.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0068.eurprd04.prod.outlook.com (2603:10a6:10:232::13) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|IA0PR12MB8975:EE_ X-MS-Office365-Filtering-Correlation-Id: 37f7b3ec-ecf0-4201-7d99-08dd036eca02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?YXRpR0dKVkx5Sm1jSU00V01STkdPMHdHa29nNmxnSlcyY1ZIUkcwalFBK0s2?= =?utf-8?B?WU4yVHNkL0xJbHFQWUgrZnBPU296QkJoYzFLMWRzQ21WVnMydDdqeCtwSk1n?= =?utf-8?B?SmRmek5uWk10eWJ3dnFzNVUxTXBFMVJlSmJ1QzJaUmxHM0toWEJXNkFMOGow?= =?utf-8?B?SWVldnJkekdlMWNTbUVvc2VMMjVVdk1IMHh6MmVjWVcrYU94WTVMaDdPZHI5?= =?utf-8?B?R0hlVENLRUxUeG1uZU5HeloxS2RrcW1WcmxWZmE3SDhxOC8xQzB2bllZWjJp?= =?utf-8?B?dCtFUTdpZFdZVU12UTk4SkMxR0tLSGJDSHpHTlR5VENUMzR4djN6UCtRNmlE?= =?utf-8?B?Q2xYai9JcWVGTFdPbEpVaGVNNTFHeGJiM1BxelZYaElnUzVoY2wvbXRTcWhR?= =?utf-8?B?czkzVktoMFd1UkNpOUpEK0hlM3hJVFQ2NzBYZEIrQXR0Z25tQlpjWFhkN09U?= =?utf-8?B?OTJUUVdZd3ZqeGNlaHFPZFFZMVMreStobStBRy85ZFdmanNXcUpsUFoyTks5?= =?utf-8?B?VEZUckhxWktsMDQxei9DQ00xdW9rTzlXcnNtbTVqUmY1QXBBOG5NREtpVHQ2?= =?utf-8?B?V3VEWGFxYmRPZThOQlVuMGZCL25ZSnlDVkNNQUIvOGNLSW1IOGtNR3Qwd3Nv?= =?utf-8?B?dUd5ckkyeUF6bGZ4VTJVblFsUWYwemtMZ2VJcjk0am5nbTYvNStsUVNaWFNo?= =?utf-8?B?OUFZbU4rZU8ybHdBNHFNeS8wOEVNaDNLZzlyeEhIdU5TNjNlbGZtWHlodGNT?= =?utf-8?B?dk41ZlRCK0hGcVFGakRrT3Y5UDU5bkFHZGhGYVZYamlxNU54d1FuRmNJQnc0?= =?utf-8?B?YjZ4UGZCTWRvSGVoaU9ZNDdKNVgvelRCSU9ob2NXMkw2bUFVNVlla2sxZkZi?= =?utf-8?B?M1Z5U2gyV2J4cVNCTWZVVEt1Y0lPbDdPdTZlQXB3bThZTmhxUGxCOTVRaWNJ?= =?utf-8?B?RnBsVitlY3pzVTVaSTZJZURjY2owSzQ4enJ4eXcwanJuc2loSmM2TWcyeGMv?= =?utf-8?B?UWNVUTBkQjVjVk5LcjZlakhFdk5lK2E2ZzRPcmdDNEI5OXJpRUtBem9YVyt5?= =?utf-8?B?M29ONlBrTmNKVWR4YmtZWGZQWXRuVzN4dzZOdHVDUEtkeVFTcHdZMVQvLzZ4?= =?utf-8?B?YnRoZmlZYTVkVUR3NjZjcFJPOHFqMHM2bnBMTnlTS1dMMGEwUW1VOEtoVk9K?= =?utf-8?B?QkF1dFJzMUJhUjJIS2xUbThmNXMwY1hMblVXQ013ODBLeUxpOFMyblkvbStt?= =?utf-8?B?RnRYbFV5SVA0cWl0eEg2aUYvMW9lVzJpTUtkNGpYYVorUHlld1BlZ2VIS0ZE?= =?utf-8?B?Ny8raWM0L2Y5cHJiNjBoem1lejBKMmtmSXRiTnJhVi9uVkY5R0xVK044UDNh?= =?utf-8?B?dHFYL3FyK2MvNmJOMXplT0NoUG54R2ZQVjFDOWNGbkdkYmFTSi9pSGhRM0c4?= =?utf-8?B?c05mYlBMVmhmV2NsN3BDeDJYUStnNkgvYzFOQzU0eHVKQW5GMk90S3ZidU9l?= =?utf-8?B?RFZLa1dKNTVXaDVqNEtyb21iTERlNHJ2ZlJGcThVODNoTWNGSjRHdk83OW1Z?= =?utf-8?B?L3dUc3E5TzhBdkNxaU9RQ3MyWVJZUjNJc3pQT2VGQmErQkFGdXMweHZPRUFa?= =?utf-8?B?QXpqVUEvT0ZsWDA2RjhkdlBsYlBWQ0phMUpMQ2UzSithZ2pDakhYa0RVTjlS?= =?utf-8?B?Q0NVWXYzVU9QeGhsSWxSZThHWTBFOVNSNXRpSUdzaHY5eXhFSmdUbnFRSU9W?= =?utf-8?Q?Q0xYj6ndITbNMU3C6KSdRBFxasUVODWgKFxrUmJ?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTNqTUhyS1JtZFAveDZPVFFEWGJuaHFUcHVac3pPd2VMWStFS0ZtRHR5WmhR?= =?utf-8?B?TnBtNnUrVzJUOXBILzVKdFRhektWS3dLai9wK001cnpGU2M0ZUpmZ0h3UEJI?= =?utf-8?B?U21rSEgyUDNaTkRLay9kOEJZNitidVVVaDUvcFFhL3RLSEFFWDgyQm1IUWZm?= =?utf-8?B?YTZXZVYySndya2E2NkhPZ1lzSjNjUHFTbUREcmtOdTd3eHBxc2dXM3BYeFlM?= =?utf-8?B?MG1GR2ROSjFIaXlsTlowdlZNbWlMeWdSR004Y1BjL2Q2L2RWb3RhWDE3dUpv?= =?utf-8?B?VmxlaW1uR2dwVUJNYUJRaVhYVUFLNmFDY05sSW9VWXV1cE1IS1ZaU3NqdkxV?= =?utf-8?B?ZDZxaG9VSFMrN2Urdkw1QTBGZWpGUFM5T3M2L3g0dDN5TVd1dmNmNjZNSm00?= =?utf-8?B?cWxiQWJZUGRMOUpOaWhzMDg2ckIzWDhxOUVUaWtRTHJUOGl4dm1oWGRUS2N2?= =?utf-8?B?UmJodmo1bWluS09tSGhIOUVta29TVGhzTUowdUNBd2phWXBFbkQ0aGZxSWRH?= =?utf-8?B?a2YxTVQ5Zm1xejZ2enZDbDkxdC9id2ZlRmkyeGxRa0dEc3ZIdzlKV1RpNFBv?= =?utf-8?B?UkpBZVFSOUJuN1pwVnVobXg3bnZNVWVXSXA5WStwYzl6OFdoRWhYUDRSUm03?= =?utf-8?B?YjkzSEVXRk1vSTY3RktickE0Y012NDNENlJ0dVBDdDg1b3V3NDV4bWtXYUli?= =?utf-8?B?MTQ4aFhFaEtKOGVHQlI2anZsMDlYYzRMZDh0c2RIcUxrZHBUb1NvZnR5TkRN?= =?utf-8?B?TzNqTDZxNWc5b09nYk4yemRWaG9GSEQ2dGJHOTNSdHNrVUtUbHdib2JIZm82?= =?utf-8?B?ODIrd3FLUWNpbFlheWlGVXVBcnRIV0ZaYmxlYVovRFBtMTY5VTFtQWNsZTBS?= =?utf-8?B?RHQxRW5leVJ6ZXdTWWRpbUdlOEptcTYzczMya09uV1NtUTdqNWgxOEVGek5T?= =?utf-8?B?YWtQQWErT2FSaEcvMVBFOW55SUpGY0pjSm5qTlhQbGlvY1BQSlorUDRnSlhE?= =?utf-8?B?L0FHUkZESlhCUDNFZi8rQ201eWpTUWpZM2NJcWxLUkVqZ0RtTkxZQnZnZ203?= =?utf-8?B?dWFGbi9Da29yWHFNUlIxaTdoOGNxWlpPRHhlSjQxZm1BaFE1ZEhiT1l6Q1J2?= =?utf-8?B?aEJUYnY3MExVeE0vQkRhd2NhakJhVEVwd2dNUWRhd2M1WmVucDNoT2JoN0x5?= =?utf-8?B?cy9PcmFJN2ZyczhZZ2lRYXFFZmJveUtPTWVpRERldHcxNXplUEZzUitwQlFh?= =?utf-8?B?ZFlTcVJoSTVPWnpzVzF5V1d6aytsczZYMm5UeWxMeDZ3ajJGOHFXekZYL1BE?= =?utf-8?B?WjYwVzFtZHpXV2c0M2tjZm10enlFTkdwWjFmckF6UStHc3JyV1diWm03M0JK?= =?utf-8?B?dDdMRVFwSXMzWjg5TWRPMVA0WmdRbUVGdE03MG5vblM4TS83eTlCUFAyRkJC?= =?utf-8?B?enJiWVVzY29qbEZ6NlFXT1RRc3JmRWZWWTc4YUVnck1tcStiZ3NBN1EwUjF0?= =?utf-8?B?R1BlRTZ5bHk3QlNFaHA3QVhIVlJ6MHNxVXpuaCt1RGQvYi81aEs5V0hRZUhl?= =?utf-8?B?c0VyM05WcU03ajFHR1N5ZExyUVUwZVZFZ1pQR2NobElrM0dETzYwUXVSZnlo?= =?utf-8?B?cWFvQnl3bmhHeWNDc2UzSlRqQVhxQThibm8vQkdWb3BsVEdhYlhVeHkzQTNV?= =?utf-8?B?NUJOMEg4ZXAxMmhIb1AxWDh0WUJaVlhMaHJvQUxaek5ZYmh1dHJuQnlVdzkz?= =?utf-8?B?OTIyQUJwM1F6cmFRbFRQVndONENJdm5xNk5UMTdFWDRMSDI2YWVvWGYwSjZF?= =?utf-8?B?WFAzVUVIRE0wbU1NV2ZZTVRPRW5CcEhlaHl2R2p4RTViRTMxdzBUS2hLVVBh?= =?utf-8?B?N05UdEhDWWtGTVZDb2c1WXBiaW9oYjFyMHIzaXRNOEIvZ0FWazQ3WlJGQ0Jz?= =?utf-8?B?K1BhZWVNNUt1SXpaaDlERCtsR0ZuSVVNd2I5UnpuUG5BcG5MdlY2Y2lsRXFo?= =?utf-8?B?bXkrQit3bUVvVis2c1FrL3RWQnpXRUw4UWdza2pEd1REY0ErVm93c3RZeUpm?= =?utf-8?B?VFhXcFlTT2xaa29WeFNJSC9kQWI3bFVlT0Y2TElLU0VrcjhJOS9VaUVWQzhR?= =?utf-8?Q?eIJO7RuMmGn+ScNTe1MDhQ8Y2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37f7b3ec-ecf0-4201-7d99-08dd036eca02 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 23:07:32.9221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9FB9oopLRGk7YYESL/RV3uRW3MtulqRp4RbeHdBLOmJLe0chpI55ljqnSms5/2XH X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8975 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/12/2024 9:57 AM, Howard Wang wrote: > Implement logging macros for debug purposes. > > Signed-off-by: Howard Wang > <...> > + > +#ifdef RTE_ETHDEV_DEBUG_RX > +#define PMD_RX_LOG(level, fmt, ...) \ > + RTE_LOG_DP_LINE(level, R8169_RX, "%s(): " fmt, __func__, ##__VA_ARGS__) > +#else > +#define PMD_RX_LOG(level, fmt, args...) do { } while (0) > There is a checkpatch warning [1], that is to remove compiler extensions. For this case it is basically replacing 'args...' with '...', in all occurrences in the file. As else part of the macro just ignores the arguments, this does not make any difference practically. btw, you can run checkpatch on each patch by following command: `./devtools/checkpatches.sh -n1` The checkpatch results can be seen in the patchwork, like [2], unfortunately in some patches 'Avoid CamelCase' causing too much noise, locally you can disable them [3] to focus on the other warnings. [1] Warning in drivers/net/r8169/r8169_logs.h: Do not use variadic argument pack in macros [2] https://mails.dpdk.org/archives/test-report/2024-November/823933.html [3] DPDK_CHECKPATCH_OPTIONS="--ignore=CAMELCASE" ./devtools/checkpatches.sh -n1