From: Hemant Agrawal <hemant.agrawal@oss.nxp.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: thomas@monjalon.net, Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>
Subject: Re: [PATCH 2/2] common/dpaax: do not disable fallthrough warnings
Date: Thu, 14 Nov 2024 11:36:46 +0530 [thread overview]
Message-ID: <73f2ef90-5167-3f45-3ebe-ef30ef1a0192@oss.nxp.com> (raw)
In-Reply-To: <20241114003648.331795-3-stephen@networkplumber.org>
On 14-11-2024 06:06, Stephen Hemminger wrote:
> Fallthrough warnings catch real bugs and should not be disabled.
> There are warnings in this driver in current build.
>
> The commit that added the disable is old, and the problematic code
> appears to have been already removed.
>
> Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7")
> Cc: thomas@monjalon.net
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/common/dpaax/caamflib/rta/operation_cmd.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/common/dpaax/caamflib/rta/operation_cmd.h b/drivers/common/dpaax/caamflib/rta/operation_cmd.h
> index fe1ac37ee8..563735eb88 100644
> --- a/drivers/common/dpaax/caamflib/rta/operation_cmd.h
> +++ b/drivers/common/dpaax/caamflib/rta/operation_cmd.h
> @@ -7,10 +7,6 @@
> #ifndef __RTA_OPERATION_CMD_H__
> #define __RTA_OPERATION_CMD_H__
>
> -#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 70000)
> -#pragma GCC diagnostic ignored "-Wimplicit-fallthrough"
> -#endif
> -
> extern enum rta_sec_era rta_sec_era;
>
> static inline int
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
next prev parent reply other threads:[~2024-11-14 6:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 0:36 [PATCH 0/2] fallthrough related handling Stephen Hemminger
2024-11-14 0:36 ` [PATCH 1/2] net/e1000: fix incorrect fallthrough in switch Stephen Hemminger
2024-11-14 9:03 ` Bruce Richardson
2024-11-14 0:36 ` [PATCH 2/2] common/dpaax: do not disable fallthrough warnings Stephen Hemminger
2024-11-14 6:06 ` Hemant Agrawal [this message]
2024-11-14 17:11 ` [PATCH v2 0/2] re-enable implicit fallthrough checks Stephen Hemminger
2024-11-14 17:11 ` [PATCH v2 1/2] common/dpaax: do not disable fallthrough warnings Stephen Hemminger
2024-11-14 17:11 ` [PATCH v2 2/2] net/e1000: fix incorrect fallthrough in switch Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73f2ef90-5167-3f45-3ebe-ef30ef1a0192@oss.nxp.com \
--to=hemant.agrawal@oss.nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=sachin.saxena@nxp.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).