From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA0C945CFF; Thu, 14 Nov 2024 07:06:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9FAA74066C; Thu, 14 Nov 2024 07:06:58 +0100 (CET) Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2077.outbound.protection.outlook.com [40.107.21.77]) by mails.dpdk.org (Postfix) with ESMTP id EB259400D5 for ; Thu, 14 Nov 2024 07:06:56 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=jwJjyziKX4jB6WkrNQKce/owxwOUdCY1CXgD4Q6/gFdWopODsL+m6Z24KM/Mic64HwfZW41GqPEukXsf+N5sKbrgzP3BRAOYCf5NQSVtr1ZH2AxK5YsNpTccRdbzijE4iUGFWA60k5zeHPP4hE2hsi4Kcf16ZFdy6sTwtArRKMimdS8ZXQbIKKUcGJe0ZkvyibKvSHFqchFIiXS2M3ApqGx6gMFVJQu0nmgSqUzqOIeitG3JTfNpHycSjHgPx9HU9IvD4kSyEZf/tkqS+ghyoALfoMn7HFyRbHz0YBQWAb/wEvOr9LNjpmiDZm+CHz5cPEAfL9I0qpTkhoijQRNpSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JnKAu/KvOYwunWAmvanGWTdHX1oaUKsB0jd5Wf57rc8=; b=ShxXjRIm7sKfsBbrYrRcraNw/Dqaqg4zz5wucfuWHYwcBWkpWNlx9iqat8/zlx8WCBica9VUkiY7B1iCQgnPVZVnW/CcmD8P1sr1DDcNWkslz4uZNjMrK5LNgueKF5pWbzpSl2uon4jUp5LvkoGXp4TiHAljzSLKf9eoHHL1kaulNdF5BLhbs+s9QhprsCTPofi/F9sw6xcI7gUHNvgDKTbPAZ5sqPDjwFkl9/RogpyEmurQ82eJylYV9i+ywB+t9i3eFxC4oDuYbnqy/c0b+BFCgmk5ndjuN/BIhFTBiTriAuTGAkiVoCxWlBCrpnXA/PHyrHYcVLqHY41URnLCDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnKAu/KvOYwunWAmvanGWTdHX1oaUKsB0jd5Wf57rc8=; b=DrDEe1g4toEVRhZ2Ntflj6h0RGNvq8sr1hAR88YC8gFPMNgAI2B/F0NSJ4X7+Sr+Pl8O3lsZdL5MZCWHMw6VCi43UyPSvhUjc2lPoUc0UD6ahxGu1+iJ7jwToB8zOXGQdW2UoEIJtJZc6SvHoSjmAQotah1EYlY4hUl5H4trQx6pK+Q7QcFzVZJFJ7hPIaqH8+S/MbjRddOr8du7L/CAbyOqAQQIHuRrH565c2CnA6fCZ7kfrrVlPGLJKlgCI1i1fxR3FHiJo0bOMWcZ6q4r76Qs6ktxqxRTFZmnDTvjvcTRFGbNvkQSrJn/VyLSrXz1wRMAzhfMp+2/wzlNb4LCeQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) by GVXPR04MB9925.eurprd04.prod.outlook.com (2603:10a6:150:112::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Thu, 14 Nov 2024 06:06:54 +0000 Received: from PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87]) by PAXPR04MB9328.eurprd04.prod.outlook.com ([fe80::367:d59:375:fb87%4]) with mapi id 15.20.8137.027; Thu, 14 Nov 2024 06:06:54 +0000 Message-ID: <73f2ef90-5167-3f45-3ebe-ef30ef1a0192@oss.nxp.com> Date: Thu, 14 Nov 2024 11:36:46 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] common/dpaax: do not disable fallthrough warnings Content-Language: en-US To: Stephen Hemminger , dev@dpdk.org Cc: thomas@monjalon.net, Hemant Agrawal , Sachin Saxena References: <20241114003648.331795-1-stephen@networkplumber.org> <20241114003648.331795-3-stephen@networkplumber.org> From: Hemant Agrawal In-Reply-To: <20241114003648.331795-3-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR02CA0016.apcprd02.prod.outlook.com (2603:1096:4:194::9) To PAXPR04MB9328.eurprd04.prod.outlook.com (2603:10a6:102:2b6::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9328:EE_|GVXPR04MB9925:EE_ X-MS-Office365-Filtering-Correlation-Id: e9f47d6f-6640-4353-ae6b-08dd047288c0 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cm5ZRlNzZ2pzT04yRWtjcElTUk5JbTlPODVkc1hVWjB1WC83VmVBd2R0V2NX?= =?utf-8?B?b2VLUS9MU2FxMU1JSGhHWUM5L1Rpc01udXl2V3IyYTBaQU9IRkpvNytrQnpo?= =?utf-8?B?eGlaaTdhRkQwS21HcTVlQTNJR0lPRDkzdllYdkJVTVgrR1huRFB1RE85QXdm?= =?utf-8?B?cmRwdkN4OVNrcnRuZEpNcHR0N1pYR29NZ0lhRkk2TkNlenlRK0lKT01CNXQw?= =?utf-8?B?MkFVSnY4RVZaZjRnTlhKbnhrV2NJSkRUVTU1eDJhbUt0RDFLRFZzc09zM0JD?= =?utf-8?B?MTN6eVQ1VU1oSHRocU9MclpvUFM2dGdxb2lvVlpkU2lxeGU0Zmx1dXZzaFJt?= =?utf-8?B?UHBsYk5Ea1AxWU9SS1RBZ001MlV2Nk80T1pOcm1JallUWDRwbFFzZlB4T0Ri?= =?utf-8?B?aUhmOFVKcDE2WjlsMStyQW0wdWNFTlVkYUlJT29UelhBZUprMmxMSkJPSThx?= =?utf-8?B?Y2xwSWxtSW81aGFQSHdUTVpScFU1OXd2QzFDTy8vM3pFeGRpaUJBVmpaODhU?= =?utf-8?B?Wml1ZTd3SDZTYzAvdFVsemJxRzNMUWJ1cW40WWltUXZvcndaTUIxZHVlNUdr?= =?utf-8?B?NFR5NWdBRGs1WTJlWVlUcTZ1OUZXUzR5eGFuOFZacXBJeFhwSmxIRkJTTW42?= =?utf-8?B?cStaalRHY1NscFhLTmF4cFNKaXNOR21BNXp3REw0YlJhckhFQzhlbGZKZDVk?= =?utf-8?B?cWJvcGh6QU5kMG1vWFJVdkVzRTRzUVBMcWp2NkdrOERiZGk2Ly9mSkRVdmQ1?= =?utf-8?B?WFhxalVURHlSNHgxbTR6RVRTRmJlSE5Lc2R1TVVHOTR1K3plSzBoRzhDUG9N?= =?utf-8?B?RlhURXpNMk9JVkVxSXgyd29uQVpvOU5nT0Q3QjNHdmMrZW9nenpOcHVwTGJs?= =?utf-8?B?S1RNMUdJUGhzMmlXQncwQ3hXcnJObFVSMGw0Q0xKdnJibXZXV0QrY0VFWWUr?= =?utf-8?B?TzB2OUovdExqSUN0VGY5ZFpnMUFhVkQ5MmNDSDN3cFJWK2dBUHp3RFFVVHlG?= =?utf-8?B?RExVaUpLb2tTdTFTRWI3VEYxNkVpdkh2V0FIU2F0MGtWblhvYk12QXNVSmhC?= =?utf-8?B?bmUwQjBDTkVlOXI5bTNQTzU4SForS3Q1RWg0dXFZNVg0M1h2ODZoVFNNbDM0?= =?utf-8?B?bkpTaFREVkhOc1VPeUNnUkFrSGZHN3BHNUk2MXg2UW4xbC9VWmN4a0FMNjB0?= =?utf-8?B?MjA2ZHJsb3llay9lTVhKYVR0QnJNVTZHdFczMFh2dHdrWW5WUDhnSmpxcWZN?= =?utf-8?B?S3BUWWhiVVgzaGVtRW9TTHY5ZWh0YzVuWStqNHpteHRWRklVZWpscTBya1Za?= =?utf-8?B?U240WUhzUW12MU1WK2IwbktWRS8yQW01cVpFZ0RldE5hdGk1MzhTM014RVBv?= =?utf-8?B?eWR6cDZhRFBvL29wWk80NGV0YythZFY2eXNIcEZESFY3eWJkUmhocjVKUWEz?= =?utf-8?B?bVUrQ1dud2dzRVFNRXA3UXJabCs1Y1hXMGZVWkQwbTBSWmhDNVJUU1psWHlL?= =?utf-8?B?YkxMZVB6NjFyYVBFU0V1TjExZEVXL2VqWHFZTnpOcG56cW01ektCZ01FWnlB?= =?utf-8?B?S2JwRmhQN0wyaUd5eXIvdGdTNlRqci8yQmlMUzkrbWFDZml0N2JtcHZSMFM0?= =?utf-8?B?ZVlQZ3owRUE5eW5ZRzNyTnM0NkpQeHhqZVBlUmpmU2JJTTYzeUY5S2xZdlNn?= =?utf-8?B?L2draUZPbnBZNzFZd0JQSEQybjcySHIyUGJkYXJOc1JNNStTRlRoVjdhQjN4?= =?utf-8?Q?7nlREFjCLXUX/NoyA4=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB9328.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck1JSkEwdXZJVzhrV2JOendXdENiaWh2SVhWd0VkaEg2T05uR1QxVy9zZXFQ?= =?utf-8?B?YVB2ZmtmRzF3ejlYcVdJYktuRnZkSC9ucU0vbldjTlhXZ0FnTThLcnY1a0ZV?= =?utf-8?B?ZXFDUksvM0FVMXRwd3pUVG1udFU2OHZ5bC94RHpUYSthMXlrTDFBSE1OUVdn?= =?utf-8?B?eGpuUUhSK1pBVWxVdDRORkRXTitkQVhvL21hdmYyMWlFTUE2NlE5R2ZpeHFw?= =?utf-8?B?VVMyV3VjdVZld2Z5NFA0M0ZhU2R0czhKVDIrdkdZeXBsMExVQXZub3ZnR3F5?= =?utf-8?B?TUQ3MXpuMGV5UWg0VlhFZHQxSjRxL2FpQ3lxWmNGbHd5K1QrZ1RYVHdBYUxK?= =?utf-8?B?eVFaOUJnZDdMbllsMittcm1naHVvTUF6NnpJcTRkOEo3OFJ6NGxLWWlVVi93?= =?utf-8?B?MEdKZ21DL0l1Q2t3R2NUbmlYSWk2Z1J6NTR4YnAxK29qZ2lSdEU5SkNsSGVk?= =?utf-8?B?TDBUNXZjYWJOSnhVOUg2ZjVxc2pJOGdNbVlrOGNWZ3dGdUxJY000MXl2K0pO?= =?utf-8?B?d2diV01pVE0vOEJZWVluK2YvTGxOY3hmK3NkRjQwNU8xYmZqOXFCTTVPOVJC?= =?utf-8?B?dTM4MXJpbnBqaUpTc2tYbDZQT1BZbitXeElDM0FNV3BuUHRUVURrZWxjekEz?= =?utf-8?B?MDhwQ0JhTkVpcUpHRTV1dE41RmNTQzRMdVp0VkxhS2MyUk9hU1k2ZmRORHUv?= =?utf-8?B?Zytmbk9CK0dFZXkrN2xtQlloMklyd1BpRkYwakVqeHNDTFp2Mm5PMG41SjJm?= =?utf-8?B?RXJSUDdNWEM5NUxlRlBXaG9oZlBFK1dDT3ltYkp4L0NPWTJDUmRXSVZPeVk0?= =?utf-8?B?eFAzSjRpb0tFbVRVZFlUL2dEcmpwSWdJMFBxeERtL3hpNytGT0hGUDUydmM1?= =?utf-8?B?RzNjY0dncE14djlsbWVSUkViaGZrcHhmSEJGaTJXeklyV09EaXJPSGZoajM2?= =?utf-8?B?Qy9HaE1PUEZCeGJGRVhpVXdJNVdZZmY4VUNIWXk5VVB5aTFwZXhpMEdDN2My?= =?utf-8?B?SlBJZ0VBcW5kN0Z6OGJGVEt4Zk94ekdvUS9sd0ZvM1F1Q25MTThrb1k5SjRW?= =?utf-8?B?NndNNXR4bmxwenpyMWxhem81YldFVVRWd1h0R3BMMlJ2bmJMRElJblNaL1hM?= =?utf-8?B?SUhaSkRxK2ZINjJmd1NBenRPQURGMVVuZUNSYVp0VTkwLzhud2lVNWdWMzZ3?= =?utf-8?B?Mm9mS3lJOEpnYTVOVzlYMjMzWkxHVGFDOU01STc1VmlIK3lGUUc1VW9hYnov?= =?utf-8?B?N1o4bHB3djZvT0tMQWcrL05UMGF6dVVCTFRHQ1A2cEtNMVhxVDE1bVdPVDh5?= =?utf-8?B?K3BLU2xtci9mQ0FMRGpJSjlzVDF0a2RHMWZGckhJVXVxalZ1dUVFVDZJMXgz?= =?utf-8?B?VWRHdXVsUVpnbGJ4YjNkU1JIc08yblRxVndoNG8xRk42NWpva1hadDlJTkJv?= =?utf-8?B?cEVQZ3ptcitsdDBuMElxdFl1ajQ0dk1XWlIrdERKUTNvZFBqM3lyK2Q4Rmwv?= =?utf-8?B?cGxodm5HQWV0VS95YTRkWG94L0p3RmVlWFZwa1dhY2E3elVtUW90VzZON24v?= =?utf-8?B?UjFFbGVNZ1NzNEFPUjB0Y051cWxlR0VDV240L0FNVCtIWlU3M0p2cVpFMDlV?= =?utf-8?B?MDhTb01MN2JwaWZlT1FZWUNSOXAybzZJalU2dktZSmZ1Y0RiSmhLeG81M0Rj?= =?utf-8?B?eHNWVmtUOHhmeGVTNFlSK0hnTENlcEp5VkFhM0hEYWQ4bnZhc09PcFY1eEZH?= =?utf-8?B?dDJvV3kvYVIvWjdxM3ZlT1hTKzJJeTVEZnFVVzduZFplZkR3dVJ0aEpwY1lC?= =?utf-8?B?bGwrd0FmMWd4YnBLSUdMZnRGMVU0REo1R2Q1THlrdU5JT1F6bWhNTmRheWxp?= =?utf-8?B?K1N2WDZJYVhDTkNKVDB3ZkYwTnlGL3hyTkFTN2V2TWcxazJoL1dURnVLZzRD?= =?utf-8?B?TG9lMHArNWEyNW9sWElPTzZuTVJNcTBoWnpiaUxlVmtvV1djZmE4R2labHcy?= =?utf-8?B?N3ZrSFFGNjZMZ1hHT2lEK3IyRzVHdEY2dFpsMDVuMVNDbXlpN2t5QW1SL1ZJ?= =?utf-8?B?S29EVy9vRjhRbnFId3o3RExTOFM5WW9QNDNqWTZSdmdBSG40L0VqVUhEMzd6?= =?utf-8?B?Z1hKUVA4UG5WVktCTUkzeXhGa0hNZ3VVb21JVDRDSS9jbHlXbEQzZ1BMUnAv?= =?utf-8?B?M1E9PQ==?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9f47d6f-6640-4353-ae6b-08dd047288c0 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9328.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Nov 2024 06:06:54.1166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s59t5YJnxZkLG5e9dytY9W/NDfn8NINiqsT4px6MExR1Q+HxY7xILif1rtDFMkd8rrWay5hjA5rD80XW0EiH4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR04MB9925 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 14-11-2024 06:06, Stephen Hemminger wrote: > Fallthrough warnings catch real bugs and should not be disabled. > There are warnings in this driver in current build. > > The commit that added the disable is old, and the problematic code > appears to have been already removed. > > Fixes: 2ab9a9483196 ("crypto/dpaa2_sec: fix build with GCC 7") > Cc: thomas@monjalon.net > > Signed-off-by: Stephen Hemminger > --- > drivers/common/dpaax/caamflib/rta/operation_cmd.h | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/common/dpaax/caamflib/rta/operation_cmd.h b/drivers/common/dpaax/caamflib/rta/operation_cmd.h > index fe1ac37ee8..563735eb88 100644 > --- a/drivers/common/dpaax/caamflib/rta/operation_cmd.h > +++ b/drivers/common/dpaax/caamflib/rta/operation_cmd.h > @@ -7,10 +7,6 @@ > #ifndef __RTA_OPERATION_CMD_H__ > #define __RTA_OPERATION_CMD_H__ > > -#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION >= 70000) > -#pragma GCC diagnostic ignored "-Wimplicit-fallthrough" > -#endif > - > extern enum rta_sec_era rta_sec_era; > > static inline int Acked-by: Hemant Agrawal