From: 刘洁 <liujie5@linkdatatechnology.com>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: Re: [PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function
Date: Sat, 12 Jul 2025 09:50:40 +0800 (GMT+08:00) [thread overview]
Message-ID: <740842a2.37f15.197fc53ce1a.Coremail.liujie5@linkdatatechnology.com> (raw)
In-Reply-To: <20250709090930.10bb8130@hermes.local>
> -----原始邮件-----
> 发件人: "Stephen Hemminger" <stephen@networkplumber.org>
> 发送时间: 2025-07-10 00:09:30 (星期四)
> 收件人: "Jie Liu" <liujie5@linkdatatechnology.com>
> 抄送: dev@dpdk.org
> 主题: Re: [PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function
>
> On Wed, 9 Jul 2025 04:43:04 -0400
> Jie Liu <liujie5@linkdatatechnology.com> wrote:
>
> > + RTE_ATOMIC(bool)link_thread_running;
> > + RTE_ATOMIC(bool)is_stopping;
>
> Despite what checkpatch says, need space here:
> RTE_ATOMIC(bool) is_stopping;
>
> > + rte_thread_t link_thread_tid;
> > + rte_atomic32_t link_thread_running;
>
> Don't use old rte atomics, instead use RTE_ATOMIC() consistently
>
> > + rte_atomic32_t is_stopping;
> > + pthread_t link_thread_tid;
>
> Two struct elements with same name, how does that work?
>
> > + bool is_stopped;
This will be fully revised in the 14th patch, so please don't worry.</liujie5@linkdatatechnology.com></liujie5@linkdatatechnology.com></stephen@networkplumber.org>
next prev parent reply other threads:[~2025-07-12 1:50 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 2:36 [PATCH 01/13] net/sxe: add base driver directory and doc Jie Liu
2025-04-25 2:36 ` [PATCH 02/13] net/sxe: add ethdev probe and remove Jie Liu
2025-04-26 16:11 ` Stephen Hemminger
2025-04-26 16:11 ` Stephen Hemminger
2025-04-26 16:15 ` Stephen Hemminger
2025-04-26 16:17 ` Stephen Hemminger
2025-04-25 2:36 ` [PATCH 03/13] net/sxe: add tx rx setup and data path Jie Liu
2025-04-26 16:02 ` Stephen Hemminger
2025-04-26 16:20 ` Stephen Hemminger
2025-04-25 2:36 ` [PATCH 04/13] net/sxe: add link, flow ctrl, mac ops, mtu ops function Jie Liu
2025-04-25 2:36 ` [PATCH 05/13] net/sxe: support vlan filter Jie Liu
2025-04-25 2:36 ` [PATCH 06/13] net/sxe: add mac layer filter function Jie Liu
2025-04-25 2:36 ` [PATCH 07/13] net/sxe: support rss offload Jie Liu
2025-04-25 2:36 ` [PATCH 08/13] net/sxe: add dcb function Jie Liu
2025-04-25 2:36 ` [PATCH 09/13] net/sxe: support ptp Jie Liu
2025-04-25 2:36 ` [PATCH 10/13] net/sxe: add xstats function Jie Liu
2025-04-25 2:36 ` [PATCH 11/13] net/sxe: add custom cmd led ctrl Jie Liu
2025-04-25 2:36 ` [PATCH 12/13] net/sxe: add simd function Jie Liu
2025-04-25 2:36 ` [PATCH 13/13] net/sxe: add virtual function Jie Liu
2025-04-26 15:57 ` [PATCH 01/13] net/sxe: add base driver directory and doc Stephen Hemminger
2025-04-26 15:59 ` Stephen Hemminger
2025-04-26 16:23 ` Stephen Hemminger
2025-04-26 17:07 ` Stephen Hemminger
2025-04-26 17:08 ` Stephen Hemminger
2025-07-04 2:53 ` [PATCH v2 01/14] net/sxe: add base driver directory and doc Adding a minimum maintainable directory structure for the network driver and request maintenance of the sxe driver Jie Liu
2025-07-07 11:58 ` [PATCH v3 01/14] net/sxe: add base driver directory and doc Jie Liu
2025-07-07 11:58 ` [PATCH v3 02/14] net/sxe: add ethdev probe and remove Jie Liu
2025-07-07 14:57 ` Stephen Hemminger
2025-07-07 11:58 ` [PATCH v3 03/14] net/sxe: add tx rx setup and data path Jie Liu
2025-07-07 11:58 ` [PATCH v3 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function Jie Liu
2025-07-07 11:58 ` [PATCH v3 05/14] net/sxe: support vlan filter Jie Liu
2025-07-07 11:58 ` [PATCH v3 06/14] net/sxe: add filter function Jie Liu
2025-07-07 11:58 ` [PATCH v3 07/14] net/sxe: support rss offload Jie Liu
2025-07-07 11:58 ` [PATCH v3 08/14] net/sxe: add dcb function Jie Liu
2025-07-07 11:58 ` [PATCH v3 09/14] net/sxe: support ptp Jie Liu
2025-07-07 11:58 ` [PATCH v3 10/14] net/sxe: add xstats function Jie Liu
2025-07-07 11:58 ` [PATCH v3 11/14] net/sxe: add custom cmd led ctrl Jie Liu
2025-07-07 11:58 ` [PATCH v3 12/14] net/sxe: add simd function Jie Liu
2025-07-07 11:58 ` [PATCH v3 13/14] net/sxe: add virtual function Jie Liu
2025-07-07 11:58 ` [PATCH v3 14/14] net/sxe: add Solve compilation problems Jie Liu
2025-07-07 15:03 ` Stephen Hemminger
2025-07-07 15:56 ` Stephen Hemminger
2025-07-09 8:43 ` [PATCH v4 1/2] net/sxe: add base driver directory and doc Jie Liu
2025-07-09 8:43 ` [PATCH v4 2/2] net/sxe: add ethdev probe and remove Jie Liu
2025-07-09 16:13 ` Stephen Hemminger
2025-07-09 8:43 ` [PATCH v4 03/14] net/sxe: add tx rx setup and data path Jie Liu
2025-07-09 16:07 ` Stephen Hemminger
2025-07-09 8:43 ` [PATCH v4 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function Jie Liu
2025-07-09 16:09 ` Stephen Hemminger
2025-07-12 1:50 ` 刘洁 [this message]
2025-07-09 16:11 ` Stephen Hemminger
2025-07-09 8:43 ` [PATCH v4 05/14] net/sxe: support vlan filter Jie Liu
2025-07-09 8:43 ` [PATCH v4 06/14] net/sxe: add filter function Jie Liu
2025-07-09 8:43 ` [PATCH v4 07/14] net/sxe: support rss offload Jie Liu
2025-07-09 8:43 ` [PATCH v4 08/14] net/sxe: add dcb function Jie Liu
2025-07-09 8:43 ` [PATCH v4 09/14] net/sxe: support ptp Jie Liu
2025-07-09 8:43 ` [PATCH v4 10/14] net/sxe: add xstats function Jie Liu
2025-07-09 8:43 ` [PATCH v4 11/14] net/sxe: add custom cmd led ctrl Jie Liu
2025-07-09 8:43 ` [PATCH v4 12/14] net/sxe: add simd function Jie Liu
2025-07-09 8:43 ` [PATCH v4 13/14] net/sxe: add virtual function Jie Liu
2025-07-09 8:43 ` [PATCH v4 14/14] net/sxe: add Solve compilation problems Jie Liu
2025-07-09 16:14 ` Stephen Hemminger
2025-07-10 1:20 ` [PATCH v5 01/14] net/sxe: add base driver directory and doc Jie Liu
2025-07-10 1:20 ` [PATCH v5 02/14] net/sxe: add ethdev probe and remove Jie Liu
2025-07-10 1:20 ` [PATCH v5 03/14] net/sxe: add tx rx setup and data path Jie Liu
2025-07-10 1:20 ` [PATCH v5 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function Jie Liu
2025-07-10 1:20 ` [PATCH v5 05/14] net/sxe: support vlan filter Jie Liu
2025-07-10 1:20 ` [PATCH v5 06/14] net/sxe: add filter function Jie Liu
2025-07-10 1:20 ` [PATCH v5 07/14] net/sxe: support rss offload Jie Liu
2025-07-10 1:20 ` [PATCH v5 08/14] net/sxe: add dcb function Jie Liu
2025-07-10 1:20 ` [PATCH v5 09/14] net/sxe: support ptp Jie Liu
2025-07-10 1:20 ` [PATCH v5 10/14] net/sxe: add xstats function Jie Liu
2025-07-10 1:20 ` [PATCH v5 11/14] net/sxe: add custom cmd led ctrl Jie Liu
2025-07-10 1:20 ` [PATCH v5 12/14] net/sxe: add simd function Jie Liu
2025-07-10 1:20 ` [PATCH v5 13/14] net/sxe: add virtual function Jie Liu
2025-07-10 1:20 ` [PATCH v5 14/14] net/sxe: add Solve compilation problems Jie Liu
2025-07-12 6:18 ` [PATCH v6 01/14] net/sxe: add base driver directory and doc Jie Liu
2025-07-12 6:18 ` [PATCH v6 02/14] net/sxe: add ethdev probe and remove Jie Liu
2025-07-12 6:18 ` [PATCH v6 03/14] net/sxe: add tx rx setup and data path Jie Liu
2025-07-12 6:18 ` [PATCH v6 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function Jie Liu
2025-07-12 6:18 ` [PATCH v6 05/14] net/sxe: support vlan filter Jie Liu
2025-07-12 6:18 ` [PATCH v6 06/14] net/sxe: add filter function Jie Liu
2025-07-12 6:18 ` [PATCH v6 07/14] net/sxe: support rss offload Jie Liu
2025-07-12 6:18 ` [PATCH v6 08/14] net/sxe: add dcb function Jie Liu
2025-07-12 6:18 ` [PATCH v6 09/14] net/sxe: support ptp Jie Liu
2025-07-12 6:18 ` [PATCH v6 10/14] net/sxe: add xstats function Jie Liu
2025-07-12 6:18 ` [PATCH v6 11/14] net/sxe: add custom cmd led ctrl Jie Liu
2025-07-12 6:18 ` [PATCH v6 12/14] net/sxe: add simd function Jie Liu
2025-07-12 6:18 ` [PATCH v6 13/14] net/sxe: add virtual function Jie Liu
2025-07-12 6:18 ` [PATCH v6 14/14] net/sxe: add Solve compilation problems Jie Liu
2025-07-07 14:58 ` [PATCH v3 01/14] net/sxe: add base driver directory and doc Stephen Hemminger
2025-07-07 15:00 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=740842a2.37f15.197fc53ce1a.Coremail.liujie5@linkdatatechnology.com \
--to=liujie5@linkdatatechnology.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).