[PATCH v1 1/1] devtools: update sources in build tags script

[PATCH v1 1/1] devtools: update sources in build tags script

[Srikanth Yalavarthi]

As part of deprecating kmods meson option, 'kernel/linux'
directory is removed from the repository.

This patch removes non-existing 'kernel/linux' directory
from linux_sources of build tags script.

Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
 devtools/build-tags.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
index bf3b13ebac..e07349a47f 100755
--- a/devtools/build-tags.sh
+++ b/devtools/build-tags.sh
@@ -68,7 +68,6 @@ common_sources()
 linux_sources()
 {
 	find_sources "lib/eal/linux" '*.[chS]'
-	find_sources "kernel/linux" '*.[chS]'
 }
 
 bsd_sources()
-- 
2.42.0

Re: [PATCH v1 1/1] devtools: update sources in build tags script

[Ferruh Yigit]

On 11/8/2023 4:44 AM, Srikanth Yalavarthi wrote:
> As part of deprecating kmods meson option, 'kernel/linux'
> directory is removed from the repository.
> 
> This patch removes non-existing 'kernel/linux' directory
> from linux_sources of build tags script.
> 
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
>  devtools/build-tags.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> index bf3b13ebac..e07349a47f 100755
> --- a/devtools/build-tags.sh
> +++ b/devtools/build-tags.sh
> @@ -68,7 +68,6 @@ common_sources()
>  linux_sources()
>  {
>  	find_sources "lib/eal/linux" '*.[chS]'
> -	find_sources "kernel/linux" '*.[chS]'
>  }
>  
>  bsd_sources()

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>


Can you please add the fixes tag, it should be the commit that
deprecates kmods but missed to update this file?

RE: [EXT] Re: [PATCH v1 1/1] devtools: update sources in build tags script

[Srikanth Yalavarthi]

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: 08 November 2023 14:19
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; thomas@monjalon.net
> Subject: [EXT] Re: [PATCH v1 1/1] devtools: update sources in build tags script
> 
> External Email
> 
> ----------------------------------------------------------------------
> On 11/8/2023 4:44 AM, Srikanth Yalavarthi wrote:
> > As part of deprecating kmods meson option, 'kernel/linux'
> > directory is removed from the repository.
> >
> > This patch removes non-existing 'kernel/linux' directory from
> > linux_sources of build tags script.
> >
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > ---
> >  devtools/build-tags.sh | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh index
> > bf3b13ebac..e07349a47f 100755
> > --- a/devtools/build-tags.sh
> > +++ b/devtools/build-tags.sh
> > @@ -68,7 +68,6 @@ common_sources()
> >  linux_sources()
> >  {
> >  	find_sources "lib/eal/linux" '*.[chS]'
> > -	find_sources "kernel/linux" '*.[chS]'
> >  }
> >
> >  bsd_sources()
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> 
> 
> Can you please add the fixes tag, it should be the commit that deprecates
> kmods but missed to update this file?
Updated in v2.

[PATCH v2 1/1] devtools: update sources in build tags script

[Srikanth Yalavarthi]

As part of deprecating kmods meson option, 'kernel/linux'
directory is removed from the repository.

This patch removes non-existing 'kernel/linux' directory
from linux_sources of build tags script.

Fixes: a52d472c5c94 ("build: deprecate kmods meson option")

Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
 devtools/build-tags.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
index bf3b13ebac..e07349a47f 100755
--- a/devtools/build-tags.sh
+++ b/devtools/build-tags.sh
@@ -68,7 +68,6 @@ common_sources()
 linux_sources()
 {
 	find_sources "lib/eal/linux" '*.[chS]'
-	find_sources "kernel/linux" '*.[chS]'
 }
 
 bsd_sources()
-- 
2.42.0

RE: [PATCH v2 1/1] devtools: update sources in build tags script

[Morten Brørup]

> From: Srikanth Yalavarthi [mailto:syalavarthi@marvell.com]
> Sent: Wednesday, 8 November 2023 10.28
> 
> As part of deprecating kmods meson option, 'kernel/linux'
> directory is removed from the repository.
> 
> This patch removes non-existing 'kernel/linux' directory
> from linux_sources of build tags script.
> 
> Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> 
> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---

Acked-by: Morten Brørup <mb@smartsharesystems.com>

Re: [PATCH v2 1/1] devtools: update sources in build tags script

[Thomas Monjalon]

08/11/2023 10:28, Srikanth Yalavarthi:
> As part of deprecating kmods meson option, 'kernel/linux'
> directory is removed from the repository.
> 
> This patch removes non-existing 'kernel/linux' directory
> from linux_sources of build tags script.
> 
> Fixes: a52d472c5c94 ("build: deprecate kmods meson option")

If it is an old commit, you should probably add Cc: stable@dpdk.org
You can check with devtools/check-git-log.sh

> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>

You forgot the ack from Ferruh.

Srikanth, you are sending a lot of patches, which is good :)
but we will ask you to make an effort on getting all details.
You may read again the contributor's guide again.

RE: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script

[Srikanth Yalavarthi]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: 08 November 2023 16:54
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: Bruce Richardson <bruce.richardson@intel.com>; David Marchand
> <david.marchand@redhat.com>; Morten Brørup
> <mb@smartsharesystems.com>; Stephen Hemminger
> <stephen@networkplumber.org>; dev@dpdk.org; Srikanth Yalavarthi
> <syalavarthi@marvell.com>; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>
> Subject: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script
> 
> External Email
> 
> ----------------------------------------------------------------------
> 08/11/2023 10:28, Srikanth Yalavarthi:
> > As part of deprecating kmods meson option, 'kernel/linux'
> > directory is removed from the repository.
> >
> > This patch removes non-existing 'kernel/linux' directory from
> > linux_sources of build tags script.
> >
> > Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> 
> If it is an old commit, you should probably add Cc: stable@dpdk.org You can
> check with devtools/check-git-log.sh

The fixes commit (a52d472c5c94) was merged after 23.11-rc0. check-git-log.sh script wasn't suggested to submit this to stable@dpdk.log

My understanding is that Cc:stable@dpdk.org is need only if we need to backport the patch to older releases?

> 
> > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> 
> You forgot the ack from Ferruh.
> 
> Srikanth, you are sending a lot of patches, which is good :) but we will ask you
> to make an effort on getting all details.
> You may read again the contributor's guide again.

Thanks. Apologies, Missed including Ack. Will take care of this.
> 

Re: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script

[Thomas Monjalon]

08/11/2023 15:42, Srikanth Yalavarthi:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 08/11/2023 10:28, Srikanth Yalavarthi:
> > > As part of deprecating kmods meson option, 'kernel/linux'
> > > directory is removed from the repository.
> > >
> > > This patch removes non-existing 'kernel/linux' directory from
> > > linux_sources of build tags script.
> > >
> > > Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> > 
> > If it is an old commit, you should probably add Cc: stable@dpdk.org You can
> > check with devtools/check-git-log.sh
> 
> The fixes commit (a52d472c5c94) was merged after 23.11-rc0. check-git-log.sh script wasn't suggested to submit this to stable@dpdk.log
> 
> My understanding is that Cc:stable@dpdk.org is need only if we need to backport the patch to older releases?

Your understanding is correct.
But here:
	git describe a52d472c5c94
	v23.07-183-ga52d472c5c

> > > Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> > 
> > You forgot the ack from Ferruh.
> > 
> > Srikanth, you are sending a lot of patches, which is good :) but we will ask you
> > to make an effort on getting all details.
> > You may read again the contributor's guide again.
> 
> Thanks. Apologies, Missed including Ack. Will take care of this.

No problem, it's always a pleasure to see newcomers becoming regular contributors.

Re: [EXT] Re: [PATCH v2 1/1] devtools: update sources in build tags script

[Thomas Monjalon]

08/11/2023 16:23, Thomas Monjalon:
> 08/11/2023 15:42, Srikanth Yalavarthi:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 08/11/2023 10:28, Srikanth Yalavarthi:
> > > > As part of deprecating kmods meson option, 'kernel/linux'
> > > > directory is removed from the repository.
> > > >
> > > > This patch removes non-existing 'kernel/linux' directory from
> > > > linux_sources of build tags script.
> > > >
> > > > Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> > > 
> > > If it is an old commit, you should probably add Cc: stable@dpdk.org You can
> > > check with devtools/check-git-log.sh
> > 
> > The fixes commit (a52d472c5c94) was merged after 23.11-rc0. check-git-log.sh script wasn't suggested to submit this to stable@dpdk.log
> > 
> > My understanding is that Cc:stable@dpdk.org is need only if we need to backport the patch to older releases?
> 
> Your understanding is correct.
> But here:
> 	git describe a52d472c5c94
> 	v23.07-183-ga52d472c5c

No you are right, it is part of 23.11 cycle.

Applied with adding Ferruh's suggestion:

Fixes: f78c100bc871 ("remove KNI")
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

Re: [PATCH v2 1/1] devtools: update sources in build tags script

[Ferruh Yigit]

On 11/8/2023 9:28 AM, Srikanth Yalavarthi wrote:
> As part of deprecating kmods meson option, 'kernel/linux'
> directory is removed from the repository.
> 
> This patch removes non-existing 'kernel/linux' directory
> from linux_sources of build tags script.
> 
> Fixes: a52d472c5c94 ("build: deprecate kmods meson option")
> 

Practically [1] made below removed lines obsolete, and although above
commit actually removes the empty folder, it doesn't tell the full story
(why that folder is empty and not needed for tag creation).

I would go with [1] if there will be a new version.

[1]
Fixes: f78c100bc871 ("remove KNI")


> Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
> ---
>  devtools/build-tags.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/devtools/build-tags.sh b/devtools/build-tags.sh
> index bf3b13ebac..e07349a47f 100755
> --- a/devtools/build-tags.sh
> +++ b/devtools/build-tags.sh
> @@ -68,7 +68,6 @@ common_sources()
>  linux_sources()
>  {
>  	find_sources "lib/eal/linux" '*.[chS]'
> -	find_sources "kernel/linux" '*.[chS]'
>  }
>  
>  bsd_sources()