From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2EE70200 for ; Mon, 18 Dec 2017 21:59:15 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A37D920CE1; Mon, 18 Dec 2017 15:59:14 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 18 Dec 2017 15:59:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=nVv/o1/rHTNlJKn5Tr1hGY1eoI zRf2IE65Et4VRYVyw=; b=nb+biKKlcIeH5EXXjgF6FuHIMp7N+cyqGxicrbTo8q K4ANEOuyZJBTduWb82pokRXkEREAJcO79HdZer4JtQqKesoXJ1gf4VI5pvxnrRhe M24WH+a0Gd9WR/3pun7RWUJg9o6uRpXaNqClnLCf8KEUvpWKO0R/vMCDIJOQygoh 8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nVv/o1 /rHTNlJKn5Tr1hGY1eoIzRf2IE65Et4VRYVyw=; b=O988MxHuxS3y5Tu4BtQIEr jGl4AvR86m4KxQrZRNhyKHUB8ScfIDnwoJwU3C5jTTi3oeWBQeZaSq9QoWqRAP6M S50ZHoi5eG3qFxoG37dOUOSoyiJ8paMKeZldpzwnZ05crli7Me96NwAHtZDCa59A 7g4INS7G5VpdcO1Zp0IwUcH7N9Jr1wQ1vUBcTR18woWl67kTpwKNqYZNDrAFkqQ/ GZD6MeTk+6uQGgLe1z+mmMxvEkNw4SY1nhePxDo18IFjwFYAb8NCcrqUZTqWhonJ IjUesuw+YnWmXTzyNrIgVswPKV4J/cVW5XDfryv5VMyzFsVJwPtURkrH94uvRy8A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F77124009; Mon, 18 Dec 2017 15:59:14 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger , Adrien Mazarguil Cc: dev@dpdk.org, Ferruh Yigit Date: Mon, 18 Dec 2017 20:54:16 +0100 Message-ID: <7420927.98Cnld71HS@xps> In-Reply-To: <20171218102835.7602545f@xeon-e3> References: <20171124172132.GW4062@6wind.com> <20171218162443.12971-2-adrien.mazarguil@6wind.com> <20171218102835.7602545f@xeon-e3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 1/3] net/hyperv: introduce MS Hyper-V platform driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Dec 2017 20:59:15 -0000 18/12/2017 19:28, Stephen Hemminger: > On Mon, 18 Dec 2017 17:46:21 +0100 > Adrien Mazarguil wrote: > > > +#ifdef RTE_LIBRTE_HYPERV_DEBUG > > + > > +#define PMD_DRV_LOG(level, ...) \ > > + RTE_LOG(level, PMD, \ > > + RTE_FMT("%s:%u: %s(): " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > > + strrchr("/" __FILE__, '/') + 1, \ > > + __LINE__, \ > > + __func__, \ > > + RTE_FMT_TAIL(__VA_ARGS__,))) > > + > > +#else /* RTE_LIBRTE_HYPERV_DEBUG */ > > + > > +#define PMD_DRV_LOG(level, ...) \ > > + RTE_LOG(level, PMD, \ > > + RTE_FMT(RTE_STR(HYPERV_DRIVER) ": " \ > > + RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ > > + RTE_FMT_TAIL(__VA_ARGS__,))) > > + > > +#endif /* RTE_LIBRTE_HYPERV_DEBUG */ > > + > > +#define DEBUG(...) PMD_DRV_LOG(DEBUG, __VA_ARGS__) > > +#define INFO(...) PMD_DRV_LOG(INFO, __VA_ARGS__) > > +#define WARN(...) PMD_DRV_LOG(WARNING, __VA_ARGS__) > > +#define ERROR(...) PMD_DRV_LOG(ERR, __VA_ARGS__) > > + > > Please don't use DEBUG() etc macros. It makes it easier for tools that do > global updates or scans if all drivers use the same model of PMD_DRV_LOG The new standard is to use dynamic logtype.