From: Thomas Monjalon <thomas@monjalon.net>
To: Shijith Thotton <sthotton@marvell.com>
Cc: dev@dpdk.org, Jerin Jacob <jerinj@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Jerin Jacob <jerinjacobk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH] eal: add macro to swap two numbers
Date: Mon, 27 Sep 2021 18:32:38 +0200 [thread overview]
Message-ID: <74218650.t4zyzhSeNO@thomas> (raw)
In-Reply-To: <CALBAE1Mbosg2aE9CMkX_zGa6LbaFeMO5pBHzBZ7Stk7G_h3Q3w@mail.gmail.com>
06/09/2021 10:17, Jerin Jacob:
> On Wed, Jul 28, 2021 at 8:52 PM Shijith Thotton <sthotton@marvell.com> wrote:
> >
> > Added a macro to swap two numbers and updated common autotest for the
> > same.
> >
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
>
> > Needed-for: drivers: add external clock support for cnxk timer
>
> @Thomas Monjalon Could you merge this to the main tree if the patch
> looks OK to you.
>
> > --- a/lib/eal/include/rte_common.h
> > +++ b/lib/eal/include/rte_common.h
> > +/** Macro to swap two numbers. */
> > +#define RTE_SWAP(a, b) \
> > + __extension__ ({ \
> > + typeof (a) _a = a; \
> > + a = b; \
> > + b = _a; \
> > + })
Changing comment to:
/** Swap two variables. */
Applied, thanks.
prev parent reply other threads:[~2021-09-27 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 15:21 Shijith Thotton
2021-09-06 8:17 ` Jerin Jacob
2021-09-27 16:32 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74218650.t4zyzhSeNO@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=pbhagavatula@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).