DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Cc: dev@dpdk.org, jblunck@infradead.org
Subject: Re: [dpdk-dev] [PATCH] devargs: restore rte_devtype API
Date: Thu, 20 Jul 2017 00:32:12 +0300	[thread overview]
Message-ID: <7428826.qyDVAEg8QH@xps> (raw)
In-Reply-To: <afa3f094f6f150ba694da66bef905dd17a2a9bc3.1500141026.git.gaetan.rivet@6wind.com>

15/07/2017 20:59, Gaetan Rivet:
> Revert "devargs: make device types generic"
> 
> This commit broke the rte_devargs API by changing the meaning of
> the rte_devtype enum.
> 
> Restore the previous API, unit tests and function calls.
> Introduce parallel enum that acts as translation between previous API
> and current structures.
> 
> Restoring the previous API means that -w and -b are not usable anymore
> with any bus having implemented the "parse" operation. Only PCI devices
> can be used with -w and -b, virtual devices are declared using vdev.
> 
> This (partially) reverts commit bd279a79366f50a4893fb84db91bbf64b56f9fb1.
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> ---
> 
> As correctly pointed out by Jan Blunck in [1], the previous change breaks an existing API.
> This commit only deals with this API. Doing so however, restore the previous behavior as well.
> This means that the devargs behavior is iso-functional with that of the v17.05.
> It is possible, however, to explicitly set the bus in a device declaration.
> 
> [1]: http://dpdk.org/ml/archives/dev/2017-July/071318.html

Applied, thanks

      reply	other threads:[~2017-07-19 21:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15 17:59 Gaetan Rivet
2017-07-19 21:32 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7428826.qyDVAEg8QH@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=gaetan.rivet@6wind.com \
    --cc=jblunck@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).