From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 65C1B231E for ; Wed, 19 Jul 2017 23:32:14 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 09E2620953; Wed, 19 Jul 2017 17:32:14 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 19 Jul 2017 17:32:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=UWZpmq1RH4pw3l+ bou/H+TphIEWROw1I/mzykoEWZo8=; b=bt0jJ/rxp8KqFSJPxINkMDLu6xasb/k RyJH2TSgc9sTJ41dL7bNvqBefckZVt8M7R5gUzdd4yhfdMDleMX+YXkE2z+gVs9S px2D3/01BDSq/XtgUgifaacQOyw0tFE+jRtERmN+JIOPGpqrJA2YM2R/vdLsf7t4 dNTy+vIbD3BY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=UWZpmq1RH4pw3l+bou/H+TphIEWROw1I/mzykoEWZo8=; b=QdJRqQLo Ibz6BKJTCiRl5tv3C6v1zAxpy8P2MKM0x/XsJN4673dkBNv2fPJosUZiMRaVU0bN OzgHfe9BTQO+GvRD7gdfeg1hwD5sTEhp1ZKHq0AQFpsBT1JJcFxszDWLsLPCCxpZ wkOJwiT2hfX8BAFyMV8IgO0u8fQGjUPSmVThbqvLNUP+lLFCOclw/erNq4tUyOXr nRErt+MbmbCiJ8rb5kjYYR3SFoXTJWTALR8i55HihSxanh1Hj5nSTER+jbZ7Gkv2 u+czwfTVXQEDjgryPQXlkXDB8aSgl2bM5kckxJNk12pZie7bJvdxEzAEuUnmSshj WnLrxK/2RpbKpA== X-ME-Sender: X-Sasl-enc: l97JnKxYED55sJWjBjpLaBWfyRb9PXuI5CA/2Xq8l2ZW 1500499933 Received: from xps.localnet (bzq-164-168-31-206.red.bezeqint.net [31.168.164.206]) by mail.messagingengine.com (Postfix) with ESMTPA id 9989D7E057; Wed, 19 Jul 2017 17:32:13 -0400 (EDT) From: Thomas Monjalon To: Gaetan Rivet Cc: dev@dpdk.org, jblunck@infradead.org Date: Thu, 20 Jul 2017 00:32:12 +0300 Message-ID: <7428826.qyDVAEg8QH@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] devargs: restore rte_devtype API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jul 2017 21:32:14 -0000 15/07/2017 20:59, Gaetan Rivet: > Revert "devargs: make device types generic" > > This commit broke the rte_devargs API by changing the meaning of > the rte_devtype enum. > > Restore the previous API, unit tests and function calls. > Introduce parallel enum that acts as translation between previous API > and current structures. > > Restoring the previous API means that -w and -b are not usable anymore > with any bus having implemented the "parse" operation. Only PCI devices > can be used with -w and -b, virtual devices are declared using vdev. > > This (partially) reverts commit bd279a79366f50a4893fb84db91bbf64b56f9fb1. > > Signed-off-by: Gaetan Rivet > --- > > As correctly pointed out by Jan Blunck in [1], the previous change breaks an existing API. > This commit only deals with this API. Doing so however, restore the previous behavior as well. > This means that the devargs behavior is iso-functional with that of the v17.05. > It is possible, however, to explicitly set the bus in a device declaration. > > [1]: http://dpdk.org/ml/archives/dev/2017-July/071318.html Applied, thanks