* [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions
@ 2017-11-09 12:23 Akhil Goyal
2017-11-09 14:23 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 4+ messages in thread
From: Akhil Goyal @ 2017-11-09 12:23 UTC (permalink / raw)
To: dev; +Cc: declan.doherty, hemant.agrawal, radu.nicolau, thomas, Akhil Goyal
Fixes: c261d1431bd8 ("security: introduce security API and framework")
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
lib/librte_security/rte_security.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/librte_security/rte_security.h b/lib/librte_security/rte_security.h
index 7e687d2..653929b 100644
--- a/lib/librte_security/rte_security.h
+++ b/lib/librte_security/rte_security.h
@@ -266,6 +266,7 @@ struct rte_security_session_conf {
/**< Type of action to be performed on the session */
enum rte_security_session_protocol protocol;
/**< Security protocol to be configured */
+ RTE_STD_C11
union {
struct rte_security_ipsec_xform ipsec;
struct rte_security_macsec_xform macsec;
@@ -406,6 +407,7 @@ struct rte_security_stats {
enum rte_security_session_protocol protocol;
/**< Security protocol to be configured */
+ RTE_STD_C11
union {
struct rte_security_macsec_stats macsec;
struct rte_security_ipsec_stats ipsec;
@@ -486,6 +488,7 @@ struct rte_security_capability_idx {
enum rte_security_session_action_type action;
enum rte_security_session_protocol protocol;
+ RTE_STD_C11
union {
struct {
enum rte_security_ipsec_sa_protocol proto;
--
2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions
2017-11-09 12:23 [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions Akhil Goyal
@ 2017-11-09 14:23 ` De Lara Guarch, Pablo
2017-11-10 1:52 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2017-11-09 14:23 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: Doherty, Declan, hemant.agrawal, Nicolau, Radu, thomas
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal
> Sent: Thursday, November 9, 2017 12:24 PM
> To: dev@dpdk.org
> Cc: Doherty, Declan <declan.doherty@intel.com>;
> hemant.agrawal@nxp.com; Nicolau, Radu <radu.nicolau@intel.com>;
> thomas@monjalon.net; Akhil Goyal <akhil.goyal@nxp.com>
> Subject: [dpdk-dev] [PATCH] security: fix anonymous unions in structure
> definitions
>
> Fixes: c261d1431bd8 ("security: introduce security API and framework")
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions
2017-11-09 14:23 ` De Lara Guarch, Pablo
@ 2017-11-10 1:52 ` Thomas Monjalon
2017-11-10 2:15 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2017-11-10 1:52 UTC (permalink / raw)
To: Akhil Goyal
Cc: dev, De Lara Guarch, Pablo, Doherty, Declan, hemant.agrawal,
Nicolau, Radu
> > Fixes: c261d1431bd8 ("security: introduce security API and framework")
> >
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
I'm surprised we have not hit this issue before.
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions
2017-11-10 1:52 ` Thomas Monjalon
@ 2017-11-10 2:15 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2017-11-10 2:15 UTC (permalink / raw)
To: Thomas Monjalon, Akhil Goyal
Cc: dev, De Lara Guarch, Pablo, Doherty, Declan, hemant.agrawal,
Nicolau, Radu
On 11/9/2017 5:52 PM, Thomas Monjalon wrote:
>>> Fixes: c261d1431bd8 ("security: introduce security API and framework")
>>>
>>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>>
>> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> I'm surprised we have not hit this issue before.
I think this only can be observed with gcc pedantic option, we don't compile
DPDK with this option, only some drivers supports pedantic flag.
>
> Applied, thanks
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-10 2:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-09 12:23 [dpdk-dev] [PATCH] security: fix anonymous unions in structure definitions Akhil Goyal
2017-11-09 14:23 ` De Lara Guarch, Pablo
2017-11-10 1:52 ` Thomas Monjalon
2017-11-10 2:15 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).