From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] kni: fix unused variable compile error
Date: Fri, 14 Oct 2016 14:30:05 +0200 [thread overview]
Message-ID: <7457537.60EcOXE9kS@xps13> (raw)
In-Reply-To: <20161014112440.12966-1-ferruh.yigit@intel.com>
2016-10-14 12:24, Ferruh Yigit:
> compile error:
> CC [M] .../lib/librte_eal/linuxapp/kni/kni_misc.o
> cc1: warnings being treated as errors
> .../lib/librte_eal/linuxapp/kni/kni_misc.c: In function ‘kni_exit_net’:
> .../lib/librte_eal/linuxapp/kni/kni_misc.c:113:18:
> error: unused variable ‘knet’
>
> For some kernel versions mutex_destroy() is macro and does nothing,
> this cause an unused variable warning for knet which used in mutex_destroy
>
> Added unused attribute to the knet variable.
>
> Fixes: 93a298b34e1b ("kni: support core id parameter in single threaded mode")
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
That's why supporting an out-of-tree kernel module is a nightmare.
Compilation breaks everytime with various kernels :(
Please could you tell which Linux versions are affected?
next prev parent reply other threads:[~2016-10-14 12:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 11:24 Ferruh Yigit
2016-10-14 12:30 ` Thomas Monjalon [this message]
2016-10-14 16:41 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2016-10-14 20:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7457537.60EcOXE9kS@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).