From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id B3FA95934 for ; Fri, 14 Oct 2016 14:30:07 +0200 (CEST) Received: by mail-lf0-f49.google.com with SMTP id b75so193122816lfg.3 for ; Fri, 14 Oct 2016 05:30:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=uSDhAJEjt/4EOeTP3hfBDAM1nPAwplUomwFCCS6Pk2k=; b=zLQZFFzb205Kn0FO7j6uPGaW59Az63lGKCb2lXi9qGSXeSdqgJR3kWPP+dTzAWeOO2 t2XnuIuwAo358E+Oa9dYi7//j4Jjbk2nwTEBBf8y9DdKnoXfHPtEeGXyd1f7btam2CUE AaMln/bgSFY+baYVU6cQ9Ergz2nHFDdXJx/EhCqI8RJ9Zc/WC6hRwwTNEL8JMMQah1ed M5QyD5irfbit6CDMhwqSTFKleBtDqNioUW21qLTxBDYo0UJR6JojqZ8B91d2jSsAeWva nhQQJQzEl/0PEBmcyGcDR+C9dZ8DS6OZvXRaJxVXH7/mDfVrvfIrTUn50Iu8O0g6HAZp zcKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=uSDhAJEjt/4EOeTP3hfBDAM1nPAwplUomwFCCS6Pk2k=; b=AgfXWPTydKn97/NI6qsnJa+Q+w6HQ8Yb03E57Re9J+rNR6JmS/B8q0p/bCkJJHAKUZ tS9C2//vU+g3Keve8WE5H6UoPOB6z8781Msicor9NHIeJR6aOFdMffywOZ5qHjbYhz4P 6KSUPIpKwjL/wPLJOKrKYBj8FlfVltuOsPvYWf5V9/Wbenw9XmE/lJeLFNDq52FrbnNW KjTC0hMsYsG5ac1kY7O0GcP0jD5oJtXV37qMMu0hWyoSr3+kt0Zi+nJFB3ImRFUZYlwj nSTTem0ASs/O8Os6lZhe74tNeqHpwwJpOa90vsUY1BU4n1/ihkdqKqaUUgYBkIkuxwWv 62HQ== X-Gm-Message-State: AA6/9RnwAfGwoCtXL5+EhMtiXNP+KJgK0CNQnqSqiOnNQkFCDvjDrBRVzdnWLueN+cpNMafr X-Received: by 10.25.152.130 with SMTP id a124mr3454017lfe.33.1476448207037; Fri, 14 Oct 2016 05:30:07 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id t84sm1285184lff.27.2016.10.14.05.30.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Oct 2016 05:30:06 -0700 (PDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org Date: Fri, 14 Oct 2016 14:30:05 +0200 Message-ID: <7457537.60EcOXE9kS@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161014112440.12966-1-ferruh.yigit@intel.com> References: <20161014112440.12966-1-ferruh.yigit@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH] kni: fix unused variable compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 12:30:08 -0000 2016-10-14 12:24, Ferruh Yigit: > compile error: > CC [M] .../lib/librte_eal/linuxapp/kni/kni_misc.o > cc1: warnings being treated as errors > .../lib/librte_eal/linuxapp/kni/kni_misc.c: In function =E2=80=98kni_= exit_net=E2=80=99: > .../lib/librte_eal/linuxapp/kni/kni_misc.c:113:18: > error: unused variable =E2=80=98knet=E2=80=99 >=20 > For some kernel versions mutex_destroy() is macro and does nothing, > this cause an unused variable warning for knet which used in mutex_de= stroy >=20 > Added unused attribute to the knet variable. >=20 > Fixes: 93a298b34e1b ("kni: support core id parameter in single thread= ed mode") >=20 > Signed-off-by: Ferruh Yigit That's why supporting an out-of-tree kernel module is a nightmare. Compilation breaks everytime with various kernels :( Please could you tell which Linux versions are affected?