* [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD
@ 2023-11-03 23:45 Nicolas Chautru
2023-11-03 23:45 ` [PATCH v1 1/1] baseband/acc: fix for TB mode on VRB1 Nicolas Chautru
2023-11-09 15:50 ` [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD Maxime Coquelin
0 siblings, 2 replies; 4+ messages in thread
From: Nicolas Chautru @ 2023-11-03 23:45 UTC (permalink / raw)
To: dev, maxime.coquelin; +Cc: hernan.vargas, stable, Nicolas Chautru
Fix bug for the VRB1 PMD in LDPC Encoder TB mode.
Targeting the rc3 if possible.
Nicolas Chautru (1):
baseband/acc: fix for TB mode on VRB1
drivers/baseband/acc/rte_vrb_pmd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] baseband/acc: fix for TB mode on VRB1
2023-11-03 23:45 [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD Nicolas Chautru
@ 2023-11-03 23:45 ` Nicolas Chautru
2023-11-09 10:07 ` Maxime Coquelin
2023-11-09 15:50 ` [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD Maxime Coquelin
1 sibling, 1 reply; 4+ messages in thread
From: Nicolas Chautru @ 2023-11-03 23:45 UTC (permalink / raw)
To: dev, maxime.coquelin; +Cc: hernan.vargas, stable, Nicolas Chautru
The input size is computed incorrectly for the
LDPC encoder TB processing.
Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing")
Cc: stable@dpdk.org
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
drivers/baseband/acc/rte_vrb_pmd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c
index ae230b828a..686e086a5c 100644
--- a/drivers/baseband/acc/rte_vrb_pmd.c
+++ b/drivers/baseband/acc/rte_vrb_pmd.c
@@ -2218,7 +2218,8 @@ vrb1_enqueue_ldpc_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op
uint16_t init_enq_descs = enq_descs;
uint32_t in_offset = 0, out_offset = 0;
- input_len_B = ((op->ldpc_enc.basegraph == 1 ? 22 : 10) * op->ldpc_enc.z_c) >> 3;
+ input_len_B = ((op->ldpc_enc.basegraph == 1 ? 22 : 10) * op->ldpc_enc.z_c
+ - op->ldpc_enc.n_filler) >> 3;
if (check_bit(op->ldpc_enc.op_flags, RTE_BBDEV_LDPC_CRC_24B_ATTACH))
input_len_B -= 3;
--
2.34.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] baseband/acc: fix for TB mode on VRB1
2023-11-03 23:45 ` [PATCH v1 1/1] baseband/acc: fix for TB mode on VRB1 Nicolas Chautru
@ 2023-11-09 10:07 ` Maxime Coquelin
0 siblings, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2023-11-09 10:07 UTC (permalink / raw)
To: Nicolas Chautru, dev; +Cc: hernan.vargas, stable
On 11/4/23 00:45, Nicolas Chautru wrote:
> The input size is computed incorrectly for the
> LDPC encoder TB processing.
>
> Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
> ---
> drivers/baseband/acc/rte_vrb_pmd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c
> index ae230b828a..686e086a5c 100644
> --- a/drivers/baseband/acc/rte_vrb_pmd.c
> +++ b/drivers/baseband/acc/rte_vrb_pmd.c
> @@ -2218,7 +2218,8 @@ vrb1_enqueue_ldpc_enc_one_op_tb(struct acc_queue *q, struct rte_bbdev_enc_op *op
> uint16_t init_enq_descs = enq_descs;
> uint32_t in_offset = 0, out_offset = 0;
>
> - input_len_B = ((op->ldpc_enc.basegraph == 1 ? 22 : 10) * op->ldpc_enc.z_c) >> 3;
> + input_len_B = ((op->ldpc_enc.basegraph == 1 ? 22 : 10) * op->ldpc_enc.z_c
> + - op->ldpc_enc.n_filler) >> 3;
>
> if (check_bit(op->ldpc_enc.op_flags, RTE_BBDEV_LDPC_CRC_24B_ATTACH))
> input_len_B -= 3;
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD
2023-11-03 23:45 [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD Nicolas Chautru
2023-11-03 23:45 ` [PATCH v1 1/1] baseband/acc: fix for TB mode on VRB1 Nicolas Chautru
@ 2023-11-09 15:50 ` Maxime Coquelin
1 sibling, 0 replies; 4+ messages in thread
From: Maxime Coquelin @ 2023-11-09 15:50 UTC (permalink / raw)
To: Nicolas Chautru, dev; +Cc: hernan.vargas, stable
On 11/4/23 00:45, Nicolas Chautru wrote:
> Fix bug for the VRB1 PMD in LDPC Encoder TB mode.
> Targeting the rc3 if possible.
>
> Nicolas Chautru (1):
> baseband/acc: fix for TB mode on VRB1
>
> drivers/baseband/acc/rte_vrb_pmd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Applied to next-baseband/for-main.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-09 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-03 23:45 [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD Nicolas Chautru
2023-11-03 23:45 ` [PATCH v1 1/1] baseband/acc: fix for TB mode on VRB1 Nicolas Chautru
2023-11-09 10:07 ` Maxime Coquelin
2023-11-09 15:50 ` [PATCH v1 0/1] baseband/acc: fix for VRB1 PMD Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).