From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C389DA04B7; Tue, 13 Oct 2020 18:12:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 765D11DA80; Tue, 13 Oct 2020 18:12:47 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B8B991C2B3; Tue, 13 Oct 2020 18:12:44 +0200 (CEST) IronPort-SDR: 5NXtYRYcA0TMIqLgHaViaU1ShJ8yu/VXnxr6h4cmA5SncqFaLGzZK7oEB6pEcM4POeguS5CxjC WZAymvdmJcxg== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="165148353" X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="165148353" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 09:12:42 -0700 IronPort-SDR: UAkVQkUA4xpbtwWhZezyCeUgIpgHr+K8vVwXgxse0rsDhG392heAekxDEJqNwNhzl6qEXoiHlV I/8euH7zOq9g== X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="530453814" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64]) ([10.213.214.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 09:12:41 -0700 To: Andrew Rybchenko , dev@dpdk.org Cc: Thomas Monjalon , "techboard@dpdk.org" References: <1602600818-7473-1-git-send-email-arybchenko@solarflare.com> <8f8907cf-d905-c867-cf42-694d16b0a0cf@intel.com> <236f87f5-c798-4d83-b821-abed61253191@oktetlabs.ru> From: Ferruh Yigit Message-ID: <746882bb-79ee-a368-4dee-20846f4f9070@intel.com> Date: Tue, 13 Oct 2020 17:12:38 +0100 MIME-Version: 1.0 In-Reply-To: <236f87f5-c798-4d83-b821-abed61253191@oktetlabs.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] ethdev: unify error code if port ID is invalid X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2020 4:39 PM, Andrew Rybchenko wrote: > On 10/13/20 6:32 PM, Ferruh Yigit wrote: >> On 10/13/2020 3:53 PM, Andrew Rybchenko wrote: >>> Use ENODEV as the error code if specified port ID is invalid. >>> >>> Signed-off-by: Andrew Rybchenko >>> --- >>>   lib/librte_ethdev/rte_ethdev.c | 44 ++++++++++++++++---------------- >>>   lib/librte_ethdev/rte_ethdev.h | 46 +++++++++++++++++++++++----------- >>>   2 files changed, 54 insertions(+), 36 deletions(-) >>> >>> diff --git a/lib/librte_ethdev/rte_ethdev.c >>> b/lib/librte_ethdev/rte_ethdev.c >>> index 5b7979a3b8..1f862f918a 100644 >>> --- a/lib/librte_ethdev/rte_ethdev.c >>> +++ b/lib/librte_ethdev/rte_ethdev.c >>> @@ -784,7 +784,7 @@ rte_eth_dev_get_name_by_port(uint16_t port_id, >>> char *name) >>>   { >>>       char *tmp; >>>   -    RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL); >>> +    RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); >> >> Thanks Andrew, +1 to this error unification. >> >> This will be API change without deprecation notice, cc'ed techboard for it. > > Yes, thanks. > >> >> If this should (almost) always return '-ENODEV', does it make sense to >> make another wrapper macro for it, to prevent later other error types >> used again. > > Unlikely, since most likely the line will be simply copied. > RTE_ETH_VALID_PORTID_OR_ERR_RET will remain in any case, so > it will be possible to misuse it anyway. > Agree it won't prevent misuse completely but may help, anyway I don't have a strong opinion here, if you think that is not needed, that is OK. >> >> And there are a few instances returning '-1', are they left intentionally? > > Yes. Inside ethdev it is either socket_id or fd in these cases. > Can't those two also updated to return '-ENODEV' when 'port_id' is not valid?