From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Andrew Rybchenko <arybchenko@solarflare.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support
Date: Mon, 1 Oct 2018 17:11:50 +0100 [thread overview]
Message-ID: <7483435a-0c8e-47d6-0e4f-8fdc3741b2a7@intel.com> (raw)
In-Reply-To: <20181001155945.GB1570@jerin>
On 10/1/2018 4:59 PM, Jerin Jacob wrote:
> -----Original Message-----
>> Date: Mon, 1 Oct 2018 14:46:39 +0100
>> From: Ferruh Yigit <ferruh.yigit@intel.com>
>> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Wenzhuo Lu
>> <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard
>> Iremonger <bernard.iremonger@intel.com>, John McNamara
>> <john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,
>> Thomas Monjalon <thomas@monjalon.net>, Andrew Rybchenko
>> <arybchenko@solarflare.com>
>> CC: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload
>> support
>> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
>> Thunderbird/52.9.1
>>
>>
>> On 9/13/2018 2:47 PM, Jerin Jacob wrote:
>>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>>
>> Overall set looks good to me, I put some comments on individual patches.
>>
>> And can you please rebase on top of latest head?
>
> Sure.
>
> Regarding space issue mentioned in other email in this thread.
> It looks like similar space added in other offloads.
> example: http://git.dpdk.org/dpdk/tree/app/test-pmd/config.c#n571
Hi Jerin,
This is just detail, the alignment is broken in the output of the log, for
others on/off start from column 56, for this one it is 57, just delete a space
from printf please.
>
> So, I expect no change in this patch other than rebase to latest head.
> If not, let me know.
>
>>
>> Thanks,
>> ferruh
>>
next prev parent reply other threads:[~2018-10-01 16:12 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 13:47 Jerin Jacob
2018-09-13 13:47 ` [dpdk-dev] [PATCH 2/4] mbuf: fix Tx offload mask Jerin Jacob
2018-10-01 13:45 ` Ferruh Yigit
2018-10-01 15:53 ` Jerin Jacob
2018-10-01 16:13 ` Ferruh Yigit
2018-09-13 13:47 ` [dpdk-dev] [PATCH 3/4] ethdev: add Rx offload outer L4 checksum definitions Jerin Jacob
2018-09-13 17:24 ` Shahaf Shuler
2018-09-14 3:05 ` Jerin Jacob
2018-09-16 5:53 ` Shahaf Shuler
2018-09-16 9:32 ` Jerin Jacob
2018-09-13 13:47 ` [dpdk-dev] [PATCH 4/4] ethdev: add Tx " Jerin Jacob
2018-10-01 13:45 ` Ferruh Yigit
2018-10-02 9:52 ` Jerin Jacob
2018-10-01 13:45 ` [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support Ferruh Yigit
2018-10-01 13:46 ` Ferruh Yigit
2018-10-01 15:59 ` Jerin Jacob
2018-10-01 16:11 ` Ferruh Yigit [this message]
2018-10-02 8:53 ` Jerin Jacob
2018-10-02 9:13 ` Ferruh Yigit
2018-10-02 10:51 ` [dpdk-dev] [PATCH v2 1/2] " Jerin Jacob
2018-10-02 10:51 ` [dpdk-dev] [PATCH v2 2/2] mbuf: fix Tx offload mask Jerin Jacob
2018-10-04 2:31 ` Hu, Jiayu
2018-10-04 16:05 ` Ferruh Yigit
2018-10-03 18:52 ` [dpdk-dev] [PATCH v2 1/2] ethdev: add SCTP Rx checksum offload support Ferruh Yigit
2018-10-02 19:24 ` [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition Jerin Jacob
2018-10-02 19:24 ` [dpdk-dev] [PATCH v2 2/4] ethdev: add Tx " Jerin Jacob
2018-10-03 7:41 ` Andrew Rybchenko
2018-10-03 7:58 ` Jerin Jacob
2018-10-03 8:02 ` Ferruh Yigit
2018-10-03 8:36 ` Thomas Monjalon
2018-10-03 10:52 ` Iremonger, Bernard
2018-10-02 19:24 ` [dpdk-dev] [PATCH v2 3/4] app/testpmd: add outer UDP HW checksum support Jerin Jacob
2018-10-03 13:23 ` Iremonger, Bernard
2018-10-02 19:24 ` [dpdk-dev] [PATCH v2 4/4] app/testpmd: collect bad outer L4 checksum for csum engine Jerin Jacob
2018-10-03 8:29 ` Andrew Rybchenko
2018-10-03 7:34 ` [dpdk-dev] [PATCH v2 1/4] ethdev: add Rx offload outer UDP checksum definition Andrew Rybchenko
2018-10-03 7:57 ` Jerin Jacob
2018-10-03 8:35 ` Thomas Monjalon
2018-10-03 8:36 ` Andrew Rybchenko
2018-10-03 17:12 ` Jerin Jacob
2018-10-03 18:00 ` Andrew Rybchenko
2018-10-03 18:14 ` Jerin Jacob
2018-10-03 19:47 ` Andrew Rybchenko
2018-10-03 20:08 ` Thomas Monjalon
2018-10-04 5:59 ` Jerin Jacob
2018-10-05 19:48 ` Ferruh Yigit
2018-10-05 20:04 ` Ferruh Yigit
2018-10-05 22:44 ` Thomas Monjalon
2018-10-06 8:15 ` Jerin Jacob
2018-10-06 12:18 ` Ananyev, Konstantin
2018-10-08 8:12 ` Ferruh Yigit
2018-10-08 8:24 ` Jerin Jacob
2018-10-08 9:04 ` Thomas Monjalon
2018-10-08 9:37 ` Jerin Jacob
2018-10-08 10:53 ` Ferruh Yigit
2018-10-08 11:55 ` Jerin Jacob
2018-10-08 12:13 ` Ferruh Yigit
2018-10-08 12:25 ` Jerin Jacob
2018-10-08 13:03 ` Thomas Monjalon
2018-10-08 13:08 ` Jerin Jacob
2018-10-03 8:53 ` Ananyev, Konstantin
2018-10-03 8:59 ` Jerin Jacob
2018-10-03 9:17 ` Ananyev, Konstantin
2018-10-03 9:22 ` Jerin Jacob
2018-10-03 10:16 ` Ananyev, Konstantin
2018-10-03 11:15 ` Jerin Jacob
2018-10-03 10:51 ` Iremonger, Bernard
2018-10-03 11:19 ` Jerin Jacob
2018-10-03 13:00 ` Iremonger, Bernard
2018-10-03 18:16 ` [dpdk-dev] [PATCH v3 " Jerin Jacob
2018-10-03 18:16 ` [dpdk-dev] [PATCH v3 2/4] ethdev: add Tx " Jerin Jacob
2018-10-03 18:16 ` [dpdk-dev] [PATCH v3 3/4] app/testpmd: add outer UDP HW checksum support Jerin Jacob
2018-10-03 18:16 ` [dpdk-dev] [PATCH v3 4/4] app/testpmd: collect bad outer L4 checksum for csum engine Jerin Jacob
2018-10-04 13:45 ` Iremonger, Bernard
2018-10-04 14:16 ` Jerin Jacob
2018-10-04 15:06 ` Iremonger, Bernard
2018-10-08 16:09 ` [dpdk-dev] [PATCH v4 1/4] ethdev: add Rx offload outer UDP checksum definition Jerin Jacob
2018-10-08 16:09 ` [dpdk-dev] [PATCH v4 2/4] ethdev: add Tx " Jerin Jacob
2018-10-09 10:06 ` Andrew Rybchenko
2018-10-08 16:09 ` [dpdk-dev] [PATCH v4 3/4] app/testpmd: add outer UDP HW checksum support Jerin Jacob
2018-10-08 16:09 ` [dpdk-dev] [PATCH v4 4/4] app/testpmd: collect bad outer L4 checksum for csum engine Jerin Jacob
2018-10-09 10:06 ` [dpdk-dev] [PATCH v4 1/4] ethdev: add Rx offload outer UDP checksum definition Andrew Rybchenko
2018-10-09 14:18 ` [dpdk-dev] [PATCH v5 " Jerin Jacob
2018-10-09 14:18 ` [dpdk-dev] [PATCH v5 2/4] ethdev: add Tx " Jerin Jacob
2018-10-09 14:18 ` [dpdk-dev] [PATCH v5 3/4] app/testpmd: add outer UDP HW checksum support Jerin Jacob
2018-10-09 14:18 ` [dpdk-dev] [PATCH v5 4/4] app/testpmd: collect bad outer L4 checksum for csum engine Jerin Jacob
2018-10-09 16:46 ` [dpdk-dev] [PATCH v5 1/4] ethdev: add Rx offload outer UDP checksum definition Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7483435a-0c8e-47d6-0e4f-8fdc3741b2a7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).