From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 21D081B3BB for ; Mon, 1 Oct 2018 18:12:05 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Oct 2018 09:12:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,328,1534834800"; d="scan'208";a="95489253" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga001.jf.intel.com with ESMTP; 01 Oct 2018 09:11:50 -0700 To: Jerin Jacob Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , John McNamara , Marko Kovacevic , Thomas Monjalon , Andrew Rybchenko , dev@dpdk.org References: <20180913134707.23698-1-jerin.jacob@caviumnetworks.com> <20181001155945.GB1570@jerin> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <7483435a-0c8e-47d6-0e4f-8fdc3741b2a7@intel.com> Date: Mon, 1 Oct 2018 17:11:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181001155945.GB1570@jerin> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Oct 2018 16:12:06 -0000 On 10/1/2018 4:59 PM, Jerin Jacob wrote: > -----Original Message----- >> Date: Mon, 1 Oct 2018 14:46:39 +0100 >> From: Ferruh Yigit >> To: Jerin Jacob , Wenzhuo Lu >> , Jingjing Wu , Bernard >> Iremonger , John McNamara >> , Marko Kovacevic , >> Thomas Monjalon , Andrew Rybchenko >> >> CC: dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: add SCTP Rx checksum offload >> support >> User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 >> Thunderbird/52.9.1 >> >> >> On 9/13/2018 2:47 PM, Jerin Jacob wrote: >>> Signed-off-by: Jerin Jacob >> >> Overall set looks good to me, I put some comments on individual patches. >> >> And can you please rebase on top of latest head? > > Sure. > > Regarding space issue mentioned in other email in this thread. > It looks like similar space added in other offloads. > example: http://git.dpdk.org/dpdk/tree/app/test-pmd/config.c#n571 Hi Jerin, This is just detail, the alignment is broken in the output of the log, for others on/off start from column 56, for this one it is 57, just delete a space from printf please. > > So, I expect no change in this patch other than rebase to latest head. > If not, let me know. > >> >> Thanks, >> ferruh >>