From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <remy.horton@intel.com> Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id EFD381B646 for <dev@dpdk.org>; Tue, 3 Apr 2018 10:49:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Apr 2018 01:49:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,400,1517904000"; d="scan'208";a="40296107" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.27]) ([163.33.230.27]) by orsmga003.jf.intel.com with ESMTP; 03 Apr 2018 01:49:29 -0700 To: Thomas Monjalon <thomas@monjalon.net> References: <20180321142749.27520-1-remy.horton@intel.com> <20180321142749.27520-5-remy.horton@intel.com> <5922778.WOJhgh4gTO@xps> Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>, Shreyansh Jain <shreyansh.jain@nxp.com> From: Remy Horton <remy.horton@intel.com> Organization: Intel Shannon Limited Message-ID: <7488da21-658e-5cb7-ee9d-56608d5a6782@intel.com> Date: Tue, 3 Apr 2018 09:49:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <5922778.WOJhgh4gTO@xps> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 03 Apr 2018 08:49:35 -0000 On 31/03/2018 01:01, Thomas Monjalon wrote: [..] >> uint16_t nb_rxd = RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX descriptors. */ >> uint16_t nb_txd = RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX descriptors. */ > > These doxygen comments in the middle of the code are totally useless. Did wonder why they were there. However these lines are existing code, and since testpmd.c uses Doxygen tags extensively, removing them in my view ought to be done via a separate clean-up patch.